Re: [PATCH v4 08/18] iommu/mediatek: Add larb-id remapped support

2018-12-21 Thread Yong Wu
Hi Nicolas, Thanks for the review of this patchset. On Fri, 2018-12-21 at 11:35 +0800, Nicolas Boichat wrote: > On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote: > > > > The larb-id may be remapped in the smi-common, this means the > > larb-id reported in the mtk_iommu_isr isn't the real larb-id, >

Re: [PATCH v4 13/18] memory: mtk-smi: Add bus_sel for mt8183

2018-12-21 Thread Yong Wu
On Fri, 2018-12-21 at 12:47 +0800, Nicolas Boichat wrote: > On Sat, Dec 8, 2018 at 4:43 PM Yong Wu wrote: > > > > There are 2 mmu cells in a M4U HW. we could adjust some larbs entering > > mmu0 or mmu1 to balance the bandwidth via the smi-common register > > SMI_BUS_SEL(0x220)(Each larb occupy 2

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-21 Thread Yong Wu
On Fri, 2018-12-21 at 12:43 +0800, Nicolas Boichat wrote: > On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote: > > > > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use > > the ARM Short-descriptor like mt8173, and most of the HW registers > > are the same. > > > > Here list main

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-21 Thread Nicolas Boichat
On Fri, Dec 21, 2018 at 4:02 PM Yong Wu wrote: > > On Fri, 2018-12-21 at 12:43 +0800, Nicolas Boichat wrote: > > On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote: > > > > > > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use > > > the ARM Short-descriptor like mt8173, and most of

Re: [GIT PULL] dma-mapping updates for Linux 4.21

2018-12-21 Thread Christoph Hellwig
On Fri, Dec 21, 2018 at 10:45:49AM +0100, Christoph Hellwig wrote: > The following changes since commit c9d76d0655c06b8c1f944e46c4fd9e9cf4b331c0: > > dma-mapping: fix return type of dma_set_max_seg_size() (2018-11-27 08:39:52 > +0100) And that actually is the first commit already in the tree,

[GIT PULL] dma-mapping updates for Linux 4.21

2018-12-21 Thread Christoph Hellwig
Hi Linus, an early pull request as requested. Besides the usual contextual conflicts in Kconfig files that can be solved by taking both updates and applying them manually there are some real conflicts this time: - the RISC-V tree has some updates to

Re: question about broadcast invalidation and atc invalidation

2018-12-21 Thread Jean-Philippe Brucker
Hi, On 21/12/2018 09:31, Zhongmiao wrote: > Hi Jean: > Now Soft need to make sure build atc inv cmd to smmu after Execute > "TLBI" (dvm sync). I don't think it's very reasonable. Why Smmu The > smmu automatically sends the inv atc command when smmu receive > broadcast invalidation ?

Re: [PATCH v4 03/18] memory: mtk-smi: Use a general config_port interface

2018-12-21 Thread Yong Wu
On Fri, 2018-12-21 at 18:47 +0100, Matthias Brugger wrote: > > On 08/12/2018 09:39, Yong Wu wrote: > > The config_port of mt2712 and mt8183 are the same. Use a general > > config_port interface instead. > > > > In addition, in mt2712, larb8 and larb9 are the bdpsys larbs which > > are not the

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-21 Thread Yong Wu
On Sat, 2018-12-22 at 08:31 +0800, Nicolas Boichat wrote: > On Fri, Dec 21, 2018 at 4:02 PM Yong Wu wrote: > > > > On Fri, 2018-12-21 at 12:43 +0800, Nicolas Boichat wrote: > > > On Sat, Dec 8, 2018 at 4:42 PM Yong Wu wrote: > > > > > > > > The M4U IP blocks in mt8183 is MediaTek's generation2

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-21 Thread Yong Wu
On Fri, 2018-12-21 at 19:31 +0100, Matthias Brugger wrote: > > On 08/12/2018 09:39, Yong Wu wrote: > > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use > > the ARM Short-descriptor like mt8173, and most of the HW registers > > are the same. > > > > Here list main differences

Re: [PATCH v4 10/18] iommu/mediatek: Add mt8183 IOMMU support

2018-12-21 Thread Matthias Brugger
On 08/12/2018 09:39, Yong Wu wrote: > The M4U IP blocks in mt8183 is MediaTek's generation2 M4U which use > the ARM Short-descriptor like mt8173, and most of the HW registers > are the same. > > Here list main differences between mt8183 and mt8173/mt2712: > 1) mt8183 has only one M4U HW like

Re: [PATCH v4 02/18] iommu/mediatek: Use a struct as the platform data

2018-12-21 Thread Matthias Brugger
On 08/12/2018 09:39, Yong Wu wrote: > Use a struct as the platform special data instead of the enumeration. > This is a prepare patch for adding mt8183 iommu support. > > Signed-off-by: Yong Wu > --- Reviewed-by: Matthias Brugger > drivers/iommu/mtk_iommu.c | 24 >

Re: [PATCH v4 03/18] memory: mtk-smi: Use a general config_port interface

2018-12-21 Thread Matthias Brugger
On 08/12/2018 09:39, Yong Wu wrote: > The config_port of mt2712 and mt8183 are the same. Use a general > config_port interface instead. > > In addition, in mt2712, larb8 and larb9 are the bdpsys larbs which > are not the normal larb, their register space are different from the > normal one.

Re: [PATCH v4 04/18] memory: mtk-smi: Use a struct for the platform data for smi-common

2018-12-21 Thread Matthias Brugger
On 08/12/2018 09:39, Yong Wu wrote: > Use a struct as the platform special data instead of the enumeration. > > Also there is a minor change that moving the position of > "enum mtk_smi_gen" definition, this is because we expect define > "struct mtk_smi_common_plat" before it is referred. > >