Re: [PATCH v2 02/17] driver core: Add dma_unconfigure callback in bus_type

2021-11-28 Thread Lu Baolu
On 11/28/21 4:02 PM, Greg Kroah-Hartman wrote: On Sun, Nov 28, 2021 at 10:50:36AM +0800, Lu Baolu wrote: The bus_type structure defines dma_configure() callback for bus drivers to configure DMA on the devices. This adds the paired dma_unconfigure() callback and calls it during driver unbinding

Re: [PATCH v2 00/17] Fix BUG_ON in vfio_iommu_group_notifier()

2021-11-28 Thread Lu Baolu
Hi Greg, On 11/28/21 4:10 PM, Greg Kroah-Hartman wrote: On Sun, Nov 28, 2021 at 10:50:34AM +0800, Lu Baolu wrote: The original post and intent of this series is here. https://lore.kernel.org/linux-iommu/2025020552.2378167-1-baolu...@linux.intel.com/ Please put the intent in the message,

Re: [PATCH v2 04/17] driver core: platform: Add driver dma ownership management

2021-11-28 Thread Jason Gunthorpe via iommu
On Sun, Nov 28, 2021 at 09:10:14AM +0100, Greg Kroah-Hartman wrote: > On Sun, Nov 28, 2021 at 10:50:38AM +0800, Lu Baolu wrote: > > Multiple platform devices may be placed in the same IOMMU group because > > they cannot be isolated from each other. These devices must either be > > entirely under

Re: [patch 29/37] PCI/MSI: Use __msi_get_virq() in pci_get_vector()

2021-11-28 Thread Thomas Gleixner
On Sun, Nov 28 2021 at 19:37, Marc Zyngier wrote: > On Sat, 27 Nov 2021 01:22:03 +, > Thomas Gleixner wrote: > > I worked around it with the hack below, but I doubt this is the real > thing. portdrv_core.c does complicated things, and I don't completely > understand its logic. > > M. >

Re: [patch 00/37] genirq/msi, PCI/MSI: Spring cleaning - Part 2

2021-11-28 Thread Thomas Gleixner
On Sat, Nov 27 2021 at 20:39, Jason Gunthorpe wrote: > On Sat, Nov 27, 2021 at 02:21:17AM +0100, Thomas Gleixner wrote: >>4) Provide a function to retrieve the Linux interrupt number for a given >> MSI index similar to pci_irq_vector() and cleanup all open coded >> variants. > >

Re: [patch 29/37] PCI/MSI: Use __msi_get_virq() in pci_get_vector()

2021-11-28 Thread Marc Zyngier
On Sat, 27 Nov 2021 01:22:03 +, Thomas Gleixner wrote: > > Use __msi_get_vector() and handle the return values to be compatible. > > No functional change intended. You wish ;-). [ 15.779540] pcieport 0001:00:01.0: AER: request AER IRQ -22 failed Notice how amusing the IRQ number is? >

Re: [patch 02/37] device: Add device::msi_data pointer and struct msi_device_data

2021-11-28 Thread Thomas Gleixner
On Sat, Nov 27 2021 at 20:14, Jason Gunthorpe wrote: > On Sat, Nov 27, 2021 at 02:20:09AM +0100, Thomas Gleixner wrote: > >> +/** >> + * msi_setup_device_data - Setup MSI device data >> + * @dev:Device for which MSI device data should be set up >> + * >> + * Return: 0 on success, appropriate

Re: [git pull] IOMMU Fixes for Linux v5.16-rc2

2021-11-28 Thread pr-tracker-bot
The pull request you sent on Sun, 28 Nov 2021 14:32:59 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git > tags/iommu-fixes-v5.16-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0757ca01d944001254a94ac1b25ced702a1e9ac5 Thank you! --

[git pull] IOMMU Fixes for Linux v5.16-rc2

2021-11-28 Thread Joerg Roedel
Hi Linus, The following changes since commit 136057256686de39cc3a07c2e39ef6bc43003ff6: Linux 5.16-rc2 (2021-11-21 13:47:39 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-fixes-v5.16-rc2 for you to fetch changes up to

Re: [PATCH v2 00/17] Fix BUG_ON in vfio_iommu_group_notifier()

2021-11-28 Thread Greg Kroah-Hartman
On Sun, Nov 28, 2021 at 10:50:34AM +0800, Lu Baolu wrote: > The original post and intent of this series is here. > https://lore.kernel.org/linux-iommu/2025020552.2378167-1-baolu...@linux.intel.com/ Please put the intent in the message, dont make us go and dig it up again. thanks, greg k-h

Re: [PATCH v2 04/17] driver core: platform: Add driver dma ownership management

2021-11-28 Thread Greg Kroah-Hartman
On Sun, Nov 28, 2021 at 10:50:38AM +0800, Lu Baolu wrote: > Multiple platform devices may be placed in the same IOMMU group because > they cannot be isolated from each other. These devices must either be > entirely under kernel control or userspace control, never a mixture. This > checks and sets

Re: [PATCH v2 02/17] driver core: Add dma_unconfigure callback in bus_type

2021-11-28 Thread Greg Kroah-Hartman
On Sun, Nov 28, 2021 at 10:50:36AM +0800, Lu Baolu wrote: > The bus_type structure defines dma_configure() callback for bus drivers > to configure DMA on the devices. This adds the paired dma_unconfigure() > callback and calls it during driver unbinding so that bus drivers can do > some cleanup