Re: [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-27 Thread Joerg Roedel
Hi Ohad, On Fri, Jan 27, 2012 at 09:08:44AM +0200, Ohad Ben-Cohen wrote: On Thu, Jan 26, 2012 at 8:40 PM, Joerg Roedel joerg.roe...@amd.com wrote: Implement the attribute itself and add the code for the AMD IOMMU driver. It's somewhat non-intuitive to have the generic attribute code

Re: [PATCH 2/6] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-27 Thread Ohad Ben-Cohen
On Fri, Jan 27, 2012 at 12:26 PM, Joerg Roedel joerg.roe...@amd.com wrote: I fell also uncomfortable with the missing type-safety of this interface. But the alternative is to have dedicated functions for set/get each attribute. Well, it depends on how many attributes we have in the end, but

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-27 Thread Joerg Roedel
On Thu, Jan 26, 2012 at 02:02:26PM -0600, Scott Wood wrote: On 01/26/2012 01:44 PM, Joerg Roedel wrote: Another reason why it must be in the generic struct is the intended generic dma-ops layer on-top. This code can decide on this flag wheter a address needs to be remapped at all. So