[PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*()

2012-06-04 Thread Donald Dutile
Just some cleanup so next patch can keep the info printing the same way throughout the file. Replace printk(KERN_* with pr_*() functions. Signed-off-by: Donald Dutile ddut...@redhat.com --- drivers/iommu/dmar.c | 83 ++-- 1 file changed, 35

Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*()

2012-06-04 Thread Joe Perches
On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote: Replace printk(KERN_* with pr_*() functions. Please add #define pr_fmt(fmt) KBUILD_MODNAME : fmt before any include and remove the embedded PREFIX from each printk diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c []

Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*()

2012-06-04 Thread Don Dutile
On 06/04/2012 06:15 PM, Joe Perches wrote: On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote: Replace printk(KERN_* with pr_*() functions. Please add #define pr_fmt(fmt) KBUILD_MODNAME : fmt before any include and remove the embedded PREFIX from each printk diff --git

Re: [PATCH 2/2] iommu: dmar -- reserve mmio space used by IOMMU

2012-06-04 Thread David Woodhouse
On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote: Intel-iommu initialization doesn't currently reserve the memory used for the IOMMU registers. This can allow the pci resource allocator to assign a device BAR to the same address as the IOMMU registers. This can cause some not so nice

Re: [PATCH 2/2] iommu: dmar -- reserve mmio space used by IOMMU

2012-06-04 Thread Don Dutile
On 06/04/2012 07:23 PM, David Woodhouse wrote: On Mon, 2012-06-04 at 19:09 -0400, Don Dutile wrote: If the BIOS *doesn't* do that, then I believe this should be WARN_TAINT_ONCE(…TAINT_FIRMWARE_WORKAROUND…) like other BIOS problems that we have discovered. well, one could argue it may be