Re: [PATCH 04/11] iommu/arm-smmu: Introduce automatic stream-id-masking

2014-01-22 Thread Andreas Herrmann
On Wed, Jan 22, 2014 at 03:26:22PM +, Will Deacon wrote: > Hi Andreas, > > This patch always requires some extra brain cycles when reviewing! > > On Thu, Jan 16, 2014 at 12:44:16PM +, Andreas Herrmann wrote: > > Try to determine a mask that can be used for all StreamIDs of a master > > de

Re: PROBLEM: do_IRQ: [number] No irq handler for vector (irq -1)

2014-01-22 Thread Anthony DeRobertis
I was looking through those files a bit, and notice there is a iommu_disable_irq_remapping. I added some printk's to it, and it isn't being called when the BIOS workaround is hit. From the code, I gather that it should be disabled at boot, and the disable_irq_remap flag works by just pretendin

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Varun Sethi
> -Original Message- > From: Will Deacon [mailto:will.dea...@arm.com] > Sent: Wednesday, January 22, 2014 9:04 PM > To: Sethi Varun-B16395 > Cc: Andreas Herrmann; iommu@lists.linux-foundation.org; linux-arm- > ker...@lists.infradead.org; Andreas Herrmann > Subject: Re: [PATCH v3 02/11] io

Re: PROBLEM: do_IRQ: [number] No irq handler for vector (irq -1)

2014-01-22 Thread Neil Horman
On Wed, Jan 22, 2014 at 11:29:50AM -0500, Anthony DeRobertis wrote: > On 01/20/2014 07:26 AM, Neil Horman wrote: > >Right, the X58 variant of the chipset should be covered by > >803075dba31c17af110e1d9a915fe7262165b213. And it is, because we still get > >the > >remapping warning when you boot up.

Re: PROBLEM: do_IRQ: [number] No irq handler for vector (irq -1)

2014-01-22 Thread Anthony DeRobertis
On 01/20/2014 07:26 AM, Neil Horman wrote: Right, the X58 variant of the chipset should be covered by 803075dba31c17af110e1d9a915fe7262165b213. And it is, because we still get the remapping warning when you boot up. Whats odd is that you're still seeing the issue, so there must be something els

Re: [PATCH 11/11] arm: dma-mapping: Add support to extend DMA IOMMU mappings

2014-01-22 Thread Will Deacon
On Thu, Jan 16, 2014 at 12:44:23PM +, Andreas Herrmann wrote: > Instead of using just one bitmap to keep track of IO virtual addresses > (handed out for IOMMU use) introduce a list of iova_ranges (each > having its own bitmap). This allows us to extend existing mappings > when running out of io

Re: [PATCH 10/11] arm: dma-mapping: Add additional parameters to arm_iommu_create_mapping

2014-01-22 Thread Will Deacon
On Thu, Jan 16, 2014 at 12:44:22PM +, Andreas Herrmann wrote: > The new parameters are > > dma_addr_t grow_size > > Specifies the size by which the mapping will be extended in > case that no sufficient space is left in the mapping to > handle an iova allocation re

Re: [PATCH 05/11] iommu/arm-smmu: Check for duplicate stream IDs when registering master devices

2014-01-22 Thread Will Deacon
On Thu, Jan 16, 2014 at 12:44:17PM +, Andreas Herrmann wrote: > Cc: Andreas Herrmann > Signed-off-by: Andreas Herrmann > --- > drivers/iommu/arm-smmu.c | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/io

Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Will Deacon
On Wed, Jan 22, 2014 at 01:54:11PM +, Varun Sethi wrote: > > > > Ok, so are you suggesting that we perform the isolation mapping in > > > > arm_smmu_add_device and drop the notifier altogether? > > > I think that should be fine, until we want to delay mapping creation > > > till driver bind tim

Re: [PATCH 04/11] iommu/arm-smmu: Introduce automatic stream-id-masking

2014-01-22 Thread Will Deacon
Hi Andreas, This patch always requires some extra brain cycles when reviewing! On Thu, Jan 16, 2014 at 12:44:16PM +, Andreas Herrmann wrote: > Try to determine a mask that can be used for all StreamIDs of a master > device. This allows to use just one SMR group instead of > number-of-streamid

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Varun Sethi
> -Original Message- > From: Will Deacon [mailto:will.dea...@arm.com] > Sent: Wednesday, January 22, 2014 7:10 PM > To: Sethi Varun-B16395 > Cc: Andreas Herrmann; iommu@lists.linux-foundation.org; linux-arm- > ker...@lists.infradead.org; Andreas Herrmann > Subject: Re: [PATCH v3 02/11] io

Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Will Deacon
On Wed, Jan 22, 2014 at 01:14:13PM +, Varun Sethi wrote: > > On Tue, Jan 21, 2014 at 05:48:02PM +, Varun Sethi wrote: > > > > +static int arm_smmu_group_notifier(struct notifier_block *nb, > > > > + unsigned long action, void *data) { > > > > + struct dev

RE: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Varun Sethi
> -Original Message- > From: Will Deacon [mailto:will.dea...@arm.com] > Sent: Wednesday, January 22, 2014 5:56 PM > To: Sethi Varun-B16395 > Cc: Andreas Herrmann; iommu@lists.linux-foundation.org; linux-arm- > ker...@lists.infradead.org; Andreas Herrmann > Subject: Re: [PATCH v3 02/11] io

Re: [PATCH v3 02/11] iommu/arm-smmu: Introduce iommu_group notifier block

2014-01-22 Thread Will Deacon
Hi Varun, Andreas, On Tue, Jan 21, 2014 at 05:48:02PM +, Varun Sethi wrote: > > +static int arm_smmu_group_notifier(struct notifier_block *nb, > > + unsigned long action, void *data) > > +{ > > + struct device *dev = data; > > + struct dma_iommu_mapping *mapping;

Re: [PATCH 01/11] iommu/arm-smmu: Introduce driver option handling

2014-01-22 Thread Will Deacon
Hi Andreas, Couple of *tiny* comments. On Thu, Jan 16, 2014 at 12:44:13PM +, Andreas Herrmann wrote: > Introduce handling of driver options. Options are set based on DT > information when probing an SMMU device. The first option introduced > is "arm,smmu-isolate-devices". (It will be used in