Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Arnd Bergmann
On Friday 30 May 2014 22:29:13 Hiroshi Doyu wrote: > > IIUC the original problem, "a master with 8 streamIDs" means something > like below, where some devices have multiple IDs but some have a > single. A sinle #address-cells cannot afford those 2 masters at once. > >iommu { >

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Arnd Bergmann
On Friday 30 May 2014 14:31:55 Rob Herring wrote: > On Fri, May 30, 2014 at 2:06 PM, Arnd Bergmann wrote: > > On Friday 30 May 2014 08:16:05 Rob Herring wrote: > >> On Fri, May 23, 2014 at 3:33 PM, Thierry Reding > >> wrote: > >> > From: Thierry Reding > >> > +IOMMU master node: > >> > +

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Rob Herring
On Fri, May 30, 2014 at 2:06 PM, Arnd Bergmann wrote: > On Friday 30 May 2014 08:16:05 Rob Herring wrote: >> On Fri, May 23, 2014 at 3:33 PM, Thierry Reding >> wrote: >> > From: Thierry Reding >> > +IOMMU master node: >> > +== >> > + >> > +Devices that access memory through an IO

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Hiroshi Doyu
Arnd Bergmann writes: >> > +Multiple-master IOMMU: >> > +-- >> > + >> > + iommu { >> > + /* the specifier represents the ID of the master */ >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + }; >> > + >> > +

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Arnd Bergmann
On Friday 30 May 2014 12:27:28 Dave Martin wrote: > On Fri, May 30, 2014 at 08:30:08AM +0100, Thierry Reding wrote: > > On Thu, May 29, 2014 at 09:52:22AM -0600, Stephen Warren wrote: > > > On 05/23/2014 02:36 PM, Thierry Reding wrote: > > > I think this is a mistake. address-cells/size-cells are f

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Arnd Bergmann
On Friday 30 May 2014 08:16:05 Rob Herring wrote: > On Fri, May 23, 2014 at 3:33 PM, Thierry Reding > wrote: > > From: Thierry Reding > > +IOMMU master node: > > +== > > + > > +Devices that access memory through an IOMMU are called masters. A device > > can > > +have multiple mas

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Arnd Bergmann
On Friday 30 May 2014 12:22:32 Dave Martin wrote: > > + > > +Examples: > > += > > + > > +Single-master IOMMU: > > + > > + > > + iommu { > > + #address-cells = <0>; > > + #size-cells = <0>; > > + }; > > + > > + master { > > + iommus = <

Re: [PATCH] iommu: msm: use devm_ioremap_resource to simplify code

2014-05-30 Thread Joerg Roedel
On Tue, May 27, 2014 at 06:18:42PM +0800, Kefeng Wang wrote: > Use devm_ioremap_resource() to make the code simpler, drop unused variable, > redundant return value check, and error-handing code. > > Signed-off-by: Kefeng Wang > --- > drivers/iommu/msm_iommu_dev.c | 38 +++--

Re: [PATCH] remove duplicate checking code

2014-05-30 Thread Joerg Roedel
On Thu, May 29, 2014 at 03:45:47PM +0200, Paul Bolle wrote: > On Mon, 2014-05-26 at 11:39 +0200, Joerg Roedel wrote: > > On Fri, May 16, 2014 at 03:39:40PM +0800, Vaughan Cao wrote: > > > amd_iommu_rlookup_table[devid] != NULL is already guaranteed by > > > check_device > > > called before, it's f

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Rob Herring
On Fri, May 23, 2014 at 3:33 PM, Thierry Reding wrote: > From: Thierry Reding > > This commit introduces a generic device tree binding for IOMMU devices. > Only a very minimal subset is described here, but it is enough to cover > the requirements of both the Exynos System MMU and Tegra SMMU as >

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Dave Martin
On Fri, May 30, 2014 at 08:30:08AM +0100, Thierry Reding wrote: > On Thu, May 29, 2014 at 09:52:22AM -0600, Stephen Warren wrote: > > On 05/23/2014 02:36 PM, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > This commit introduces a generic device tree binding for IOMMU devices. > > >

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Dave Martin
On Fri, May 23, 2014 at 10:36:35PM +0200, Thierry Reding wrote: > From: Thierry Reding > > This commit introduces a generic device tree binding for IOMMU devices. > Only a very minimal subset is described here, but it is enough to cover > the requirements of both the Exynos System MMU and Tegra S

RE: [PATCH v4 13/16] iommu/fsl: Use iommu_group_get_for_dev() for IOMMU groups

2014-05-30 Thread Varun Sethi
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, May 23, 2014 4:39 AM > To: linux-...@vger.kernel.org; iommu@lists.linux-foundation.org > Cc: linux-ker...@vger.kernel.org; aco...@gmail.com; li...@horizon.com; > bhelg...@google.com; Sethi Var

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-05-30 Thread Thierry Reding
On Thu, May 29, 2014 at 09:52:22AM -0600, Stephen Warren wrote: > On 05/23/2014 02:36 PM, Thierry Reding wrote: > > From: Thierry Reding > > > > This commit introduces a generic device tree binding for IOMMU devices. > > Only a very minimal subset is described here, but it is enough to cover > >