Re: [RFC 4/5] vfio: amba: VFIO support for AMBA devices

2014-08-26 Thread Alex Williamson
On Tue, 2014-08-26 at 17:39 +0200, Antonios Motakis wrote: > Hello WIll, > > On Tue, Aug 26, 2014 at 12:50 PM, Will Deacon wrote: > > Hi Antonios, > > > > On Fri, Aug 22, 2014 at 10:01:27AM +0100, Antonios Motakis wrote: > >> Add support for discovering AMBA devices with VFIO and handle them > >>

Re: [RFC 4/5] vfio: amba: VFIO support for AMBA devices

2014-08-26 Thread Antonios Motakis
Hello WIll, On Tue, Aug 26, 2014 at 12:50 PM, Will Deacon wrote: > Hi Antonios, > > On Fri, Aug 22, 2014 at 10:01:27AM +0100, Antonios Motakis wrote: >> Add support for discovering AMBA devices with VFIO and handle them >> similarly to Linux platform devices. > > [...] > >> +static struct amba_id

Re: [PATCH 1/6] iommu/arm-smmu: add support for specifying clocks

2014-08-26 Thread Will Deacon
[adding Mike] On Tue, Aug 19, 2014 at 08:03:09PM +0100, Olav Haugan wrote: > Hi Will, Hi Olav, > On 8/19/2014 5:58 AM, Will Deacon wrote: > > On Wed, Aug 13, 2014 at 01:51:34AM +0100, Mitchel Humpherys wrote: > >> On some platforms with tight power constraints it is polite to only > >> leave you

Re: [PATCH 3/6] iommu/arm-smmu: add support for iova_to_phys through ATS1PR

2014-08-26 Thread Will Deacon
Hi Mitch, On Tue, Aug 19, 2014 at 07:12:41PM +0100, Mitchel Humpherys wrote: > On Tue, Aug 19 2014 at 05:44:32 AM, Will Deacon wrote: > > We don't have writeq for arch/arm/. > > Ah yes looks like this is an MSM-ism that never made it upstream since > it wouldn't be guaranteed to be atomic. I'll

Re: [RFC 4/5] vfio: amba: VFIO support for AMBA devices

2014-08-26 Thread Will Deacon
Hi Antonios, On Fri, Aug 22, 2014 at 10:01:27AM +0100, Antonios Motakis wrote: > Add support for discovering AMBA devices with VFIO and handle them > similarly to Linux platform devices. [...] > +static struct amba_id pl330_ids[] = { > + { 0, 0 }, > +}; > + > +MODULE_DEVICE_TABLE(amba, pl330

Re: [RFC PATCH v2 2/2] iommu/intel: Make use of PCIe requester ID interface

2014-08-26 Thread Andy Burns
Andy Burns wrote: "should also enable motherboards with an onboard ASmedia ASM1083/1085 PCIe-to-PCI bridge to work with VT-d enabled" Are any parts of this in mainline yet? I tried with an elrepo 3.17-rc1 kernel (which presumably includes dma-alias-v4 patches) and the warning from pci_find_u

Re: [PATCH v4 1/1] iommu/arm-smmu: Do not access non-existing S2CR registers

2014-08-26 Thread Will Deacon
Hi Olav, On Sat, Aug 23, 2014 at 01:12:32AM +0100, Olav Haugan wrote: > The number of S2CR registers is not properly set when stream > matching is not supported. Fix this and add check that we do not try to > access outside of the number of S2CR regisrers. Sorry for the bother, but could you base

[PATCH 2/4] iommu/amd: Keep a list of devices in an alias group

2014-08-26 Thread Joerg Roedel
From: Joerg Roedel Some broken devices might use any request-id from the alias group, so we need to set a DTE entry for every device in there. This patch adds creation of those lists. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c | 6 ++ 1 file changed, 6 insertions(+) diff --

[PATCH 1/4] iommu/amd: Move struct iommu_dev_data to amd_iommu.c

2014-08-26 Thread Joerg Roedel
From: Joerg Roedel The struct is only used there, so it doesn't need to be in the header file. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c | 21 + drivers/iommu/amd_iommu_types.h | 21 - 2 files changed, 21 insertions(+), 21 deletions

[PATCH 0/4] AMD IOMMU: Assign/de-assign complete alias groups

2014-08-26 Thread Joerg Roedel
Hi, Here is a patch-set to fix the following issue: When a device is added to an iommu domain, the current amd iommu code will add the device itself and the device it aliases to to the domain. But this alias relation is uni-directional. If, for example, device 03:00.1 aliases to 03:00.0 and is a

[PATCH 3/4] iommu/amd: Attach and detach complete alias group

2014-08-26 Thread Joerg Roedel
From: Joerg Roedel Change tha device attach and detach semantic to apply to all devices in an alias group. This means all devices in an alias group are now attached and detached at the same time. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c | 46 ---

[PATCH 4/4] iommu/amd: Remove device binding reference count

2014-08-26 Thread Joerg Roedel
From: Joerg Roedel This reference count is not used anymore, as all devices in an alias group are now attached and detached together. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_io

Re: [RFC PATCH v2 2/2] iommu/intel: Make use of PCIe requester ID interface

2014-08-26 Thread Andy Burns
Andy Burns wrote: I'm running into an IOMMU crash on CentOS7, it seems this patch series aims to fix the same type of issue Sorry, I thought I was dragging up a 1 month old thread, not a 13 month old thread! Am I correct that this became part of the 13 patch set of 1st May 2014, where I sa

Re: [RFC 1/5] driver core: amba: add device binding path 'driver_override'

2014-08-26 Thread Antonios Motakis
On Mon, Aug 25, 2014 at 10:29 PM, Kim Phillips wrote: > On Fri, 22 Aug 2014 11:01:24 +0200 > Antonios Motakis wrote: > >> As already demonstrated with PCI [1] and the platform bus [2], a >> driver_override property in sysfs can be used to bypass the id matching >> of a device to a AMBA driver. Th

Re: [RFC 0/5] vfio: AMBA devices support

2014-08-26 Thread Antonios Motakis
On Tue, Aug 26, 2014 at 1:56 AM, Kim Phillips wrote: > > On Fri, 22 Aug 2014 11:01:23 +0200 > Antonios Motakis wrote: > > > This patch series depends on the VFIO for PLATFORM devices patch series, > > and implements AMBA device support for VFIO. > > ... > > > drivers/amba/bus.c

Re: [RFC 0/5] vfio: AMBA devices support

2014-08-26 Thread Antonios Motakis
On Tue, Aug 26, 2014 at 1:56 AM, Kim Phillips wrote: > On Fri, 22 Aug 2014 11:01:23 +0200 > Antonios Motakis wrote: > > > This patch series depends on the VFIO for PLATFORM devices patch series, > > and implements AMBA device support for VFIO. > > ... > > > drivers/amba/bus.c

re: [RFC PATCH v2 2/2] iommu/intel: Make use of PCIe requester ID interface

2014-08-26 Thread Andy Burns
I'm running into an IOMMU crash on CentOS7, it seems this patch series aims to fix the same type of issue, any thoughts as to whether it is likely to help in my case? [ 0.451393] IOMMU: Prepare 0-16MiB unity mapping for LPC [ 0.451400] IOMMU: Setting identity map for device :00:1f.0 [0x0 -