Re: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 04:42, Zhang, Yang Z wrote: Personally, I think this feature will be helpful to the legacy device assignment. Agree, vfio is the right solution for future feature enabling. But the old kvm without the good vfio supporting is still used largely today. The user really looking for

RE: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes

2014-11-12 Thread Wu, Feng
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Wednesday, November 12, 2014 5:14 PM To: Zhang, Yang Z; Wu, Feng; Alex Williamson Cc: g...@kernel.org; dw...@infradead.org; j...@8bytes.org; t...@linutronix.de; mi...@redhat.com; h...@zytor.com;

Re: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes

2014-11-12 Thread Paolo Bonzini
On 12/11/2014 10:19, Wu, Feng wrote: You can certainly backport these patches to distros that do not have VFIO. But upstream we should work on VFIO first. VFIO has feature parity with legacy device assignment, and adding a new feature that is not in VFIO would be a bad idea. By the way,

Re: [PATCH v9 03/19] vfio: platform: add the VFIO PLATFORM module to Kconfig

2014-11-12 Thread Antonios Motakis
Hello Hongbo, On Wed, Nov 12, 2014 at 10:52 AM, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 28 October 2014 02:07, Antonios Motakis a.mota...@virtualopensystems.com wrote: Enable building the VFIO PLATFORM driver that allows to use Linux platform devices with VFIO. Signed-off-by:

Re: [PATCH v9 03/19] vfio: platform: add the VFIO PLATFORM module to Kconfig

2014-11-12 Thread Eric Auger
On 10/27/2014 07:07 PM, Antonios Motakis wrote: Enable building the VFIO PLATFORM driver that allows to use Linux platform devices with VFIO. Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com --- drivers/vfio/Kconfig | 1 + drivers/vfio/Makefile | 1 +

RE: [PATCH v9 03/19] vfio: platform: add the VFIO PLATFORM module to Kconfig

2014-11-12 Thread bharat.bhus...@freescale.com
Hi, This is not yet supported on Freescale PowerPC. I am still in process of upstreaming the FSL PAMU specific patches for same. Initial plan is to test with PCIe devices and then with Platform devices. Thanks -Bharat From: kvmarm-boun...@lists.cs.columbia.edu

Re: [PATCH v9 01/19] vfio/platform: initial skeleton of VFIO support for platform devices

2014-11-12 Thread Eric Auger
Hi Antonios, On 10/27/2014 07:07 PM, Antonios Motakis wrote: This patch forms the common skeleton code for platform devices support with VFIO. This will include the core functionality of VFIO_PLATFORM, however binding to the device and discovering the device resources will be done with the

Re: [PATCH v9 06/19] vfio/platform: return info for bound device

2014-11-12 Thread Eric Auger
On 10/27/2014 07:07 PM, Antonios Motakis wrote: A VFIO userspace driver will start by opening the VFIO device that corresponds to an IOMMU group, and will use the ioctl interface to get the basic device info, such as number of memory regions and interrupts, and their properties. This patch

Re: [PATCH v9 07/19] vfio/platform: return info for device memory mapped IO regions

2014-11-12 Thread Eric Auger
On 10/27/2014 07:07 PM, Antonios Motakis wrote: This patch enables the IOCTLs VFIO_DEVICE_GET_REGION_INFO ioctl call, which allows the user to learn about the available MMIO resources of a device. Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com ---

RE: [PATCH v9 03/19] vfio: platform: add the VFIO PLATFORM module to Kconfig

2014-11-12 Thread bharat.bhus...@freescale.com
-Original Message- From: Hongbo Zhang [mailto:hongbo.zh...@linaro.org] Sent: Wednesday, November 12, 2014 4:09 PM To: Bhushan Bharat-R65777 Cc: Antonios Motakis; open list:VFIO DRIVER; will.dea...@arm.com; alex.william...@redhat.com; open list; iommu@lists.linux-foundation.org;

Re: [PATCH] iommu/amd: fix accounting of device_state

2014-11-12 Thread Joerg Roedel
On Mon, Nov 10, 2014 at 12:21:39PM +0200, Oded Gabbay wrote: This patch fixes a bug in the accounting of the device_state. In the current code, the device_state was put (decremented) too many times, which sometimes lead to the driver getting stuck permanently in put_device_state_wait(). That

Re: [PATCH v6 05/12] memory: Add NVIDIA Tegra memory controller support

2014-11-12 Thread Joerg Roedel
On Fri, Nov 07, 2014 at 05:00:56PM +0100, Thierry Reding wrote: drivers/iommu/tegra-smmu.c | 1295 -- drivers/memory/tegra/smmu.c | 716 + This new smmu.c is an IOMMU driver, why do you put it in drivers/memory and not in

Re: [PATCH v9 12/19] vfio/platform: trigger an interrupt via eventfd

2014-11-12 Thread Eric Auger
On 10/31/2014 08:36 PM, Alex Williamson wrote: On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: This patch allows to set an eventfd for a patform device's interrupt, platform device (typo) and also to trigger the interrupt eventfd from userspace for testing. Level sensitive

Re: [PATCH v6 05/12] memory: Add NVIDIA Tegra memory controller support

2014-11-12 Thread Thierry Reding
On Wed, Nov 12, 2014 at 03:21:50PM +0100, Joerg Roedel wrote: On Fri, Nov 07, 2014 at 05:00:56PM +0100, Thierry Reding wrote: drivers/iommu/tegra-smmu.c | 1295 -- drivers/memory/tegra/smmu.c | 716 + This new

Re: [PATCH v6 05/12] memory: Add NVIDIA Tegra memory controller support

2014-11-12 Thread Joerg Roedel
On Wed, Nov 12, 2014 at 03:47:16PM +0100, Thierry Reding wrote: The SMMU is part of a larger IP block that's also a memory controller. Having it in drivers/iommu would mean that we need to provide a mechanism to synchronize between the two drivers. They also share a number of data tables, so

Re: [PATCH v9 13/19] vfio/platform: support for level sensitive interrupts

2014-11-12 Thread Eric Auger
On 10/31/2014 08:36 PM, Alex Williamson wrote: On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: Level sensitive interrupts are exposed as maskable and automasked interrupts and are masked and disabled automatically when they fire. Signed-off-by: Antonios Motakis

Re: [PATCH v9 13/19] vfio/platform: support for level sensitive interrupts

2014-11-12 Thread Eric Auger
On 10/31/2014 08:36 PM, Alex Williamson wrote: On Mon, 2014-10-27 at 19:07 +0100, Antonios Motakis wrote: Level sensitive interrupts are exposed as maskable and automasked interrupts and are masked and disabled automatically when they fire. Signed-off-by: Antonios Motakis

Re: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes

2014-11-12 Thread Alex Williamson
On Wed, 2014-11-12 at 10:14 +0100, Paolo Bonzini wrote: On 12/11/2014 04:42, Zhang, Yang Z wrote: Personally, I think this feature will be helpful to the legacy device assignment. Agree, vfio is the right solution for future feature enabling. But the old kvm without the good vfio

Re: [PATCH v9 01/19] vfio/platform: initial skeleton of VFIO support for platform devices

2014-11-12 Thread Alex Williamson
On Wed, 2014-11-12 at 11:05 +0100, Eric Auger wrote: Hi Antonios, On 10/27/2014 07:07 PM, Antonios Motakis wrote: This patch forms the common skeleton code for platform devices support with VFIO. This will include the core functionality of VFIO_PLATFORM, however binding to the device and

Re: [PATCH 5/6] iommu/arm-smmu: support buggy implementations with invalidate-on-map

2014-11-12 Thread Will Deacon
Hi Mitch, On Wed, Aug 13, 2014 at 01:51:38AM +0100, Mitchel Humpherys wrote: Add a workaround for some buggy hardware that requires a TLB invalidate operation to occur at map time. Activate the feature with the qcom,smmu-invalidate-on-map boolean DT property. I'm digging up an old thread

[RFC][PATCH] iommu/arm-smmu: Huge page mapping support for ARM SMMU driver.

2014-11-12 Thread Varun Sethi
This patch adds huge page mapping support for the ARM SMMU Driver. Patch allows creation of 1G and 2MB page mappings. It's also possible to create contiguous huge page mappings. The loop in PMD/PUD intialization code has been removed, considering that iommu_map would work on page size granularity

Re: [PATCH 5/6] iommu/arm-smmu: support buggy implementations with invalidate-on-map

2014-11-12 Thread Mitchel Humpherys
On Wed, Nov 12 2014 at 10:26:43 AM, Will Deacon will.dea...@arm.com wrote: Hi Mitch, On Wed, Aug 13, 2014 at 01:51:38AM +0100, Mitchel Humpherys wrote: Add a workaround for some buggy hardware that requires a TLB invalidate operation to occur at map time. Activate the feature with the

RE: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes

2014-11-12 Thread Zhang, Yang Z
Wu, Feng wrote on 2014-11-13: kvm-ow...@vger.kernel.org wrote on 2014-11-12: k...@vger.kernel.org; iommu@lists.linux-foundation.org; linux-ker...@vger.kernel.org Subject: Re: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes On 12/11/2014 10:19,

RE: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes

2014-11-12 Thread Wu, Feng
-Original Message- From: Zhang, Yang Z Sent: Thursday, November 13, 2014 9:21 AM To: Wu, Feng; Paolo Bonzini; Alex Williamson Cc: g...@kernel.org; dw...@infradead.org; j...@8bytes.org; t...@linutronix.de; mi...@redhat.com; h...@zytor.com; x...@kernel.org; k...@vger.kernel.org;

RE: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes

2014-11-12 Thread Zhang, Yang Z
Wu, Feng wrote on 2014-11-13: Zhang, Yang Z wrote on 2014-11-13: k...@vger.kernel.org; iommu@lists.linux-foundation.org; linux-ker...@vger.kernel.org Subject: RE: [PATCH 05/13] KVM: Update IRTE according to guest interrupt configuration changes Wu, Feng wrote on 2014-11-13: