Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-09 Thread Yingjoe Chen
On Mon, 2015-03-09 at 22:56 +0100, Arnd Bergmann wrote: > On Monday 09 March 2015 11:26:52 Yingjoe Chen wrote: > > On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: > > > From: Yong Wu > > > > > > This patch add SMI(Smart Multimedia Interface) driver. This driver is > > > respons

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-09 Thread Yingjoe Chen
On Mon, 2015-03-09 at 18:59 +0100, Paul Bolle wrote: > Hi Yong, > > Yong Wu schreef op ma 09-03-2015 om 19:57 [+0800]: > > On Fri, 2015-03-06 at 12:30 +0100, Paul Bolle wrote: > > > On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: > > > > --- a/drivers/soc/mediatek/Kconfig > > > > ++

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Tomasz Figa
On Tue, Mar 10, 2015 at 12:41 PM, Yingjoe Chen wrote: > On Tue, 2015-03-10 at 02:00 +0900, Tomasz Figa wrote: >> On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen >> wrote: >> > On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote: >> > <...> >> >> > +/* >> >> > + * pimudev is a global var for dma_a

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Yingjoe Chen
On Tue, 2015-03-10 at 02:00 +0900, Tomasz Figa wrote: > On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen > wrote: > > On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote: > > <...> > >> > +/* > >> > + * pimudev is a global var for dma_alloc_coherent. > >> > + * It is not accepatable, we will delete

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-09 Thread Arnd Bergmann
On Monday 09 March 2015 11:26:52 Yingjoe Chen wrote: > On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: > > From: Yong Wu > > > > This patch add SMI(Smart Multimedia Interface) driver. This driver is > > responsible to enable/disable iommu and control the clocks of each > > loca

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-09 Thread Arnd Bergmann
On Monday 09 March 2015 18:59:37 Paul Bolle wrote: > Hi Yong, > > Yong Wu schreef op ma 09-03-2015 om 19:57 [+0800]: > > On Fri, 2015-03-06 at 12:30 +0100, Paul Bolle wrote: > > > On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: > > > > --- a/drivers/soc/mediatek/Kconfig > > > > +++

Re: [PATCH] iommu: arm-smmu: set a more appropriate DMA mask

2015-03-09 Thread Arnd Bergmann
On Thursday 05 March 2015 18:56:36 Robin Murphy wrote: > @@ -1630,6 +1630,13 @@ static int arm_smmu_device_cfg_probe(struct > arm_smmu_device *smmu) > size = arm_smmu_id_size_to_bits((id >> ID2_OAS_SHIFT) & ID2_OAS_MASK); > smmu->pa_size = size; > > + /* > +* What t

Re: [RFC PATCH v2 2/3] arm64: add IOMMU dma_ops

2015-03-09 Thread Robin Murphy
Hi Russell, On 09/03/15 17:59, Russell King - ARM Linux wrote: [...] For a noncoherent device, dma_map_single() will end up calling __dma_map_area() with the page offset and size of the original request, so the updated part gets flushed by VA, and the rest of the page isn't touched if it doesn'

Re: [RFC PATCH v2 2/3] arm64: add IOMMU dma_ops

2015-03-09 Thread Russell King - ARM Linux
On Thu, Mar 05, 2015 at 11:16:28AM +, Robin Murphy wrote: > Hi Laura, > > On 05/03/15 00:19, Laura Abbott wrote: > [...] > >>Consider that the IOMMU's page table walker is a DMA master in its own > >right, and that is the device you're mapping the page tables for. > >Therefore your IOMMU drive

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-09 Thread Paul Bolle
Hi Yong, Yong Wu schreef op ma 09-03-2015 om 19:57 [+0800]: > On Fri, 2015-03-06 at 12:30 +0100, Paul Bolle wrote: > > On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: > > > --- a/drivers/soc/mediatek/Kconfig > > > +++ b/drivers/soc/mediatek/Kconfig > > > @@ -20,3 +20,10 @@ config MT

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Mitchel Humpherys
On Mon, Mar 09 2015 at 05:16:26 AM, Yong Wu wrote: > Dear Mitchel, > Thanks very much for your review. > > On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote: >> On Fri, Mar 06 2015 at 02:48:17 AM, wrote: >> > From: Yong Wu >> > >> > This patch adds support for mediatek m4u (MultiMe

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Tomasz Figa
On Mon, Mar 9, 2015 at 11:46 PM, Yingjoe Chen wrote: > On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote: > <...> >> > +/* >> > + * pimudev is a global var for dma_alloc_coherent. >> > + * It is not accepatable, we will delete it if "domain_alloc" is enabled >> > + */ >> > +static struct device

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Yingjoe Chen
On Mon, 2015-03-09 at 20:11 +0900, Tomasz Figa wrote: <...> > > +/* > > + * pimudev is a global var for dma_alloc_coherent. > > + * It is not accepatable, we will delete it if "domain_alloc" is enabled > > + */ > > +static struct device *pimudev; > > This is indeed not acceptable. Could you replac

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-03-09 Thread Yong Wu
Dear Mark, Thanks very much for you suggestion. On Fri, 2015-03-06 at 11:13 +, Mark Rutland wrote: > On Fri, Mar 06, 2015 at 10:48:18AM +, yong...@mediatek.com wrote: > > From: Yong Wu > > > > This patch add smi binding document. > > Please move binding documents to the start of t

Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding

2015-03-09 Thread Yong Wu
Dear Sergei, Thanks very much for suggestion. I will fix them in the next version. On Fri, 2015-03-06 at 17:48 +0300, Sergei Shtylyov wrote: > Hello. > > On 3/6/2015 1:48 PM, yong...@mediatek.com wrote: > > > From: Yong Wu > > > This patch add smi binding document. > > > Signe

Re: [PATCH 5/5] dts: mt8173: Add iommu/smi nodes for mt8173

2015-03-09 Thread Yong Wu
Dear Daniel, Thanks very much. I will fix this in next version. On Sat, 2015-03-07 at 23:20 +0800, Daniel Kurtz wrote: > Hi Yong, > > On Fri, Mar 6, 2015 at 6:48 PM, wrote: > > From: Yong Wu > > > > This patch add the iommu/larbs nodes for mt8173 > > > > Signed-off-by: Yong Wu > > --- >

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Yong Wu
Dear Mitchel, Thanks very much for your review. On Fri, 2015-03-06 at 09:15 -0800, Mitchel Humpherys wrote: > On Fri, Mar 06 2015 at 02:48:17 AM, wrote: > > From: Yong Wu > > > > This patch adds support for mediatek m4u (MultiMedia Memory Management > > Unit). > > Currently this only suppo

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Yong Wu
Dear Will, On Fri, 2015-03-06 at 10:58 +, Will Deacon wrote: > On Fri, Mar 06, 2015 at 10:48:17AM +, yong...@mediatek.com wrote: > > From: Yong Wu > > > > This patch adds support for mediatek m4u (MultiMedia Memory Management > > Unit). > > Currently this only supports m4u gen 2 with 2

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-09 Thread Yong Wu
Dear Paul, Thanks very much for your suggestion. On Fri, 2015-03-06 at 12:30 +0100, Paul Bolle wrote: > On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: > > --- a/drivers/soc/mediatek/Kconfig > > +++ b/drivers/soc/mediatek/Kconfig > > @@ -20,3 +20,10 @@ config MT8173_PMIC_WRAP

Re: [PATCH 4/5] dt-bindings: iommu: Add binding for mediatek IOMMU

2015-03-09 Thread Yong Wu
Dear Mark, Thanks very much for your review. I will fix them in the next verion. On Fri, 2015-03-06 at 11:21 +, Mark Rutland wrote: > On Fri, Mar 06, 2015 at 10:48:19AM +, yong...@mediatek.com wrote: > > From: Yong Wu > > > > This patch add mediatek iommu dts binding document.

Re: [PATCH 2/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-03-09 Thread Tomasz Figa
Hi, You can find part 2 of my comments inline. On Fri, Mar 6, 2015 at 7:48 PM, wrote: [snip] > +static irqreturn_t mtk_iommu_isr(int irq, void *dev_id) > +{ > + struct iommu_domain *domain = dev_id; > + struct mtk_iommu_domain *mtkdomain = domain->priv; > + struct mtk_iommu_

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-09 Thread Daniel Kurtz
Hi Yong, On Fri, Mar 6, 2015 at 6:37 PM, wrote: > From: Yong Wu > > This patch add SMI(Smart Multimedia Interface) driver. This driver > is responsible to enable/disable iommu and control the clocks of each > local arbiter. High-level: Is there more to the smi (or smi-larb) driver, or is i