Re: [PATCH] PCI: Don't use SR-IOV lock for ATS

Hi Joerg, On Thu, Jun 18, 2015 at 10:50:20AM +0200, Joerg Roedel wrote: > From: Joerg Roedel > > The use of the SR-IOV lock for ATS causes a dead-lock in the > AMD-IOMMU driver when virtual functions are added that have > an ATS capability. > > The problem is that the VFs will be added to the b

[PATCH v4 4/4] arm64: Hook up IOMMU dma_ops

With iommu_dma_ops in place, hook them up to the configuration code, so IOMMU-fronted devices will get them automatically. Signed-off-by: Robin Murphy --- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/dma-mapping.h | 15 +++ arch/arm64/mm/dma-mapping.c

[PATCH v4 2/4] iommu: Implement common IOMMU ops for DMA mapping

Taking inspiration from the existing arch/arm code, break out some generic functions to interface the DMA-API to the IOMMU-API. This will do the bulk of the heavy lifting for IOMMU-backed dma-mapping. Signed-off-by: Robin Murphy --- drivers/iommu/Kconfig | 7 + drivers/iommu/Makefile|

[PATCH v4 1/4] iommu/iova: Avoid over-allocating when size-aligned

Currently, allocating a size-aligned IOVA region quietly adjusts the actual allocation size in the process, returning a rounded-up power-of-two-sized allocation. This results in mismatched behaviour in the IOMMU driver if the original size was not a power of two, where the original size is mapped,

[PATCH v4 3/4] arm64: Add IOMMU dma_ops

Taking some inspiration from the arch/arm code, implement the arch-specific side of the DMA mapping ops using the new IOMMU-DMA layer. Unfortunately the device setup code has to start out as a big ugly mess in order to work usefully right now, as 'proper' operation depends on changes to device pro

[PATCH v4 0/4] arm64: IOMMU-backed DMA mapping

Hi all, Here's a quick repost to address feedback on v3, and a couple of other tweaks. Changes this round: - Fix the heinous dma_mask/coherency confusion, which also simplifies some prototypes and parameter passing as a bonus. - Reorder the iommu_map/unmap in alloc/free to prevent any potential

Re: [PATCH] iommu/vt-d: Fix VM domain ID leak

On Thu, Jul 16, 2015 at 09:43:55AM -0600, Alex Williamson wrote: > I was tempted to do this as well, but what about > domain_remove_dev_info() where we also handle vm domains specially and > don't do a symmetric detach in both directions? I started down that > path but quickly found the code to fr

Re: [PATCH] iommu/vt-d: Fix VM domain ID leak

On Thu, 2015-07-16 at 17:20 +0200, Joerg Roedel wrote: > On Tue, Jul 14, 2015 at 02:48:53PM -0600, Alex Williamson wrote: > > This continues the attempt to fix commit fb170fb4c548 ("iommu/vt-d: > > Introduce helper functions to make code symmetric for readability"). > > The previous attempt in comm

Re: [PATCH] iommu/vt-d: Fix VM domain ID leak

On Tue, Jul 14, 2015 at 02:48:53PM -0600, Alex Williamson wrote: > This continues the attempt to fix commit fb170fb4c548 ("iommu/vt-d: > Introduce helper functions to make code symmetric for readability"). > The previous attempt in commit 71684406905f ("iommu/vt-d: Detach > domain *only* from attac

Re: Master-aware devices and sideband ID data

Hi Will, The below is an attempt at an MSI binding, derived from my original example. It extends msi-parent inoto a phandle+(optional args) style property. I haven't yet managed to come up with a sane way of describing the Bus-ID/BDF -> {iommu,msi}-cells translation, but this should hopefully cov

Re: [PATCH 1/2] of: base: Allow more args than MAX_PHANDLE_ARGS if required

Hi Will, On Thu, Jul 16, 2015 at 11:23:26AM +0100, Will Deacon wrote: > On Thu, Jul 16, 2015 at 09:30:43AM +0100, Joerg Roedel wrote: > > +struct of_phandle_args *of_alloc_phandle_args(int size) > > +{ > > + struct of_phandle_args *args; > > + int e = max(0, size - MAX_PHANDLE_ARGS); > > + > >

Re: [PATCH 1/2] of: base: Allow more args than MAX_PHANDLE_ARGS if required

On Thu, Jul 16, 2015 at 09:30:43AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > The main use of MAX_PHANDLE_ARGS is to define the number of > args elements in 'struct of_phandle_args'. This struct is > often declared on the stack and thus it is impractical to > increase MAX_PHANDLE_ARGS ag

Re: [PATCH 2/2] arm/smmu: Make use of of_parse_phandle_with_var_args

Hi Joerg, On Thu, Jul 16, 2015 at 09:30:44AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > The function of_parse_phandle_with_args() can only handle 16 > args, but there are systems that require more (25 in my > case). So use the newly introduced function > of_parse_phandle_with_var_args()

[PATCH v3 3/6] iommu: add ARM short descriptor page table allocator.

This patch is for ARM Short Descriptor Format. Signed-off-by: Yong Wu --- drivers/iommu/Kconfig| 18 + drivers/iommu/Makefile |1 + drivers/iommu/io-pgtable-arm-short.c | 742 ++ drivers/iommu/io-pgtable-arm.c |3 - d

[PATCH v3 6/6] dts: mt8173: Add iommu/smi nodes for mt8173

This patch add the iommu/larbs nodes for mt8173 Signed-off-by: Yong Wu --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 81 ++ 1 file changed, 81 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index e81

[PATCH v3 0/6] MT8173 IOMMU SUPPORT

This patch adds support for m4u(Multimedia Memory Management Unit), Currently it only support the m4u with 2 levels of pagetable on mt8173. It is based on Robin Murphy's arm64 DMA v3: IOMMU-backed DMA mapping[1]. Please check the hardware block diagram of Mediatek IOMMU. EMI

[PATCH v3 2/6] dt-bindings: mediatek: Add smi dts binding

This patch add smi binding document. Signed-off-by: Yong Wu --- .../memory-controllers/mediatek,smi-larb.txt | 25 .../bindings/memory-controllers/mediatek,smi.txt | 24 +++ 2 files changed, 49 insertions(+) create mode 100644 Documentation/devi

[PATCH v3 1/6] dt-bindings: iommu: Add binding for mediatek IOMMU

This patch add mediatek iommu dts binding document. Signed-off-by: Yong Wu --- .../devicetree/bindings/iommu/mediatek,iommu.txt | 61 include/dt-bindings/memory/mt8173-larb-port.h | 105 2 files changed, 166 insertions(+) create mode 100644 Documentat

[PATCH v3 4/6] memory: mediatek: Add SMI driver

This patch add SMI(Smart Multimedia Interface) driver. This driver is responsible to enable/disable iommu and control the clocks of each local arbiter Signed-off-by: Yong Wu --- drivers/memory/Kconfig |8 ++ drivers/memory/Makefile|1 + drivers/memory/mtk-smi.c | 285 +

[PATCH v3 5/6] iommu/mediatek: Add mt8173 IOMMU driver

This patch adds support for mediatek m4u (MultiMedia Memory Management Unit). Signed-off-by: Yong Wu --- drivers/iommu/Kconfig | 13 + drivers/iommu/Makefile|1 + drivers/iommu/mtk_iommu.c | 724 + 3 files changed, 738 insertions(+) cre

[PATCH 2/2] arm/smmu: Make use of of_parse_phandle_with_var_args

From: Joerg Roedel The function of_parse_phandle_with_args() can only handle 16 args, but there are systems that require more (25 in my case). So use the newly introduced function of_parse_phandle_with_var_args() instead. Signed-off-by: Joerg Roedel --- drivers/iommu/arm-smmu.c | 23 ++

[PATCH 0/2 v2] Fix MAX_PHANDLE_ARGS limitations

From: Joerg Roedel Hi, here is the second version of my patches to fix the MAX_PHANDLE_ARGS limitation for the arm-smmu driver. On my AMD Seattle system the max value of 16 is not enough to initialize the SMMU, as the device tree node has an entry with 25 phandle args (possible are up to 128). T

[PATCH 1/2] of: base: Allow more args than MAX_PHANDLE_ARGS if required

From: Joerg Roedel The main use of MAX_PHANDLE_ARGS is to define the number of args elements in 'struct of_phandle_args'. This struct is often declared on the stack and thus it is impractical to increase MAX_PHANDLE_ARGS again and again. To handle situations where more than MAX_PHANDLE_ARGS elem