[PATCH 1/2] firmware/qcom: add qcom_scm_restore_sec_cfg()

2017-02-10 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/firmware/qcom_scm-32.c | 6 ++ drivers/firmware/qcom_scm-64.c | 16 drivers/firmware/qcom_scm.c| 6 ++ drivers/firmware/qcom_scm.h| 5 + include/linux/qcom_scm.h | 2 ++ 5 files changed, 35

[RFC 2/2] iommu/arm-smmu: support qcom implementation

2017-02-10 Thread Rob Clark
For devices with iommu(s) in secure mode, we cannot touch global registers, and we have to live with the context -> sid mapping that the secure world has set up for us. This enables, for example db410c (apq8016) devices to use the up- stream arm-smmu driver. This is the last major hurdle for

Re: [PATCH 07/11] iommu/arm-smmu: Make use of the iommu_register interface

2017-02-10 Thread Robin Murphy
On 10/02/17 15:25, Joerg Roedel wrote: > On Fri, Feb 10, 2017 at 02:20:34PM +, Robin Murphy wrote: >>> @@ -1795,8 +1798,10 @@ static int arm_smmu_add_device(struct device *dev) >>> } >>> >>> group = iommu_group_get_for_dev(dev); >>> - if (!IS_ERR(group)) >>> + if (!IS_ERR(group))

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Robin Murphy
On 10/02/17 16:11, Joerg Roedel wrote: > On Fri, Feb 10, 2017 at 04:03:07PM +, Robin Murphy wrote: >> Yeah, on reflection explicit initialisation is certainly easier to read >> than a bunch of arguments handled implicitly by register(), but then >> from that angle, even more clear would be to

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Joerg Roedel
On Fri, Feb 10, 2017 at 04:03:07PM +, Robin Murphy wrote: > Yeah, on reflection explicit initialisation is certainly easier to read > than a bunch of arguments handled implicitly by register(), but then > from that angle, even more clear would be to simply have the drivers > write the relevant

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Robin Murphy
On 10/02/17 15:22, Joerg Roedel wrote: > Hi Robin, > > On Fri, Feb 10, 2017 at 02:16:54PM +, Robin Murphy wrote: >>> +static inline void iommu_device_set_fwnode(struct iommu_device *iommu, >>> + struct fwnode_handle *fwnode) >>> +{ >>> + iommu->fwnode =

Re: [PATCH 01/11] iommu: Rename iommu_get_instance()

2017-02-10 Thread Joerg Roedel
Hi Robin, On Fri, Feb 10, 2017 at 02:12:54PM +, Robin Murphy wrote: > I'm really liking this series! Superficially it doesn't seem to break > anything on my Juno, but I'll give it a more thorough workout soon. Great, thanks for testing! Any problems in this series should show up on boot

Re: [PATCH 08/11] iommu/msm: Make use of iommu_device_register interface

2017-02-10 Thread Joerg Roedel
On Fri, Feb 10, 2017 at 02:35:39PM +, Robin Murphy wrote: > On 09/02/17 11:32, Joerg Roedel wrote: > > + ret = iommu_device_sysfs_add(>iommu, iommu->dev, NULL, > > +"msm-smmu.%pa", ); > > + if (ret) { > > + pr_err("Could not add msm-smmu at %pa to

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Joerg Roedel
Hi Robin, On Fri, Feb 10, 2017 at 02:16:54PM +, Robin Murphy wrote: > > +static inline void iommu_device_set_fwnode(struct iommu_device *iommu, > > + struct fwnode_handle *fwnode) > > +{ > > + iommu->fwnode = fwnode; > > +} > > Would it make sense to

Re: [PATCH 08/11] iommu/msm: Make use of iommu_device_register interface

2017-02-10 Thread Robin Murphy
On 09/02/17 11:32, Joerg Roedel wrote: > From: Joerg Roedel > > Register the MSM IOMMUs to the iommu core and add sysfs > entries for that driver. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/msm_iommu.c | 73 >

Re: [PATCH 01/11] iommu: Rename iommu_get_instance()

2017-02-10 Thread Robin Murphy
Hi Joerg, I'm really liking this series! Superficially it doesn't seem to break anything on my Juno, but I'll give it a more thorough workout soon. Just a few comments from skimming through... On 09/02/17 11:32, Joerg Roedel wrote: > From: Joerg Roedel > > Rename the function

Re: [PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

2017-02-10 Thread Joerg Roedel
On Fri, Feb 10, 2017 at 02:46:59PM +0100, Marek Szyprowski wrote: > Hi > > On 2017-02-09 12:32, Joerg Roedel wrote: > >From: Joerg Roedel > > > >Register Exynos IOMMUs to the IOMMU core and make them > >visible in sysfs. This patch does not add the links between > >IOMMUs and

Re: [PATCH 10/11] iommu/exynos: Make use of iommu_device_register interface

2017-02-10 Thread Marek Szyprowski
Hi On 2017-02-09 12:32, Joerg Roedel wrote: From: Joerg Roedel Register Exynos IOMMUs to the IOMMU core and make them visible in sysfs. This patch does not add the links between IOMMUs and translated devices yet. Cc: Marek Szyprowski Cc: