Re: [PATCH v2 3/4] iommu/iova: Extend rbtree node caching

2017-07-31 Thread Robin Murphy
Hi Nate, On 29/07/17 04:57, Nate Watterson wrote: > Hi Robin, > I am seeing a crash when performing very basic testing on this series > with a Mellanox CX4 NIC. I dug into the crash a bit, and think this > patch is the culprit, but this rcache business is still mostly > witchcraft to me. > > #

Re: [PATCH v8 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled

2017-07-31 Thread Baoquan He
On 07/31/17 at 12:21pm, Joerg Roedel wrote: > Hi Baoquan, > > On Mon, Jul 31, 2017 at 06:15:30PM +0800, Baoquan He wrote: > > I plan to add GFP_DMA32 when allocate amd_iommu_dev_table in > > early_amd_iommu_init() as below. Then in kdump kernel we don't need to > > worry if the old

Re: [PATCH v8 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled

2017-07-31 Thread Joerg Roedel
Hi Baoquan, On Mon, Jul 31, 2017 at 06:15:30PM +0800, Baoquan He wrote: > I plan to add GFP_DMA32 when allocate amd_iommu_dev_table in > early_amd_iommu_init() as below. Then in kdump kernel we don't need to > worry if the old amd_iommu_dev_table could be above 4G, right? And might > not need to

Re: [PATCH v8 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled

2017-07-31 Thread Baoquan He
Hi Joerg, On 07/28/17 at 05:06pm, Baoquan He wrote: > Hi Joerg, > > On 07/27/17 at 05:55pm, Joerg Roedel wrote: > > On Fri, Jul 21, 2017 at 04:59:08PM +0800, Baoquan He wrote: > > > AMD pointed out it's unsafe to update the device-table while iommu > > > is enabled. It turns out that

Re: [PATCH v8 02/13] iommu/amd: add several helper functions

2017-07-31 Thread Baoquan He
Hi Joerg, On 07/27/17 at 05:06pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:00PM +0800, Baoquan He wrote: > > Move single iommu enabling codes into a wrapper function > > early_enable_iommu(). > > This can make later kdump change easier. > > > > And also add

Re: [PATCH v2 1/3] memory: mtk-smi: add larbid handle routine

2017-07-31 Thread Matthias Brugger
On 07/28/2017 12:55 PM, honghui.zh...@mediatek.com wrote: From: Honghui Zhang In the commit 3c8f4ad85c4b ("memory/mediatek: add support for mt2701"), the larb->larbid was added but not initialized. Mediatek's gen1 smi need this hardware larbid information to get