Re: [RFC PATCH v5 3/8] iommu: add a new capable IOMMU_CAP_MERGING

2019-06-06 Thread Christoph Hellwig
On Fri, Jun 07, 2019 at 05:41:56AM +, Yoshihiro Shimoda wrote: > > bool blk_can_use_iommu_merging(struct request_queue *q, struct device *dev) > > { > > if (!IOMMU_CAN_MERGE_SEGMENTS(dev)) > > return false; > > As Robin mentioned, all IOMMUs can merge segments so that we don't

RE: [RFC PATCH v5 3/8] iommu: add a new capable IOMMU_CAP_MERGING

2019-06-06 Thread Yoshihiro Shimoda
Hi Christoph, > From: Christoph Hellwig, Sent: Thursday, June 6, 2019 4:01 PM > > On Thu, Jun 06, 2019 at 06:28:47AM +, Yoshihiro Shimoda wrote: > > > The problem is that we need a way to communicate to the block layer > > > that more than a single segment is ok IFF the DMA API instance

Device specific pass through in host systems - discuss user interface

2019-06-06 Thread Prakhya, Sai Praneeth
Hi All, I am working on an IOMMU driver feature that allows a user to specify if the DMA from a device should be translated by IOMMU or not. Presently, we support only all devices or none mode i.e. if user specifies "iommu=pt" [X86] or "iommu.passthrough" [ARM64] through kernel command line,

Re: [RFC PATCH v4 17/21] x86/tsc: Switch to perf-based hardlockup detector if TSC become unstable

2019-06-06 Thread Stephane Eranian
Hi Ricardo, Thanks for your contribution here. It is very important to move the watchdog out of the PMU wherever possible. On Thu, May 23, 2019 at 6:17 PM Ricardo Neri wrote: > > The HPET-based hardlockup detector relies on the TSC to determine if an > observed NMI interrupt was originated by

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-06 Thread Jacob Pan
On Thu, 6 Jun 2019 19:54:05 +0100 Jean-Philippe Brucker wrote: > On 05/06/2019 23:45, Jacob Pan wrote: > > On Tue, 4 Jun 2019 18:11:08 +0200 > > Auger Eric wrote: > > > >> Hi Alex, > >> > >> On 6/4/19 12:31 AM, Alex Williamson wrote: > >>> On Sun, 26 May 2019 18:10:01 +0200 > >>> Eric

Re: [PATCH v8 26/29] vfio-pci: Register an iommu fault handler

2019-06-06 Thread Jean-Philippe Brucker
On 05/06/2019 23:45, Jacob Pan wrote: > On Tue, 4 Jun 2019 18:11:08 +0200 > Auger Eric wrote: > >> Hi Alex, >> >> On 6/4/19 12:31 AM, Alex Williamson wrote: >>> On Sun, 26 May 2019 18:10:01 +0200 >>> Eric Auger wrote: >>> This patch registers a fault handler which records faults in

Re: [PATCH -next v2] iommu/amd: fix a null-ptr-deref in map_sg()

2019-06-06 Thread Tom Murphy
Hi Joerg, Is there anything I need to do to get this patch into linux-next? My patch to convert the amd iommu driver to use the dma-iommu ops depends on this patch. Thanks, Tom On Tue, May 7, 2019 at 8:39 AM Joerg Roedel wrote: > > Hi Qian, > > On Mon, May 06, 2019 at 12:44:40PM -0400, Qian

Re: [RFC PATCH v5 3/8] iommu: add a new capable IOMMU_CAP_MERGING

2019-06-06 Thread Christoph Hellwig
On Thu, Jun 06, 2019 at 06:28:47AM +, Yoshihiro Shimoda wrote: > > The problem is that we need a way to communicate to the block layer > > that more than a single segment is ok IFF the DMA API instance supports > > merging. And of course the answer will depend on futher parameters > > like

RE: [PATCH v2 2/4] iommu: Introduce device fault data

2019-06-06 Thread Tian, Kevin
> From: Jacob Pan [mailto:jacob.jun@linux.intel.com] > Sent: Thursday, June 6, 2019 1:38 AM > > On Wed, 5 Jun 2019 08:51:45 + > "Tian, Kevin" wrote: > > > > From: Jacob Pan > > > Sent: Tuesday, June 4, 2019 6:09 AM > > > > > > On Mon, 3 Jun 2019 15:57:47 +0100 > > > Jean-Philippe

Re: [PATCH] iommu/dma: Apply dma_{alloc,free}_contiguous functions

2019-06-06 Thread Christoph Hellwig
Looks fine to me. Robin, any comments? On Mon, Jun 03, 2019 at 03:52:59PM -0700, Nicolin Chen wrote: > This patch replaces dma_{alloc,release}_from_contiguous() with > dma_{alloc,free}_contiguous() to simplify those function calls. > > Signed-off-by: Nicolin Chen > --- >

RE: [RFC PATCH v5 3/8] iommu: add a new capable IOMMU_CAP_MERGING

2019-06-06 Thread Yoshihiro Shimoda
Hi Christoph, Thank you for your comments! > From: Christoph Hellwig, Sent: Wednesday, June 5, 2019 9:38 PM > > On Wed, Jun 05, 2019 at 01:21:59PM +0100, Robin Murphy wrote: > > And if the problem is really that you're not getting merging because of > > exposing the wrong parameters to the DMA