Re: [PATCH 2/7] dt-bindings: arm-smmu: Add Adreno GPU variant

Quoting Jordan Crouse (2019-08-20 12:06:27) > Add a compatible string to identify SMMUs that are attached > to Adreno GPU devices that wish to support split pagetables. > > Signed-off-by: Jordan Crouse > --- > > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 7 +++ > 1 file

Re: [PATCH 3/7] iommu/arm-smmu: Add a SMMU variant for the Adreno GPU

Quoting Jordan Crouse (2019-08-20 12:06:28) > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 39e81ef..3f41cf7 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1858,6 +1858,7 @@ ARM_SMMU_MATCH_DATA(arm_mmu401, ARM_SMMU_V1_64K, >

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

On 9/17/19 1:23 PM, David Rientjes wrote: > On Mon, 16 Sep 2019, David Rientjes wrote: > >> Brijesh and Tom, we currently hit this any time we boot an SEV enabled >> Ubuntu 18.04 guest; I assume that guest kernels, especially those of such >> major distributions, are expected to work with

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

On 9/17/19 12:23 PM, David Rientjes wrote: > On Mon, 16 Sep 2019, David Rientjes wrote: > >> Brijesh and Tom, we currently hit this any time we boot an SEV enabled >> Ubuntu 18.04 guest; I assume that guest kernels, especially those of such >> major distributions, are expected to work with

Re: [bug] __blk_mq_run_hw_queue suspicious rcu usage

On Mon, 16 Sep 2019, David Rientjes wrote: > Brijesh and Tom, we currently hit this any time we boot an SEV enabled > Ubuntu 18.04 guest; I assume that guest kernels, especially those of such > major distributions, are expected to work with warnings and BUGs when > certain drivers are enabled.

Re: [PATCH 2/2] iommu: dma: Use of_iommu_get_resv_regions()

On Mon, Sep 02, 2019 at 04:52:45PM +0200, Thierry Reding wrote: > On Mon, Sep 02, 2019 at 03:22:35PM +0100, Robin Murphy wrote: > > On 29/08/2019 12:14, Thierry Reding wrote: > > > From: Thierry Reding > > > > > > For device tree nodes, use the standard of_iommu_get_resv_regions() > > >

Re: [PATCH 5/7] iommu/arm-smmu: Support DOMAIN_ATTR_SPLIT_TABLES

On Tue, Aug 20, 2019 at 01:06:30PM -0600, Jordan Crouse wrote: > Support the DOMAIN_ATTR_SPLIT_TABLES attribute to let the leaf driver > know if split pagetables are enabled for the domain. > > Signed-off-by: Jordan Crouse > --- > > drivers/iommu/arm-smmu.c | 3 +++ > 1 file changed, 3

[PATCH v2] iommu/arm-smmu: Report USF more clearly

Although CONFIG_ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT is a welcome tool for smoking out inadequate firmware, the failure mode is non-obvious and can be confusing for end users. Add some special-case reporting of Unidentified Stream Faults to help clarify this particular symptom. Since we're adding

Re: [PATCH v3 0/2] improve the concurrency of arm_smmu_atc_inv_domain()

On 2019/8/23 16:06, Leizhen (ThunderTown) wrote: > > > On 2019/8/23 15:50, Will Deacon wrote: >> On Fri, Aug 23, 2019 at 10:45:49AM +0800, Zhen Lei wrote: >>> v2 --> v3: >>> As Will Deacon's suggestion, I changed the lock type of >>> arm_smmu_domain.devices_lock from spinlock_t to rwlock_t,

Re: [PATCH v3 0/2] iommu: handle drivers that manage iommu directly

On Tue, Sep 10, 2019 at 10:10:49AM -0700, Rob Clark wrote: > On Tue, Sep 10, 2019 at 9:34 AM Robin Murphy wrote: > > On 06/09/2019 22:44, Rob Clark wrote: > > > NOTE that in discussion of previous revisions, RMRR came up. This is > > > not really a replacement for RMRR (nor does RMRR really

[PATCH] dma/coherent: remove unused dma_get_device_base()

dma_get_device_base() was first introduced in the commit c41f9ea998f3 ("drivers: dma-coherent: Account dma_pfn_offset when used with device tree"). Later, it was removed by the commit 43fc509c3efb ("dma-coherent: introduce interface for default DMA pool") Found by the -Wunused-function

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

Hi Uwe, On Tue, Sep 17, 2019 at 2:25 PM Uwe Kleine-König wrote: > On Tue, Sep 17, 2019 at 11:25:46AM +, Peter Rosin wrote: > > On 2019-09-17 12:13, Uwe Kleine-König wrote: > > > On Tue, Sep 17, 2019 at 11:40:25AM +0200, Geert Uytterhoeven wrote: > > >> On Fri, Sep 13, 2019 at 11:58 PM Rob

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

Hi Uwe, On 17.09.2019 14:25, Uwe Kleine-König wrote: > On Tue, Sep 17, 2019 at 11:25:46AM +, Peter Rosin wrote: >> On 2019-09-17 12:13, Uwe Kleine-König wrote: >>> Hello Geert, >>> >>> On Tue, Sep 17, 2019 at 11:40:25AM +0200, Geert Uytterhoeven wrote: Hi Rob, Uwe, On Fri, Sep

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

On Tue, Sep 17, 2019 at 11:25:46AM +, Peter Rosin wrote: > On 2019-09-17 12:13, Uwe Kleine-König wrote: > > Hello Geert, > > > > On Tue, Sep 17, 2019 at 11:40:25AM +0200, Geert Uytterhoeven wrote: > >> Hi Rob, Uwe, > >> > >> On Fri, Sep 13, 2019 at 11:58 PM Rob Herring wrote: > >>> On Sat,

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

On 2019-09-17 12:13, Uwe Kleine-König wrote: > Hello Geert, > > On Tue, Sep 17, 2019 at 11:40:25AM +0200, Geert Uytterhoeven wrote: >> Hi Rob, Uwe, >> >> On Fri, Sep 13, 2019 at 11:58 PM Rob Herring wrote: >>> On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= >>>

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

Hello Geert, On Tue, Sep 17, 2019 at 11:40:25AM +0200, Geert Uytterhoeven wrote: > Hi Rob, Uwe, > > On Fri, Sep 13, 2019 at 11:58 PM Rob Herring wrote: > > On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= > > wrote: > > > Referencing device tree nodes from a

[PATCHv6 2/3] firmware/qcom_scm: Add scm call to handle smmu errata

From: Vivek Gautam Qcom's smmu-500 needs to toggle wait-for-safe sequence to handle TLB invalidation sync's. Few firmwares allow doing that through SCM interface. Add API to toggle wait for safe from firmware through a SCM call. Signed-off-by: Vivek Gautam Reviewed-by: Bjorn Andersson

[PATCHv6 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

From: Vivek Gautam Add reset hook for sdm845 based platforms to turn off the wait-for-safe sequence. Understanding how wait-for-safe logic affects USB and UFS performance on MTP845 and DB845 boards: Qcom's implementation of arm,mmu-500 adds a WAIT-FOR-SAFE logic to address under-performance

[PATCHv6 1/3] firmware: qcom_scm-64: Add atomic version of qcom_scm_call

From: Vivek Gautam There are scnenarios where drivers are required to make a scm call in atomic context, such as in one of the qcom's arm-smmu-500 errata [1]. [1] ("https://source.codeaurora.org/quic/la/kernel/msm-4.9/ tree/drivers/iommu/arm-smmu.c?h=msm-4.9#n4842") Signed-off-by: Vivek

[PATCHv6 0/3] QCOM smmu-500 wait-for-safe handling for sdm845

Previous version of the patches are at [1]: QCOM's implementation of smmu-500 on sdm845 adds a hardware logic called wait-for-safe. This logic helps in meeting the invalidation requirements from 'real-time clients', such as display and camera. This wait-for-safe logic ensures that the

Re: [PATCH v1 2/2] of: Let of_for_each_phandle fallback to non-negative cell_count

Hi Rob, Uwe, On Fri, Sep 13, 2019 at 11:58 PM Rob Herring wrote: > On Sat, 24 Aug 2019 15:28:46 +0200, =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= >wrote: > > Referencing device tree nodes from a property allows to pass arguments. > > This is for example used for referencing gpios. This looks

Re: [PATCH] iommu/qcom: Simplify a test in 'qcom_iommu_add_device()'

On Mon, Sep 16, 2019 at 10:29:36PM +0200, Christophe JAILLET wrote: > 'iommu_group_get_for_dev()' never returns NULL, so this test can be > simplified a bit. > It used to until commit 72dcac633475 ("iommu: Warn once when device_group callback returns NULL"). Reviewed-by: Dan Carpenter