Re: [PATCHv7 3/3] iommu: arm-smmu-impl: Add sdm845 implementation hook

2019-10-04 Thread Bjorn Andersson
On Fri 20 Sep 01:04 PDT 2019, Sai Prakash Ranjan wrote: > From: Vivek Gautam > > Add reset hook for sdm845 based platforms to turn off > the wait-for-safe sequence. > > Understanding how wait-for-safe logic affects USB and UFS performance > on MTP845 and DB845 boards: > > Qcom's

Re: [PATCH v4 0/7] Add support for QCOM IOMMU v2 and 500

2019-10-04 Thread Bjorn Andersson
On Tue 01 Oct 15:01 PDT 2019, khol...@gmail.com wrote: > From: AngeloGioacchino Del Regno > > Some Qualcomm Family-B SoCs have got a different version of the QCOM > IOMMU, specifically v2 and 500, which perfectly adhere to the current > qcom_iommu driver, but need some variations due to

Re: [PATCH v2] iommu/arm-smmu: Break insecure users by disabling bypass by default

2019-10-04 Thread Robin Murphy
On 2019-10-04 9:37 pm, Tim Harvey wrote: On Fri, Oct 4, 2019 at 11:34 AM Robin Murphy wrote: On 04/10/2019 18:13, Tim Harvey wrote: [...] No difference... still need 'arm-smmu.disable_bypass=n' to boot. Are all four iommu-map props above supposed to be the same? Seems to me they all point to

Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-04 Thread Florian Fainelli
On 10/4/19 2:28 PM, Kees Cook wrote: > As we've seen from USB and other areas, we need to always do runtime > checks for DMA operating on memory regions that might be remapped. This > moves the existing checks from USB into dma_map_single(), but leaves > the slightly heavier checks as they are. >

[PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()

2019-10-04 Thread Kees Cook
As we've seen from USB and other areas, we need to always do runtime checks for DMA operating on memory regions that might be remapped. This moves the existing checks from USB into dma_map_single(), but leaves the slightly heavier checks as they are. Suggested-by: Laura Abbott Signed-off-by:

[PATCH] iommu/intel: Use fallback generic_device_group() for ACPI devices

2019-10-04 Thread Chris Wilson
[2.073922] DMAR: ACPI device "INT33C2:00" under DMAR at fed91000 as 00:15.1 [2.073983] DMAR: ACPI device "INT33C3:00" under DMAR at fed91000 as 00:15.2 [2.074027] DMAR: ACPI device "INT33C0:00" under DMAR at fed91000 as 00:15.3 [2.074072] DMAR: ACPI device "INT33C1:00" under DMAR

Re: [PATCH v2] iommu/arm-smmu: Break insecure users by disabling bypass by default

2019-10-04 Thread Tim Harvey
On Fri, Oct 4, 2019 at 11:34 AM Robin Murphy wrote: > > On 04/10/2019 18:13, Tim Harvey wrote: > [...] > >>> No difference... still need 'arm-smmu.disable_bypass=n' to boot. Are > >>> all four iommu-map props above supposed to be the same? Seems to me > >>> they all point to the same thing which

Re: [PATCH] dma-mapping: Lift address space checks out of debug code

2019-10-04 Thread Kees Cook
On Fri, Oct 04, 2019 at 07:50:54PM +0100, Robin Murphy wrote: > On 03/10/2019 22:38, Kees Cook wrote: > > What do you think about the object_is_on_stack() check? That does a > > dereference through "current" to find the stack bounds... > > I guess it depends what the aim is - is it just to bail

Re: [PATCH] dma-mapping: Lift address space checks out of debug code

2019-10-04 Thread Robin Murphy
On 03/10/2019 22:38, Kees Cook wrote: On Thu, Oct 03, 2019 at 10:42:45AM +0100, Robin Murphy wrote: On 03/10/2019 00:58, Kees Cook wrote: On Wed, Oct 02, 2019 at 10:15:43PM +0100, Robin Murphy wrote: Hi Kees, On 2019-10-02 9:46 pm, Kees Cook wrote: As we've seen from USB and other areas, we

Re: [PATCH v2] iommu/arm-smmu: Break insecure users by disabling bypass by default

2019-10-04 Thread Robin Murphy
On 04/10/2019 18:13, Tim Harvey wrote: [...] No difference... still need 'arm-smmu.disable_bypass=n' to boot. Are all four iommu-map props above supposed to be the same? Seems to me they all point to the same thing which looks wrong. Hmm... :/ Those mappings just set Stream ID == PCI RID

Re: [PATCH v4 3/4] iommu/ioasid: Add custom allocators

2019-10-04 Thread Jean-Philippe Brucker
On Wed, Oct 02, 2019 at 12:42:42PM -0700, Jacob Pan wrote: > IOASID allocation may rely on platform specific methods. One use case is > that when running in the guest, in order to obtain system wide global > IOASIDs, emulated allocation interface is needed to communicate with the > host. Here we

Re: [PATCH v2] iommu/arm-smmu: Break insecure users by disabling bypass by default

2019-10-04 Thread Tim Harvey
On Fri, Oct 4, 2019 at 9:36 AM Robin Murphy wrote: > > On 04/10/2019 16:23, Tim Harvey wrote: > > On Thu, Oct 3, 2019 at 3:24 PM Robin Murphy wrote: > >> > >> On 2019-10-03 9:51 pm, Tim Harvey wrote: > >>> On Thu, Oct 3, 2019 at 1:42 PM Robin Murphy wrote: > > Hi Tim, > > On

Re: [PATCH v2] iommu/arm-smmu: Break insecure users by disabling bypass by default

2019-10-04 Thread Robin Murphy
On 04/10/2019 16:23, Tim Harvey wrote: On Thu, Oct 3, 2019 at 3:24 PM Robin Murphy wrote: On 2019-10-03 9:51 pm, Tim Harvey wrote: On Thu, Oct 3, 2019 at 1:42 PM Robin Murphy wrote: Hi Tim, On 2019-10-03 7:27 pm, Tim Harvey wrote: On Fri, Mar 1, 2019 at 11:21 AM Douglas Anderson wrote:

Re: [PATCH v2] iommu/arm-smmu: Break insecure users by disabling bypass by default

2019-10-04 Thread Tim Harvey
On Thu, Oct 3, 2019 at 3:24 PM Robin Murphy wrote: > > On 2019-10-03 9:51 pm, Tim Harvey wrote: > > On Thu, Oct 3, 2019 at 1:42 PM Robin Murphy wrote: > >> > >> Hi Tim, > >> > >> On 2019-10-03 7:27 pm, Tim Harvey wrote: > >>> On Fri, Mar 1, 2019 at 11:21 AM Douglas Anderson > >>> wrote: >

[RESEND TRIVIAL 2/3] treewide: Fix Kconfig indentation

2019-10-04 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- certs/Kconfig | 14 ++--- init/Kconfig | 28 +-

[RESEND TRIVIAL 3/3] treewide: arch: Fix Kconfig indentation

2019-10-04 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- arch/Kconfig | 4 ++-- arch/alpha/Kconfig | 2 +-

[RESEND TRIVIAL 1/3] treewide: drivers: Fix Kconfig indentation

2019-10-04 Thread Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like: $ sed -e 's/^/\t/' -i */Kconfig Signed-off-by: Krzysztof Kozlowski --- drivers/acpi/Kconfig | 8 +- drivers/ata/Kconfig | 12 +--