RE: [PATCH v1 6/8] vfio/type1: Bind guest page tables to host

2020-04-10 Thread Liu, Yi L
Hi Alex, > From: Alex Williamson > Sent: Friday, April 3, 2020 3:57 AM > To: Liu, Yi L > Subject: Re: [PATCH v1 6/8] vfio/type1: Bind guest page tables to host > > On Sun, 22 Mar 2020 05:32:03 -0700 > "Liu, Yi L" wrote: > > > From: Liu Yi L > > > > VFIO_TYPE1_NESTING_IOMMU is an IOMMU type

RE: [PATCH 20/28] mm: remove the pgprot argument to __vmalloc

2020-04-10 Thread Michael Kelley via iommu
From: Christoph Hellwig Sent: Wednesday, April 8, 2020 4:59 AM > > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove > it. > > Signed-off-by: Christoph Hellwig > --- > arch/x86/hyperv/hv_init.c | 3 +-- > arch/x86/include/asm/kvm_host.h| 3 +-- >

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-10 Thread Minchan Kim
Hi Sergey, On Fri, Apr 10, 2020 at 11:38:45AM +0900, Sergey Senozhatsky wrote: > On (20/04/09 10:08), Minchan Kim wrote: > > > > Even though I don't know how many usecase we have using zsmalloc as > > > > module(I heard only once by dumb reason), it could affect existing > > > > users. Thus,

RE: [PATCH 01/28] x86/hyperv: use vmalloc_exec for the hypercall page

2020-04-10 Thread Michael Kelley via iommu
From: Christoph Hellwig Sent: Wednesday, April 8, 2020 4:59 AM > > Use the designated helper for allocating executable kernel memory, and > remove the now unused PAGE_KERNEL_RX define. > > Signed-off-by: Christoph Hellwig > --- > arch/x86/hyperv/hv_init.c| 2 +- >

Re: [PATCH v11 07/10] iommu/vt-d: Add svm/sva invalidate function

2020-04-10 Thread Jacob Pan
On Thu, 9 Apr 2020 10:50:34 +0200 Auger Eric wrote: > Hi Jacob, > > On 4/3/20 8:42 PM, Jacob Pan wrote: > > When Shared Virtual Address (SVA) is enabled for a guest OS via > > vIOMMU, we need to provide invalidation support at IOMMU API and > > driver level. This patch adds Intel VT-d specific

Re: [PATCH v11 05/10] iommu/vt-d: Add bind guest PASID support

2020-04-10 Thread Jacob Pan
Hi Eric, Missed a few things in the last reply. On Thu, 9 Apr 2020 09:41:32 +0200 Auger Eric wrote: > > + intel_pasid_tear_down_entry(iommu, dev, > > svm->pasid); > intel_svm_unbind_mm() calls intel_flush_svm_range_dev(svm, sdev, 0, > -1, 0); Don't we need to flush the

Re: [PATCH v11 05/10] iommu/vt-d: Add bind guest PASID support

2020-04-10 Thread Jacob Pan
Hi Eric, On Thu, 9 Apr 2020 09:41:32 +0200 Auger Eric wrote: > Hi Jacob, > > On 4/3/20 8:42 PM, Jacob Pan wrote: > > When supporting guest SVA with emulated IOMMU, the guest PASID > > table is shadowed in VMM. Updates to guest vIOMMU PASID table > > will result in PASID cache flush which will

Re: [rfc v2 3/6] dma-pool: dynamically expanding atomic pools

2020-04-10 Thread David Rientjes via iommu
On Fri, 10 Apr 2020, Hillf Danton wrote: > > On Wed, 8 Apr 2020 14:21:06 -0700 (PDT) David Rientjes wrote: > > > > When an atomic pool becomes fully depleted because it is now relied upon > > for all non-blocking allocations through the DMA API, allow background > > expansion of each pool by a

Re: [PATCH 0/2] iommu: Remove iommu_sva_ops::mm_exit()

2020-04-10 Thread Jacob Pan
On Thu, 9 Apr 2020 16:50:58 +0200 Jean-Philippe Brucker wrote: > > So unbind is coming anyway, the difference in handling in mmu > > release notifier is whether we silently drop DMA fault vs. > > reporting fault? > > What I meant is, between mmu release notifier and unbind(), we can't > print

Re: [PATCH 08/10] iommu/ioasid: Introduce notifier APIs

2020-04-10 Thread Jacob Pan
On Wed, 1 Apr 2020 16:00:06 +0200 Jean-Philippe Brucker wrote: > On Wed, Mar 25, 2020 at 10:55:29AM -0700, Jacob Pan wrote: > > IOASID users fit into the publisher-subscriber pattern, a system > > wide blocking notifier chain can be used to inform subscribers of > > state changes. Notifier

Re: [rfc v2 3/6] dma-pool: dynamically expanding atomic pools

2020-04-10 Thread Hillf Danton
On Wed, 8 Apr 2020 14:21:06 -0700 (PDT) David Rientjes wrote: > > When an atomic pool becomes fully depleted because it is now relied upon > for all non-blocking allocations through the DMA API, allow background > expansion of each pool by a kworker. > > When an atomic pool has less than the

Re: [PATCH] netfilter: nft_fwd_netdev: Fix CONFIG_NET_CLS_ACT=n build

2020-04-10 Thread Geert Uytterhoeven
On Fri, Apr 10, 2020 at 4:26 PM Geert Uytterhoeven wrote: > If CONFIG_NET_CLS_ACT=n: > > net/netfilter/nft_fwd_netdev.c: In function ‘nft_fwd_netdev_eval’: > net/netfilter/nft_fwd_netdev.c:32:10: error: ‘struct sk_buff’ has no > member named ‘tc_redirected’ >

[PATCH] iommu: Fix MTK_IOMMU dependencies

2020-04-10 Thread Geert Uytterhoeven
If NO_DMA=y (e.g. Sun-3 all{mod,yes}-config): drivers/iommu/dma-iommu.o: In function `iommu_dma_mmap': dma-iommu.c:(.text+0x836): undefined reference to `dma_pgprot' IOMMU_DMA must not be selected, unless HAS_DMA=y. Hence fix this by making MTK_IOMMU depend on HAS_DMA. While at it,

[PATCH] netfilter: nft_fwd_netdev: Fix CONFIG_NET_CLS_ACT=n build

2020-04-10 Thread Geert Uytterhoeven
If CONFIG_NET_CLS_ACT=n: net/netfilter/nft_fwd_netdev.c: In function ‘nft_fwd_netdev_eval’: net/netfilter/nft_fwd_netdev.c:32:10: error: ‘struct sk_buff’ has no member named ‘tc_redirected’ pkt->skb->tc_redirected = 1; ^~ net/netfilter/nft_fwd_netdev.c:33:10:

RE: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to userspace

2020-04-10 Thread Liu, Yi L
Hi Jean, Eric, > From: Liu, Yi L > Sent: Thursday, April 9, 2020 8:47 PM > Subject: RE: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to > userspace > [...] > > > >> > > > >> Yes I don't think an u32 is going to cut it for Arm :( We need to > > > >> describe all sorts > > of > > >

Re: [RFC PATCH 33/34] iommu: Remove add_device()/remove_device() code-paths

2020-04-10 Thread Marek Szyprowski
Hi Joerg On 07.04.2020 20:37, Joerg Roedel wrote: > From: Joerg Roedel > > All drivers are converted to use the probe/release_device() > call-backs, so the add_device/remove_device() pointers are unused and > the code using them can be removed. > > Signed-off-by: Joerg Roedel > --- >

Re: [PATCH 19/28] gpu/drm: remove the powerpc hack in drm_legacy_sg_alloc

2020-04-10 Thread Daniel Vetter
On Fri, Apr 10, 2020 at 12:57 AM Benjamin Herrenschmidt wrote: > > On Thu, 2020-04-09 at 11:41 +0200, Daniel Vetter wrote: > > Now if these boxes didn't ever have agp then I think we can get away > > with deleting this, since we've already deleted the legacy radeon > > driver. And that one used