Re: Re: [PATCH v8 10/10] Documentation: Add documentation for VDUSE

2021-06-28 Thread Yongji Xie
On Mon, Jun 28, 2021 at 9:02 PM Stefan Hajnoczi wrote: > > On Tue, Jun 15, 2021 at 10:13:31PM +0800, Xie Yongji wrote: > > VDUSE (vDPA Device in Userspace) is a framework to support > > implementing software-emulated vDPA devices in userspace. This > > document is intended to clarify the VDUSE

Re: [PATCH v8 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Jason Wang
在 2021/6/28 下午6:32, Yongji Xie 写道: The large barrier is bounce-buffer mapping: SPDK requires hugepages for NVMe over PCIe and RDMA, so take some preallcoated hugepages to map as bounce buffer is necessary. Or it's hard to avoid an extra memcpy from bounce-buffer to hugepage. If you can add an

Re: [PATCH v8 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Jason Wang
在 2021/6/28 下午1:54, Liu, Xiaodong 写道: Several issues: - VDUSE needs to limit the total size of the bounce buffers (64M if I was not wrong). Does it work for SPDK? Yes, Jason. It is enough and works for SPDK. Since it's a kind of bounce buffer mainly for in-flight IO, so limited size like

Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Jason Wang
在 2021/6/29 上午11:56, Yongji Xie 写道: On Tue, Jun 29, 2021 at 11:29 AM Jason Wang wrote: 在 2021/6/29 上午10:26, Yongji Xie 写道: On Mon, Jun 28, 2021 at 12:40 PM Jason Wang wrote: 在 2021/6/25 下午12:19, Yongji Xie 写道: 2b) for set_status(): simply relay the message to userspace, reply is no

Re: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Yongji Xie
On Tue, Jun 29, 2021 at 11:29 AM Jason Wang wrote: > > > 在 2021/6/29 上午10:26, Yongji Xie 写道: > > On Mon, Jun 28, 2021 at 12:40 PM Jason Wang wrote: > >> > >> 在 2021/6/25 下午12:19, Yongji Xie 写道: > 2b) for set_status(): simply relay the message to userspace, reply is no > needed.

Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Jason Wang
在 2021/6/29 上午10:26, Yongji Xie 写道: On Mon, Jun 28, 2021 at 12:40 PM Jason Wang wrote: 在 2021/6/25 下午12:19, Yongji Xie 写道: 2b) for set_status(): simply relay the message to userspace, reply is no needed. Userspace will use a command to update the status when the datapath is stop. The the

Re: Re: [PATCH v8 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Yongji Xie
On Mon, Jun 28, 2021 at 9:02 PM Stefan Hajnoczi wrote: > > On Tue, Jun 15, 2021 at 10:13:21PM +0800, Xie Yongji wrote: > > This series introduces a framework that makes it possible to implement > > software-emulated vDPA devices in userspace. And to make it simple, the > > emulated vDPA device's

Re: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Yongji Xie
On Mon, Jun 28, 2021 at 9:02 PM Stefan Hajnoczi wrote: > > On Tue, Jun 15, 2021 at 10:13:30PM +0800, Xie Yongji wrote: > > diff --git a/include/uapi/linux/vduse.h b/include/uapi/linux/vduse.h > > new file mode 100644 > > index ..f21b2e51b5c8 > > --- /dev/null > > +++

Re: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Yongji Xie
On Mon, Jun 28, 2021 at 12:40 PM Jason Wang wrote: > > > 在 2021/6/25 下午12:19, Yongji Xie 写道: > >> 2b) for set_status(): simply relay the message to userspace, reply is no > >> needed. Userspace will use a command to update the status when the > >> datapath is stop. The the status could be fetched

RE: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Tian, Kevin
> From: Alex Williamson > Sent: Tuesday, June 29, 2021 6:32 AM > > On Mon, 28 Jun 2021 01:09:18 + > "Tian, Kevin" wrote: > > > > From: Jason Gunthorpe > > > Sent: Friday, June 25, 2021 10:36 PM > > > > > > On Fri, Jun 25, 2021 at 10:27:18AM +, Tian, Kevin wrote: > > > > > > > - When

RE: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Tian, Kevin
> From: Alex Williamson > Sent: Tuesday, June 29, 2021 7:09 AM > > > > Ideally vfio would also at least be able to register a type1 IOMMU > > > backend through the existing uapi, backed by this iommu code, ie. we'd > > > create a new "iommufd" (but without the user visible fd), > > > > It would

RE: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, June 29, 2021 7:13 AM > > On Mon, Jun 28, 2021 at 05:09:02PM -0600, Alex Williamson wrote: > > On Mon, 28 Jun 2021 19:48:18 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Jun 28, 2021 at 04:31:45PM -0600, Alex Williamson wrote: > > > > > > > I'd

Re: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Jason Gunthorpe
On Mon, Jun 28, 2021 at 05:09:02PM -0600, Alex Williamson wrote: > On Mon, 28 Jun 2021 19:48:18 -0300 > Jason Gunthorpe wrote: > > > On Mon, Jun 28, 2021 at 04:31:45PM -0600, Alex Williamson wrote: > > > > > I'd expect that /dev/iommu will be used by multiple subsystems. All > > > will want to

Re: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Alex Williamson
On Mon, 28 Jun 2021 19:48:18 -0300 Jason Gunthorpe wrote: > On Mon, Jun 28, 2021 at 04:31:45PM -0600, Alex Williamson wrote: > > > I'd expect that /dev/iommu will be used by multiple subsystems. All > > will want to bind devices to address spaces, so shouldn't binding a > > device to an

Re: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Jason Gunthorpe
On Mon, Jun 28, 2021 at 04:31:45PM -0600, Alex Williamson wrote: > I'd expect that /dev/iommu will be used by multiple subsystems. All > will want to bind devices to address spaces, so shouldn't binding a > device to an iommufd be an ioctl on the iommufd, ie. > IOMMU_BIND_VFIO_DEVICE_FD. Maybe

Re: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Alex Williamson
On Mon, 28 Jun 2021 01:09:18 + "Tian, Kevin" wrote: > > From: Jason Gunthorpe > > Sent: Friday, June 25, 2021 10:36 PM > > > > On Fri, Jun 25, 2021 at 10:27:18AM +, Tian, Kevin wrote: > > > > > - When receiving the binding call for the 1st device in a group, > > > iommu_fd > > >

Re: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Jason Gunthorpe
On Mon, Jun 28, 2021 at 06:45:23AM +, Tian, Kevin wrote: > 7) Unbinding detaches the device from the block_dma domain and >re-attach it to the default domain. From now on the user should >be denied from accessing the device. vfio should tear down the >MMIO mapping

Re: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Jason Gunthorpe
On Mon, Jun 28, 2021 at 02:03:56AM +, Tian, Kevin wrote: > Combining with the last paragraph above, are you actually suggesting > that 1:1 group (including mdev) should use a new device-centric vfio > uAPI (without group fd) while existing group-centric vfio uAPI is only > kept for 1:N

Re: [PATCH v8 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Stefan Hajnoczi
On Tue, Jun 15, 2021 at 10:13:21PM +0800, Xie Yongji wrote: > This series introduces a framework that makes it possible to implement > software-emulated vDPA devices in userspace. And to make it simple, the > emulated vDPA device's control path is handled in the kernel and only the > data path is

Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Stefan Hajnoczi
On Tue, Jun 15, 2021 at 10:13:30PM +0800, Xie Yongji wrote: > diff --git a/include/uapi/linux/vduse.h b/include/uapi/linux/vduse.h > new file mode 100644 > index ..f21b2e51b5c8 > --- /dev/null > +++ b/include/uapi/linux/vduse.h > @@ -0,0 +1,143 @@ > +/* SPDX-License-Identifier: GPL-2.0

Re: [PATCH v8 10/10] Documentation: Add documentation for VDUSE

2021-06-28 Thread Stefan Hajnoczi
On Tue, Jun 15, 2021 at 10:13:31PM +0800, Xie Yongji wrote: > VDUSE (vDPA Device in Userspace) is a framework to support > implementing software-emulated vDPA devices in userspace. This > document is intended to clarify the VDUSE design and usage. > > Signed-off-by: Xie Yongji > --- >

Re: [PATCH v8 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-06-28 Thread Yongji Xie
On Mon, 28 Jun 2021 at 10:55, Liu Xiaodong wrote: > > On Tue, Jun 15, 2021 at 10:13:21PM +0800, Xie Yongji wrote: > > > > This series introduces a framework that makes it possible to implement > > software-emulated vDPA devices in userspace. And to make it simple, the > > emulated vDPA device's

Re: [PATCH v4] iommu/of: Fix pci_request_acs() before enumerating PCI devices

2021-06-28 Thread Xingang Wang
Hi Bjorn, I would like to add more explanation about what problem this patch fixed. I am testing the SVA/vSVA series patches written by @Jean and @Brucker. I test with the following qemu command line, with a hisilicon SEC device attached on a pcie-root-port. $QEMU/qemu-system-aarch64 \

Re: [PATCH v4 1/3] iommu: io-pgtable: add DART pagetable format

2021-06-28 Thread Alexander Graf via iommu
On 27.06.21 16:34, Sven Peter wrote: Apple's DART iommu uses a pagetable format that shares some similarities with the ones already implemented by io-pgtable.c. Add a new format variant to support the required differences so that we don't have to duplicate the pagetable handling code.

RE: Plan for /dev/ioasid RFC v2

2021-06-28 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Friday, June 25, 2021 10:36 PM > > On Fri, Jun 25, 2021 at 10:27:18AM +, Tian, Kevin wrote: > > > - When receiving the binding call for the 1st device in a group, iommu_fd > > calls iommu_group_set_block_dma(group, dev->driver) which does > >

Re: [PATCH 9/9] dma-debug: Use memory_intersects() directly

2021-06-28 Thread Kefeng Wang
On 2021/6/28 14:11, Christoph Hellwig wrote: You've sent me a patch 9 out of 9 without the previous 8 patches. There is no way I can sensibly review this series. The full patches is https://lore.kernel.org/linux-arch/20210626073439.150586-1-wangkefeng.w...@huawei.com/T/#t This patch is

Re: [PATCH 9/9] dma-debug: Use memory_intersects() directly

2021-06-28 Thread Christoph Hellwig
You've sent me a patch 9 out of 9 without the previous 8 patches. There is no way I can sensibly review this series. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: Bug#989778: Regression in at least 5.10.y and mainline: Firewire audio interface fails to work properly (when booted under Xen)

2021-06-28 Thread ‍小太
On Thu, 24 Jun 2021 at 04:50, Salvatore Bonaccorso wrote: > Hi Robin, > > On Mon, Jun 14, 2021 at 02:29:08PM +0100, Robin Murphy wrote: > > On 2021-06-13 07:29, Salvatore Bonaccorso wrote: > > > A user in Debian reported the above issue, which was reproducible with > > > 5.13-rc5 and 5.10.y as