Re: [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning

2022-01-12 Thread Yong Wu
On Wed, 2022-01-12 at 11:18 +0100, Krzysztof Kozlowski wrote: > On 11/01/2022 07:39, Yong Wu wrote: > > Mute the warning from "make dtbs_check": > > > > larb@14017000: clock-names: ['apb', 'smi'] is too short > > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > > arch/arm64/boot/dts/media

Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-12 Thread Yong Wu
On Tue, 2022-01-11 at 10:10 +0100, AngeloGioacchino Del Regno wrote: > Il 11/01/22 07:39, Yong Wu ha scritto: > > The successful return value for clk_bulk_prepare_enable is 0, > > rather than > > "< 0". Fix this. > > > > Hello! Thanks for this commit! > However, there are a few comments... > > T

Re: [PATCH v2 5/6] memory: mtk-smi: Add sleep ctrl function

2022-01-12 Thread Yong Wu
On Wed, 2022-01-12 at 11:27 +0100, Krzysztof Kozlowski wrote: > On 11/01/2022 07:39, Yong Wu wrote: > > Sleep control means that when the larb goes to sleep, we should > > wait a bit > > until all the current commands are finished. Thus, when the larb > > runtime > > suspends, we need to enable thi

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-12 Thread Stephen Boyd
Quoting Yong Wu (2022-01-12 01:09:19) > On Tue, 2022-01-11 at 16:27 -0800, Stephen Boyd wrote: > > ---8<--- > > diff --git a/drivers/base/component.c b/drivers/base/component.c > > index 64ad7478c67a..97f253a41bdf 100644 > > --- a/drivers/base/component.c > > +++ b/drivers/base/component.c > > @@ -

Re: [git pull] IOMMU Updates for Linux v5.17

2022-01-12 Thread pr-tracker-bot
The pull request you sent on Wed, 12 Jan 2022 18:02:23 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git > iommu-updates-v5.17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/13eaa5bda0df8f5c1c4f2a4fb4a0bc20787dcc68 Thank you! -- Deet-doot-dot, I

Re: [GIT PULL] dma-mapping updates for Linux 5.17

2022-01-12 Thread pr-tracker-bot
The pull request you sent on Mon, 10 Jan 2022 19:46:02 +0100: > git://git.infradead.org/users/hch/dma-mapping.git tags/dma-mapping-5.17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7e7b69654724c72bd3219b71f58937845dca0b2b Thank you! -- Deet-doot-dot, I am a bot. h

[git pull] IOMMU Updates for Linux v5.17

2022-01-12 Thread Joerg Roedel
Hi Linus, The following changes since commit c9e6606c7fe92b50a02ce51dda82586ebdf99b48: Linux 5.16-rc8 (2022-01-02 14:23:25 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git iommu-updates-v5.17 for you to fetch changes up to 66dc1b7

[PATCH v3] iommu: Fix potential use-after-free during probe

2022-01-12 Thread Vijayanand Jitta
Kasan has reported the following use after free on dev->iommu. when a device probe fails and it is in process of freeing dev->iommu in dev_iommu_free function, a deferred_probe_work_func runs in parallel and tries to access dev->iommu->fwspec in of_iommu_configure path thus causing use after free.

[PATCH v3] iommu: Fix potential use-after-free during probe

2022-01-12 Thread Vijayanand
From: Vijayanand Jitta Kasan has reported the following use after free on dev->iommu. when a device probe fails and it is in process of freeing dev->iommu in dev_iommu_free function, a deferred_probe_work_func runs in parallel and tries to access dev->iommu->fwspec in of_iommu_configure path thus

Re: [PATCH] iommu/omap: Fix missing put_device() call in omap_iommu_probe_device

2022-01-12 Thread Miaoqian Lin
Hi Suman, On Mon, Jan 10, 2022 at 12:43:57PM -0600, Suman Anna wrote: > Hi Miaoqian, > > On 1/9/22 8:43 PM, Miaoqian Lin wrote: > > Hi Suman Anna, > > On Fri, Jan 07, 2022 at 08:42:16AM -0600, Suman Anna wrote: > >> Hi Miaoqian, > >> > >> > >>> Add the corresponding 'put_device()' in the error ha

Re: [RFC PATCH v3 3/8] mm: migrate: allocate the right size of non hugetlb or THP compound pages.

2022-01-12 Thread David Hildenbrand
On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_migration_target() is used by alloc_contig_range() and non-LRU > movable compound pages can be migrated. Current code does not allocate the > right page size for such pages. Check THP precisely using > is_transparent_huge() and add allocat

Re: [RFC PATCH v3 2/8] mm: compaction: handle non-lru compound pages properly in isolate_migratepages_block().

2022-01-12 Thread David Hildenbrand
On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > In isolate_migratepages_block(), a !PageLRU tail page can be encountered > when the page is larger than a pageblock. Use compound head page for the > checks inside and skip the entire compound page when isolation succeeds. > This will currentl

Re: [RFC PATCH v3 1/8] mm: page_alloc: avoid merging non-fallbackable pageblocks with others.

2022-01-12 Thread David Hildenbrand
On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > This is done in addition to MIGRATE_ISOLATE pageblock merge avoidance. > It prepares for the upcoming removal of the MAX_ORDER-1 alignment > requirement for CMA and alloc_contig_range(). > > MIGRARTE_HIGHATOMIC should not merge with other migra

Re: [PATCH v2 5/6] memory: mtk-smi: Add sleep ctrl function

2022-01-12 Thread Krzysztof Kozlowski
On 11/01/2022 07:39, Yong Wu wrote: > Sleep control means that when the larb goes to sleep, we should wait a bit > until all the current commands are finished. Thus, when the larb runtime > suspends, we need to enable this function to wait until all the existed > commands are finished. When the lar

Re: [PATCH v2 4/6] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable

2022-01-12 Thread Krzysztof Kozlowski
On 11/01/2022 07:39, Yong Wu wrote: > The successful return value for clk_bulk_prepare_enable is 0, rather than > "< 0". Fix this. I do not understand. The commit description does not match the code. What is the error here? > > Fixes: 0e14917c57f9 ("memory: mtk-smi: Use clk_bulk clock ops") The

Re: [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning

2022-01-12 Thread Krzysztof Kozlowski
On 11/01/2022 07:39, Yong Wu wrote: > Mute the warning from "make dtbs_check": > > larb@14017000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > ... > > larb@1601

Re: [PATCH v2 1/6] dt-bindings: memory: mtk-smi: Fix larb-id dtbs_check warning

2022-01-12 Thread Krzysztof Kozlowski
On 11/01/2022 07:38, Yong Wu wrote: > Mute the warning from "make dtbs_check": > > larb@14016000: 'mediatek,larb-id' is a required property > arch/arm64/boot/dts/mediatek/mt8167-pumpkin.dt.yaml > larb@15001000: 'mediatek,larb-id' is a required property > arch/arm64/boot/dts/mediatek/mt

Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver

2022-01-12 Thread Yong Wu
On Tue, 2022-01-11 at 16:27 -0800, Stephen Boyd wrote: > Quoting Yong Wu (2022-01-11 04:22:23) > > Hi Stephen, > > > > Thanks for helping update here. > > > > On Thu, 2022-01-06 at 13:45 -0800, Stephen Boyd wrote: > > > Use an aggregate driver instead of component ops so that we can > > > get > >