On Sun, Nov 10, 2019 at 10:24 AM Deepa Dinamani wrote:
>
> On Fri, Nov 8, 2019 at 2:48 PM Deepa Dinamani wrote:
> >
> > > > > For VMM live update case, we should be able to detect and bypass
> > > > > the shutdown that Deepa introduced here
> > + x86_platform.iommu_shutdown = intel_iommu_shutdown;
>
> How about moving it to detect_intel_iommu() in drivers/iommu/dmar.c? And
Ok, makes sense to move it along with the init handler.
> make sure that it's included with CONFIG_X86_64.
You mean CONFIG_X86 like the init that is already
> > > For VMM live update case, we should be able to detect and bypass
> > > the shutdown that Deepa introduced here, so keep IOMMU still operating?
> >
> > Is that a 'yes' to Deepa's "if someone wants to make it conditional, we
> > can do that" ?
>
> Yes, I think so. Thanks!
Are these changes
On Thu, Nov 7, 2019 at 12:59 PM Deepa Dinamani wrote:
> +static void intel_iommu_shutdown(void)
> + if (no_iommu || dmar_disabled)
> + return;
This check is actually not required here, as the handler is only
installed after these have been checked in intel_iommu_in
mode'
would be reported for each iommu. The message will not appear when the
DMA-remapping is not enabled on entry to the kernel.
Signed-off-by: Deepa Dinamani
---
drivers/iommu/intel-iommu.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/iommu/intel-iommu.c b
On Fri, Nov 8, 2019 at 2:48 PM Deepa Dinamani wrote:
>
> > > > For VMM live update case, we should be able to detect and bypass
> > > > the shutdown that Deepa introduced here, so keep IOMMU still operating?
> > >
> > > Is that a 'yes' to Deepa's
that before, the info message
'DMAR: Translation was enabled for but we are not in kdump mode'
would be reported for each iommu. The message will not appear when the
DMA-remapping is not enabled on entry to the kernel.
Signed-off-by: Deepa Dinamani
---
Changes since v1:
* move shutdown registration
