Re: [PATCH 0/4] Generic IOMMU page table framework

2014-12-15 Thread Laurent Pinchart
Hi Will, On Monday 15 December 2014 16:10:52 Will Deacon wrote: On Sun, Dec 14, 2014 at 11:49:30PM +, Laurent Pinchart wrote: On Thursday 27 November 2014 11:51:14 Will Deacon wrote: This series introduces a generic IOMMU page table allocation framework, implements support for ARM

Re: [RFC PATCH v4 0/8] Introduce automatic DMA configuration for IOMMU masters

2014-12-15 Thread Laurent Pinchart
Hi Will, On Monday 15 December 2014 17:34:16 Will Deacon wrote: On Mon, Dec 15, 2014 at 05:21:16PM +, Laurent Pinchart wrote: On Wednesday 19 November 2014 11:41:50 Will Deacon wrote: +static void __remove_iommu_mapping_entry(struct kref *kref) +{ + struct dma_iommu_mapping_entry

Re: [PATCH] iommu/ipmmu-vmsa: change IOMMU_EXEC to IOMMU_NOEXEC

2014-12-15 Thread Laurent Pinchart
Hi Geert, On Monday 15 December 2014 11:45:27 Geert Uytterhoeven wrote: On Sun, Dec 14, 2014 at 1:55 AM, Laurent Pinchart wrote: The IOMMU_EXEC flag has been renamed to IOMMU_NOEXEC by commit ... inverted and replaced by ... At first I hadn't noticed this, and was wondering about

[PATCH FOR v3.19 - v2] iommu/ipmmu-vmsa: change IOMMU_EXEC to IOMMU_NOEXEC

2014-12-15 Thread Laurent Pinchart
From: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Commit a720b41c41f5a7e4 (iommu/arm-smmu: change IOMMU_EXEC to IOMMU_NOEXEC) has inverted and replaced the IOMMU_EXEC flag with IOMMU_NOEXEC. Update the driver accordingly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene

Re: [PATCH 10/10] ARM: shmobile: r8a7791: Add IPMMU DT nodes

2014-12-15 Thread Laurent Pinchart
Hi Geert, On Monday 15 December 2014 14:07:52 Geert Uytterhoeven wrote: On Mon, Dec 15, 2014 at 1:13 AM, Laurent Pinchart wrote: Add the seven IPMMU instances found in the r8a7791 to DT with a disabled status. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-15 Thread Laurent Pinchart
Hi Tomasz, On Monday 15 December 2014 11:39:01 Tomasz Figa wrote: On Sat, Dec 13, 2014 at 5:47 AM, Laurent Pinchart wrote: On Friday 12 December 2014 13:15:51 Tomasz Figa wrote: On Fri, Dec 12, 2014 at 5:48 AM, Rafael J. Wysocki wrote: On Thursday, December 11, 2014 04:51:37 PM Ulf Hansson

Re: [PATCH 10/10] ARM: shmobile: r8a7791: Add IPMMU DT nodes

2014-12-15 Thread Laurent Pinchart
Hi Magnus, On Tuesday 16 December 2014 07:44:32 Magnus Damm wrote: On Tue, Dec 16, 2014 at 3:44 AM, Laurent Pinchart wrote: On Monday 15 December 2014 14:07:52 Geert Uytterhoeven wrote: On Mon, Dec 15, 2014 at 1:13 AM, Laurent Pinchart wrote: Add the seven IPMMU instances found

Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall

2014-12-14 Thread Laurent Pinchart
, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v6 6/8] dma-mapping: detect and configure IOMMU in of_dma_configure

2014-12-14 Thread Laurent Pinchart
() callback. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v6 6/8] dma-mapping: detect and configure IOMMU in of_dma_configure

2014-12-14 Thread Laurent Pinchart
, + bool coherent) { } +#endif + +#ifndef arch_teardown_dma_ops +static inline void arch_teardown_dma_ops(struct device *dev) { } #endif static inline unsigned int dma_get_max_seg_size(struct device *dev) -- Regards, Laurent Pinchart ___ iommu

Re: [PATCH v6 6/8] dma-mapping: detect and configure IOMMU in of_dma_configure

2014-12-14 Thread Laurent Pinchart
Hi Will, On Sunday 14 December 2014 17:49:34 Laurent Pinchart wrote: On Wednesday 10 December 2014 15:08:53 Will Deacon wrote: On Wed, Dec 10, 2014 at 02:52:56PM +, Rob Clark wrote: On Mon, Dec 1, 2014 at 11:57 AM, Will Deacon wrote: This patch extends of_dma_configure so

Re: [PATCH 1/4] iommu: introduce generic page table allocation framework

2014-12-14 Thread Laurent Pinchart
io_pgtable_ops *ops); + +#endif /* __IO_PGTABLE_H */ -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 0/4] Generic IOMMU page table framework

2014-12-14 Thread Laurent Pinchart
successfully tested the patch set with the Renesas IPMMU-VMSA driver with the following extension to the allocator. Tested-by: Laurent Pinchart laurent.pinch...@ideasonboard.com From 4bebb7f3a5a48541d4c89ce7c61e6ff66686c3a9 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart laurent.pinchart+rene

[PATCH 00/10] Renesas IPMMU-VMSA fixes and DT support

2014-12-14 Thread Laurent Pinchart
(+), 63 deletions(-) create mode 100644 Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt delete mode 100644 include/linux/platform_data/ipmmu-vmsa.h -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org

[PATCH 03/10] iommu/ipmmu-vmsa: Invalidate TLB after unmapping

2014-12-14 Thread Laurent Pinchart
The TLB must be invalidated after unmapping memory to remove stale TLB entries. this was supposed to be performed already, but a bug in the driver prevented the TLB invalidate function from being called. Fix it. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com

[PATCH 01/10] iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment

2014-12-14 Thread Laurent Pinchart
in that case instead of returning immediately. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 7dab5cbcc775

[PATCH 04/10] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails

2014-12-14 Thread Laurent Pinchart
From: Axel Lin axel@ingics.com Signed-off-by: Axel Lin axel@ingics.com Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu

[PATCH 06/10] iommu/ipmmu-vmsa: Add device tree support

2014-12-14 Thread Laurent Pinchart
Make platform data optional when the device is instantiated from DT and look up the micro-TLB number in the bus master DT node. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 39 +++ 1 file changed

[PATCH 02/10] iommu/ipmmu-vmsa: Flush P[UM]D entry before freeing the child page table

2014-12-14 Thread Laurent Pinchart
the child page table. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index f7036adb5634..fcb603d8b041

[PATCH 05/10] iommu/ipmmu-vmsa: Add device tree bindings documentation

2014-12-14 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- .../bindings/iommu/renesas,ipmmu-vmsa.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt Cc: devicet

[PATCH 07/10] iommu/ipmmu-vmsa: Support multiple micro TLBs per device

2014-12-14 Thread Laurent Pinchart
to different IOMMUs is also unsupported for the same reason. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 115 + 1 file changed, 86 insertions(+), 29 deletions(-) diff --git a/drivers/iommu/ipmmu

[PATCH] iommu/ipmmu-vmsa: change IOMMU_EXEC to IOMMU_NOEXEC

2014-12-13 Thread Laurent Pinchart
The IOMMU_EXEC flag has been renamed to IOMMU_NOEXEC by commit a720b41c41f5a7e4 (iommu/arm-smmu: change IOMMU_EXEC to IOMMU_NOEXEC). Update the driver accordingly. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 6 +++--- 1 file changed

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-12 Thread Laurent Pinchart
Hello, On Friday 12 December 2014 13:15:51 Tomasz Figa wrote: On Fri, Dec 12, 2014 at 5:48 AM, Rafael J. Wysocki wrote: On Thursday, December 11, 2014 04:51:37 PM Ulf Hansson wrote: On 11 December 2014 at 16:31, Kevin Hilman khil...@kernel.org wrote: [+ Laurent Pinchart] Tomasz

Re: [PATCH v6 6/8] dma-mapping: detect and configure IOMMU in of_dma_configure

2014-12-10 Thread Laurent Pinchart
of_xlate correctly, or work around it with the DT representation. Exactly for that reason, wouldn't it be better to let the client device whether it wants to use the DMA mapping API abstraction or manually control the IOMMU mappings ? -- Regards, Laurent Pinchart

Re: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-12-02 Thread Laurent Pinchart
Hi Will, On Tuesday 02 December 2014 09:41:56 Will Deacon wrote: On Mon, Dec 01, 2014 at 08:21:58PM +, Laurent Pinchart wrote: On Monday 01 December 2014 17:23:15 Will Deacon wrote: On Sun, Nov 30, 2014 at 11:29:46PM +, Laurent Pinchart wrote: On Thursday 27 November 2014 11:51

Re: [PATCH 0/4] Generic IOMMU page table framework

2014-12-02 Thread Laurent Pinchart
Hi Will, On Monday 01 December 2014 12:05:34 Will Deacon wrote: On Sun, Nov 30, 2014 at 10:03:08PM +, Laurent Pinchart wrote: On Thursday 27 November 2014 11:51:14 Will Deacon wrote: Hi all, This series introduces a generic IOMMU page table allocation framework, implements

Re: [PATCH 0/4] Generic IOMMU page table framework

2014-12-02 Thread Laurent Pinchart
Hi Will, On Tuesday 02 December 2014 13:53:56 Will Deacon wrote: On Tue, Dec 02, 2014 at 01:47:41PM +, Laurent Pinchart wrote: On Monday 01 December 2014 12:05:34 Will Deacon wrote: On Sun, Nov 30, 2014 at 10:03:08PM +, Laurent Pinchart wrote: On Thursday 27 November 2014 11:51:14

Re: [PATCH 1/4] iommu: introduce generic page table allocation framework

2014-12-01 Thread Laurent Pinchart
Hi Will, On Monday 01 December 2014 12:13:38 Will Deacon wrote: On Sun, Nov 30, 2014 at 10:00:21PM +, Laurent Pinchart wrote: On Thursday 27 November 2014 11:51:15 Will Deacon wrote: diff --git a/drivers/iommu/io-pgtable.c b/drivers/iommu/io-pgtable.c new file mode 100644 index

Re: [PATCH 1/4] iommu: introduce generic page table allocation framework

2014-11-30 Thread Laurent Pinchart
io_pgtable_ops *ops); + +#endif /* __IO_PGTABLE_H */ -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 0/4] Generic IOMMU page table framework

2014-11-30 Thread Laurent Pinchart
create mode 100644 drivers/iommu/io-pgtable.c create mode 100644 drivers/iommu/io-pgtable.h -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 2/4] iommu: add ARM LPAE page table allocator

2014-11-30 Thread Laurent Pinchart
; }; }; enum io_pgtable_fmt { + ARM_LPAE_S1, + ARM_LPAE_S2, IO_PGTABLE_NUM_FMTS, }; -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] iommu/ipmmu-vmsa: Return proper error if devm_request_irq fails

2014-11-01 Thread Laurent Pinchart
Hi Axel, Thank you for the patch. On Saturday 01 November 2014 11:45:32 Axel Lin wrote: Signed-off-by: Axel Lin axel@ingics.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Joerg, could you please pick this patch up ? --- drivers/iommu/ipmmu-vmsa.c | 2 +- 1 file

Re: [PATCH v2 12/17] iommu/omap: Integrate omap-iommu-debug into omap-iommu

2014-10-22 Thread Laurent Pinchart
debugfs support is built alongside the OMAP IOMMU driver only when this option is enabled. Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/Kconfig| 12 ++--- drivers/iommu/omap-iommu-debug.c | 100

Re: [RFC PATCH v3 5/7] dma-mapping: detect and configure IOMMU in of_dma_configure

2014-10-14 Thread Laurent Pinchart
Hi Will, On Monday 22 September 2014 18:50:27 Will Deacon wrote: On Mon, Sep 22, 2014 at 10:29:10AM +0100, Thierry Reding wrote: On Thu, Sep 18, 2014 at 02:17:33PM +0300, Laurent Pinchart wrote: On Friday 12 September 2014 17:34:53 Will Deacon wrote: This patch extends of_dma_configure so

Re: [RFC PATCH v3 6/7] arm: call iommu_init before of_platform_populate

2014-10-14 Thread Laurent Pinchart
implementation. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH v3 4/7] iommu: provide helper function to configure an IOMMU for an of master

2014-10-14 Thread Laurent Pinchart
Hi Will, On Monday 22 September 2014 18:13:52 Will Deacon wrote: On Thu, Sep 18, 2014 at 12:13:13PM +0100, Laurent Pinchart wrote: Hi Will, Hi Laurent, Thank you for the patch. Sorry for the delay in replying, I was at Connect last week and the email has backed up. No worries

Re: [RFC PATCH v3 6/7] arm: call iommu_init before of_platform_populate

2014-10-14 Thread Laurent Pinchart
Hi Thierry, On Tuesday 14 October 2014 15:37:59 Thierry Reding wrote: On Tue, Oct 14, 2014 at 03:20:46PM +0200, Arnd Bergmann wrote: On Tuesday 14 October 2014 16:07:38 Laurent Pinchart wrote: On Tuesday 23 September 2014 09:44:25 Arnd Bergmann wrote: On Tuesday 23 September 2014 09:02:39

Re: [RFC PATCH v3 6/7] arm: call iommu_init before of_platform_populate

2014-10-14 Thread Laurent Pinchart
Hi Thierry, On Tuesday 14 October 2014 17:05:29 Thierry Reding wrote: On Tue, Oct 14, 2014 at 06:01:58PM +0300, Laurent Pinchart wrote: On Tuesday 14 October 2014 15:37:59 Thierry Reding wrote: On Tue, Oct 14, 2014 at 03:20:46PM +0200, Arnd Bergmann wrote: On Tuesday 14 October 2014 16:07

Re: [RFC PATCH v3 7/7] arm: dma-mapping: plumb our iommu mapping ops into arch_setup_dma_ops

2014-10-06 Thread Laurent Pinchart
in the IOMMU core to defer probing of devices for which the IOMMU isn't available yet based on the DT iommus property. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 12/17] iommu/omap: Integrate omap-iommu-debug into omap-iommu

2014-10-01 Thread Laurent Pinchart
the OMAP IOMMU driver, and enabled automatically only when debugfs is enabled. That's the part I'm unsure about. We're loosing the ability to save space by not building the omap-iommu debugfs support when debugfs is enabled. For the rest of the series, Acked-by: Laurent Pinchart

Re: [RFC PATCH v3 7/7] arm: dma-mapping: plumb our iommu mapping ops into arch_setup_dma_ops

2014-09-22 Thread Laurent Pinchart
display controllers that need access to the same IOVA domain so that they can scan out framebuffers. Or simply for IOMMUs that serve multiple masters and support a single domain only. -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/2] iommu/omap: Reverse dependency between omap-iommu and omap-iommu2

2014-09-20 Thread Laurent Pinchart
Hi Suman, On Tuesday 09 September 2014 17:31:44 Suman Anna wrote: On Tuesday 09 September 2014 16:33:11 Suman Anna wrote: On 09/09/2014 10:45 AM, Laurent Pinchart wrote: The OMAP IOMMU driver supports both the OMAP1 and OMAP2+ IOMMU variants by splitting the driver into a core module

Re: [RFC PATCH v3 4/7] iommu: provide helper function to configure an IOMMU for an of master

2014-09-18 Thread Laurent Pinchart
; +} +static inline void of_iommu_deconfigure(struct kref *kref) { } #endif /* CONFIG_OF_IOMMU */ -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH v3 5/7] dma-mapping: detect and configure IOMMU in of_dma_configure

2014-09-18 Thread Laurent Pinchart
(struct device *dev) -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH v2 4/7] iommu: provide helper function to configure an IOMMU for an of master

2014-09-10 Thread Laurent Pinchart
*/ -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH 1/2] iommu/omap: Reverse dependency between omap-iommu and omap-iommu2

2014-09-09 Thread Laurent Pinchart
. As the arch-specific operations pointer is now initialized at probe time, this change requires turning it from a global variable into a per-device variable. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/omap-iommu-debug.c | 6 ++- drivers/iommu/omap-iommu.c | 94

[PATCH 0/2] OMAP IOMMU cleanups

2014-09-09 Thread Laurent Pinchart
Hello, Those two patches clean up the OMAP IOMMU driver. Please see individual commit messages for more information. Laurent Pinchart (2): iommu/omap: Reverse dependency between omap-iommu and omap-iommu2 iommu/omap: Remove omap_iommu unused owner field drivers/iommu/omap-iommu-debug.c

Re: [PATCH 2/2] iommu/omap: Fix iommu archdata name for DT-based devices

2014-09-05 Thread Laurent Pinchart
that rework the IOMMU core for better DT integration, have you seen them ? Can you point out the thread? Are you talking about http://marc.info/?l=linux-arm-kernelm=140968072117851w=2? Yes that's the one. -- Regards, Laurent Pinchart ___ iommu mailing

Re: [PATCHv2 2/2] iommu/omap: Fix iommu archdata name for DT-based devices

2014-09-05 Thread Laurent Pinchart
assigned the name of the IOMMU user device, instead of the name of the IOMMU device as required by the attach logic. Fix this issue so that DT-based devices can attach successfully to an IOMMU domain. Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch

Re: [RFC PATCH 1/7] iommu: provide early initialisation hook for IOMMU drivers

2014-09-02 Thread Laurent Pinchart
way. -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH 0/7] Introduce automatic DMA configuration for IOMMU masters

2014-09-02 Thread Laurent Pinchart
master to TLB association somehow configurable, but associating all bus masters with a single TLB as a first step is fine. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman

Re: [PATCH] iommu/omap: Remove casting the return value which is a void pointer

2014-08-29 Thread Laurent Pinchart
; \ -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 04/29] drivers: base: add notifier for failed driver bind

2014-08-21 Thread Laurent Pinchart
failed to bind + to device */ extern struct kset *bus_get_kset(struct bus_type *bus); extern struct klist *bus_get_device_klist(struct bus_type *bus); -- Regards, Laurent Pinchart ___ iommu mailing

Re: [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions

2014-08-20 Thread Laurent Pinchart
Hi Konrad, On Wednesday 20 August 2014 09:02:50 Konrad Rzeszutek Wilk wrote: On Tue, Aug 19, 2014 at 10:52:46PM +0200, Laurent Pinchart wrote: On Tuesday 19 August 2014 11:40:24 Olav Haugan wrote: On 8/19/2014 9:11 AM, Laurent Pinchart wrote: On Tuesday 19 August 2014 13:59:54 Joerg

Re: [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions

2014-08-19 Thread Laurent Pinchart
with much enthusiasm. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions

2014-08-19 Thread Laurent Pinchart
On Tuesday 19 August 2014 11:40:24 Olav Haugan wrote: On 8/19/2014 9:11 AM, Laurent Pinchart wrote: On Tuesday 19 August 2014 13:59:54 Joerg Roedel wrote: On Mon, Aug 18, 2014 at 03:47:56PM -0700, Olav Haugan wrote: If the alignment is not correct then iommu_map() will return error

Re: [PATCH v5 1/1] iommu-api: Add map_sg/unmap_sg functions

2014-08-12 Thread Laurent Pinchart
, + unsigned long flags) +{ + return domain-ops-unmap_sg(domain, iova, size, flags); +} + -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v5] devicetree: Add generic IOMMU device tree bindings

2014-07-31 Thread Laurent Pinchart
. This is nearly identical to my own IOMMU DT bindings experiment developed with the Renesas IPMMU-VMSA driver, so I can't disagree. Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Changes in v5: - clarify comment about dma-ranges vs. IOMMU regarding a device's disabled state

Trouble with R-Car IPMMU and DMAC (help needed)

2014-07-25 Thread Laurent Pinchart
). -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH 1/3] iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment

2014-07-24 Thread Laurent Pinchart
in that case instead of returning immediately. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 53cde08..7dc77a6

[PATCH 2/3] iommu/ipmmu-vmsa: Flush P[UM]D entry before freeing the child page table

2014-07-24 Thread Laurent Pinchart
the child page table. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 7dc77a6..eb605e5 100644

[PATCH 0/3] Renesas IPMMU-VMSA fixes

2014-07-24 Thread Laurent Pinchart
Hello, This series fixes small issues with the ipmmu-vmsa driver. Please see individual patches for details. If not too late, I'd like these fixes to be merged in v3.17 (after proper review of course, or, in the worst case, after lack of review). Laurent Pinchart (3): iommu/ipmmu-vmsa

[PATCH 3/3] iommu/ipmmu-vmsa: Invalidate TLB after unmapping

2014-07-24 Thread Laurent Pinchart
The TLB must be invalidated after unmapping memory to remove stale TLB entries. this was supposed to be performed already, but a bug in the driver prevented the TLB invalidate function from being called. Fix it. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-23 Thread Laurent Pinchart
in your trees. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-22 Thread Laurent Pinchart
Hi Joerg, (Your attention is kindly requested in time for v3.17, please see below) On Monday 21 July 2014 23:19:29 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140721 11:17]: On Monday 21 July 2014 02:33:36 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-21 Thread Laurent Pinchart
Hi Suman, Joerg and Tony, On Friday 18 July 2014 11:53:56 Suman Anna wrote: On 07/18/2014 05:49 AM, Laurent Pinchart wrote: Hello, The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-21 Thread Laurent Pinchart
Hi Tony and Joerg, On Monday 21 July 2014 02:33:36 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140721 02:16]: Hi Suman, Joerg and Tony, On Friday 18 July 2014 11:53:56 Suman Anna wrote: On 07/18/2014 05:49 AM, Laurent Pinchart wrote: Hello

[PATCH v2 2/3] ARM: omap: Don't set iommu pdata da_start and da_end fields

2014-07-18 Thread Laurent Pinchart
The fields are not used by the driver and will be removed from platform data. Don't set them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/omap-iommu.c | 2 -- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 arch/arm/mach-omap2

[PATCH v2 3/3] iommu/omap: Remove platform data da_start and da_end fields

2014-07-18 Thread Laurent Pinchart
The fields were used by the now gone omap-iovmm driver. They're not used anymore, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/linux/platform_data/iommu-omap.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/linux/platform_data/iommu

Re: [PATCH] iommu/omap: Remove virtual memory manager

2014-07-18 Thread Laurent Pinchart
Hi Suman, Thank you for the review. On Thursday 17 July 2014 10:53:03 Suman Anna wrote: On 07/17/2014 06:09 AM, Laurent Pinchart wrote: The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager

[PATCH v2 1/3] iommu/omap: Remove virtual memory manager

2014-07-18 Thread Laurent Pinchart
The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/Kconfig| 10 +- drivers/iommu/Makefile

[PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-18 Thread Laurent Pinchart
- Remove omap_iommu da_start and da_end fields - Added patches 2/3 and 3/3 Laurent Pinchart (3): iommu/omap: Remove virtual memory manager ARM: omap: Don't set iommu pdata da_start and da_end fields iommu/omap: Remove platform data da_start and da_end fields arch/arm/mach-omap2/omap-iommu.c

[PATCH] iommu/omap: Remove virtual memory manager

2014-07-17 Thread Laurent Pinchart
The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Joerg, could you please pick this patch up for v3.17 if possible ? drivers

Re: [PATCH v2 01/10] iommu/ipmmu-vmsa: Refactor micro-TLB lookup

2014-07-14 Thread Laurent Pinchart
Hi Khiem, On Monday 14 July 2014 09:19:23 Khiem Nguyen wrote: On 7/10/2014 7:37 PM, Laurent Pinchart wrote: On Thursday 10 July 2014 09:03:26 Khiem Nguyen wrote: On 5/15/2014 7:40 PM, Laurent Pinchart wrote: Cache the micro-TLB number in archdata allocated in the .add_device handler

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-06-03 Thread Laurent Pinchart
an additional platform_driver_unregister() call in the bus_set_iommu() error path. -- Regards, Laurent Pinchart ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 02/10] iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment

2014-05-26 Thread Laurent Pinchart
Hi Joerg, On Monday 26 May 2014 11:23:11 Joerg Roedel wrote: On Thu, May 15, 2014 at 12:40:43PM +0200, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [PATCH v2 00/10] Renesas ipmmu-vmsa: Miscellaneous cleanups and fixes

2014-05-21 Thread Laurent Pinchart
Hi Joerg, Ping ? On Thursday 15 May 2014 12:40:41 Laurent Pinchart wrote: Hello, This patch set cleans up and fixes small issues in the ipmmu-vmsa driver. The patches are based on top of [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU that adds the ipmmu-vmsa driver

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-05-15 Thread Laurent Pinchart
Hi Joerg, On Wednesday 14 May 2014 00:00:23 Joerg Roedel wrote: On Tue, May 13, 2014 at 11:04:10PM +0200, Laurent Pinchart wrote: Isn't this the same as ipmmu_tlb_invalidate()? ipmmu_tlb_invalidate() performs a read-update-write operation on the IMCTR register to set the FLUSH bit

[PATCH v2 04/10] iommu/ipmmu-vmsa: Define driver-specific page directory sizes

2014-05-15 Thread Laurent Pinchart
that always evaluate to the right value. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 313b5b9

[PATCH v2 00/10] Renesas ipmmu-vmsa: Miscellaneous cleanups and fixes

2014-05-15 Thread Laurent Pinchart
been posted previously and the only comment I've received was about a missing #define in patch 04/10. Cc: Joerg Roedel j...@8bytes.org Changes since v1: - Add missing IPMMU_PTRS_PER_PUD definition in patch 04/10 Laurent Pinchart (10): iommu/ipmmu-vmsa: Refactor micro-TLB lookup iommu/ipmmu

[PATCH v2 02/10] iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment

2014-05-15 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 49e00f7..49dbedd 100644 --- a/drivers/iommu/ipmmu-vmsa.c

[PATCH v2 01/10] iommu/ipmmu-vmsa: Refactor micro-TLB lookup

2014-05-15 Thread Laurent Pinchart
Cache the micro-TLB number in archdata allocated in the .add_device handler instead of looking it up when the deviced is attached and detached. This simplifies the .attach_dev and .detach_dev operations and prepares for DT support. Signed-off-by: Laurent Pinchart laurent.pinchart+rene

[PATCH v2 03/10] iommu/ipmmu-vmsa: Fix the supported page sizes

2014-05-15 Thread Laurent Pinchart
The hardware supports 2MB page sizes, not 1MB. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 49dbedd

[PATCH v2 06/10] iommu/ipmmu-vmsa: PMD is never folded, PUD always is

2014-05-15 Thread Laurent Pinchart
The driver only supports the 3-level long descriptor format that has no PUD and always has a PMD. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 66 +++--- 1 file changed, 9 insertions(+), 57

[PATCH v2 08/10] iommu/ipmmu-vmsa: Support 2MB mappings

2014-05-15 Thread Laurent Pinchart
Add support for 2MB block mappings at the PMD level. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers

[PATCH v2 09/10] iommu/ipmmu-vmsa: Remove stage 2 PTE bits definitions

2014-05-15 Thread Laurent Pinchart
We don't support stage 2 translation yet. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 27fd4d0..a4175d3 100644

[PATCH v2 07/10] iommu/ipmmu-vmsa: Rewrite page table management

2014-05-15 Thread Laurent Pinchart
The IOMMU core will only call us with page sizes advertized as supported by the driver. We can thus simplify the code by removing loops over PGD and PMD entries. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 193

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-05-13 Thread Laurent Pinchart
+0200, Laurent Pinchart wrote: +static void ipmmu_domain_destroy_context(struct ipmmu_vmsa_domain *domain) +{ + /* +* Disable the context. Flush the TLB as required when modifying the +* context registers. +* +* TODO: Is TLB flush really needed

Re: [GIT PULL FOR v3.16] SH-Mobile IPMMU miscellaneous cleanups

2014-05-12 Thread Laurent Pinchart
Hi Joerg, On Monday 12 May 2014 20:55:54 Joerg Roedel wrote: On Thu, Apr 17, 2014 at 12:18:21PM +0200, Laurent Pinchart wrote: git://linuxtv.org/pinchartl/fbdev.git iommu/for-v3.16 Pulled, thanks Laurent, Thank you. Now, what about the iommu: Add driver for Renesas VMSA-compatible IPMMU

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-05-02 Thread Laurent Pinchart
Hi Joerg, On Thursday 17 April 2014 12:14:00 Laurent Pinchart wrote: On Wednesday 09 April 2014 12:57:03 Joerg Roedel wrote: On Wed, Apr 09, 2014 at 12:43:57PM +0200, Laurent Pinchart wrote: On Wednesday 02 April 2014 12:47:37 Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart

Re: [PATCH 0/9] Renesas ipmmu-vmsa: Miscellaneous cleanups and fixes

2014-04-22 Thread Laurent Pinchart
Hi Will, On Tuesday 22 April 2014 12:34:23 Will Deacon wrote: On Mon, Apr 21, 2014 at 03:13:00PM +0100, Laurent Pinchart wrote: Hello, Hi Laurent, This patch set cleans up and fixes small issues in the ipmmu-vmsa driver. The patches are based on top of [PATCH v3] iommu: Add driver

Re: [PATCH] arm: dma-mapping: Fix mapping size value

2014-04-21 Thread Laurent Pinchart
* bitmap_size; + mapping-size = mapping-bits PAGE_SHIFT; spin_lock_init(mapping-lock); -- 1.8.1.3 On Mon, Apr 21, 2014 at 4:06 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Ritesh, On Saturday 19 April 2014 16:55:30 Ritesh Harjani wrote

Re: [PATCH] arm: dma-mapping: Fix mapping size value

2014-04-21 Thread Laurent Pinchart
On Monday 21 April 2014 11:53:12 Laurent Pinchart wrote: Hi Ritesh, On Monday 21 April 2014 09:31:38 Ritesh Harjani wrote: Fixed the commit message. Please find the new patch below: Thank you. Your mail has wrapped lines and converted tabs to whitespaces. Could you please fix

[PATCH 0/9] Renesas ipmmu-vmsa: Miscellaneous cleanups and fixes

2014-04-21 Thread Laurent Pinchart
, or is there a reason to keep loops over PGD and PMD entries ? Removing them makes the implementation of 68kB and 2MB pages easier. Laurent Pinchart (9): iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment iommu/ipmmu-vmsa: Fix the supported page sizes iommu/ipmmu

[PATCH 2/9] iommu/ipmmu-vmsa: Fix the supported page sizes

2014-04-21 Thread Laurent Pinchart
The hardware supports 2MB page sizes, not 1MB. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 1e0a757

[PATCH 1/9] iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment

2014-04-21 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index d277bde..1e0a757 100644 --- a/drivers/iommu/ipmmu-vmsa.c

[PATCH 3/9] iommu/ipmmu-vmsa: Define driver-specific page directory sizes

2014-04-21 Thread Laurent Pinchart
that always evaluate to the right value. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index 1ae97d8

[PATCH 4/9] iommu/ipmmu-vmsa: Set the PTE contiguous hint bit when possible

2014-04-21 Thread Laurent Pinchart
The contiguous hint bit signals to the IOMMU that a range of 16 PTEs refer to physically contiguous memory. It improves performances by dividing the number of TLB lookups by 16, effectively implementing 64kB page sizes. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com

[PATCH 5/9] iommu/ipmmu-vmsa: PMD is never folded, PUD always is

2014-04-21 Thread Laurent Pinchart
The driver only supports the 3-level long descriptor format that has no PUD and always has a PMD. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 65 +++--- 1 file changed, 9 insertions(+), 56

[PATCH 7/9] iommu/ipmmu-vmsa: Support 2MB mappings

2014-04-21 Thread Laurent Pinchart
Add support for 2MB block mappings at the PMD level. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com --- drivers/iommu/ipmmu-vmsa.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers

<    1   2   3   4   >