Re: [PATCH] iommu: qcom: Revert "iommu/arm: Cleanup resources in case of probe error path"

2021-07-05 Thread Amey Narkhede
On 21/07/05 08:56AM, Marek Szyprowski wrote: > QCOM IOMMU driver calls bus_set_iommu() for every IOMMU device controller, > what fails for the second and latter IOMMU devices. This is intended and > must be not fatal to the driver registration process. Also the cleanup > path should take care of

[PATCH] iommu/arm: Cleanup resources in case of probe error path

2021-06-08 Thread Amey Narkhede
If device registration fails, remove sysfs attribute and if setting bus callbacks fails, unregister the device and cleanup the sysfs attribute. Signed-off-by: Amey Narkhede --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 14 -- drivers/iommu/arm/arm-smmu/arm-smmu.c | 15

Re: [PATCH] iommu/qcom: Cleanup resources in case of probe error path

2021-06-08 Thread Amey Narkhede
On 21/06/08 10:29AM, Will Deacon wrote: > On Thu, Apr 22, 2021 at 03:40:30AM +0530, Amey Narkhede wrote: > > If device registration fails, remove sysfs attribute > > and if setting bus callbacks fails, unregister the device > > and cleanup the sysfs attribute. > > >

[PATCH] iommu/qcom: Cleanup resources in case of probe error path

2021-04-21 Thread Amey Narkhede
If device registration fails, remove sysfs attribute and if setting bus callbacks fails, unregister the device and cleanup the sysfs attribute. Signed-off-by: Amey Narkhede --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff