Re: [PATCH -next v4 2/2] iommu/arm-smmu-v3: Add suspend and resume support

2021-08-30 Thread Bixuan Cui
On 2021/8/30 15:38, Bixuan Cui wrote: > Changes in v4: > * Restore the arm_smmu_suspend() function code to the v2 version(Directly > return 0 in it). Hello, I looked up the code of smmu.c and the manual of smmu v3. For the suspend is implemented by the external clock-gating, it is

[PATCH -next v4 1/2] platform-msi: Save the msg context to desc in platform_msi_write_msg()

2021-08-30 Thread Bixuan Cui
Save the msg context to desc when when the msi interrupt is requested. The drivers can use it in special scenarios(such as resume). Signed-off-by: Bixuan Cui --- drivers/base/platform-msi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/platform-msi.c b/drivers/base

[PATCH -next v4 2/2] iommu/arm-smmu-v3: Add suspend and resume support

2021-08-30 Thread Bixuan Cui
. Signed-off-by: Bixuan Cui Reviewed-by: Wei Yongjun Reviewed-by: Zhen Lei Reviewed-by: Ding Tianhong Reviewed-by: Hanjun Guo --- Changes in v4: * Restore the arm_smmu_suspend() function code to the v2 version(Directly return 0 in it). Changes in v3: * Move the code of save msg context into msi

[PATCH -next v3 2/2] iommu/arm-smmu-v3: Add suspend and resume support

2021-08-28 Thread Bixuan Cui
. Signed-off-by: Bixuan Cui --- Changes in v3: * Move the code of save msg context into msi platform (A new patch: "platform-msi: Save the msg context to desc in platform_msi_write_msg()"). * Add bypass member to the struct arm_smmu_device for per-SMMU bypass control(used by r

[PATCH -next v3 1/2] platform-msi: Save the msg context to desc in platform_msi_write_msg()

2021-08-28 Thread Bixuan Cui
Save the msg context to desc when the msi interrupt is requested. The drivers can use it in special scenarios(such as resume). Signed-off-by: Bixuan Cui --- drivers/base/platform-msi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/platform-msi.c b/drivers/base/platform

[PATCH -next v2] iommu/arm-smmu-v3: Add suspend and resume support

2021-07-27 Thread Bixuan Cui
. Signed-off-by: Bixuan Cui Reviewed-by: Wei Yongjun Reviewed-by: Zhen Lei Reviewed-by: Ding Tianhong Reviewed-by: Hanjun Guo --- Changes in v2: * Using get_cached_msi_msg() instead of the descriptor to resume msi_msg in arm_smmu_resume_msis(); * Move arm_smmu_resume_msis() from

Re: [PATCH -next] iommu/arm-smmu-v3: Add suspend and resume support

2021-07-22 Thread Bixuan Cui
On 2021/7/21 21:59, Robin Murphy wrote: >> On Wed, 21 Jul 2021 12:42:14 +0100, >> Robin Murphy wrote: >>> >>> [ +Marc for MSI bits ] >>> >>> On 2021-07-21 02:33, Bixuan Cui wrote: >>>> Add suspend and resume support for arm-smm

Re: [PATCH -next] iommu/arm-smmu-v3: Add suspend and resume support

2021-07-22 Thread Bixuan Cui
On 2021/7/21 23:01, Marc Zyngier wrote: > On Wed, 21 Jul 2021 14:59:47 +0100, > Robin Murphy wrote: >> >> On 2021-07-21 14:12, Marc Zyngier wrote: >>> On Wed, 21 Jul 2021 12:42:14 +0100, >>> Robin Murphy wrote: >>>> >>>> [ +Marc fo

[PATCH -next] iommu/arm-smmu-v3: Add suspend and resume support

2021-07-20 Thread Bixuan Cui
. Signed-off-by: Bixuan Cui Reviewed-by: Wei Yongjun Reviewed-by: Zhen Lei Reviewed-by: Ding Tianhong Reviewed-by: Hanjun Guo --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 72 ++--- 1 file changed, 64 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu-v3

[PATCH -next 1/3] iommu/arm-smmu-v3: fix missing a blank line after declarations

2021-05-20 Thread Bixuan Cui
Fixes checkpatch warnings in arm-smmu-v3.c: WARNING: Missing a blank line after declarations Signed-off-by: Bixuan Cui --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm

[PATCH -next 0/3] iommu/arm-smmu-v3: clean up some code style issues

2021-05-20 Thread Bixuan Cui
Clean up some code style issues. Bixuan Cui (3): iommu/arm-smmu-v3: fix missing a blank line after declarations iommu/arm-smmu-v3: Change *array into *const array iommu/arm-smmu-v3: Prefer unsigned int to bare use of unsigned drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 9 +++-- 1

[PATCH -next 3/3] iommu/arm-smmu-v3: Prefer unsigned int to bare use of unsigned

2021-05-20 Thread Bixuan Cui
Fix checkpatch warning in arm-smmu-v3.c: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Bixuan Cui --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm

[PATCH -next 2/3] iommu/arm-smmu-v3: Change *array into *const array

2021-05-20 Thread Bixuan Cui
Fix checkpatch warning in arm-smmu-v3.c: static const char * array should probably be static const char * const Signed-off-by: Bixuan Cui --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3

[PATCH -next] iommu/virtio: Add missing MODULE_DEVICE_TABLE

2021-05-07 Thread Bixuan Cui
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Reported-by: Hulk Robot Signed-off-by: Bixuan Cui --- drivers/iommu/virtio-iommu.c | 1 + 1 file changed, 1 insertion(+) diff