Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-31 Thread Jerome Glisse
On Thu, Jan 31, 2019 at 07:02:15PM +, Jason Gunthorpe wrote: > On Thu, Jan 31, 2019 at 09:13:55AM +0100, Christoph Hellwig wrote: > > On Wed, Jan 30, 2019 at 03:52:13PM -0700, Logan Gunthorpe wrote: > > > > *shrug* so what if the special GUP called a VMA op instead of > > > > traversing the VMA

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-31 Thread Jerome Glisse
On Thu, Jan 31, 2019 at 09:13:55AM +0100, Christoph Hellwig wrote: > On Wed, Jan 30, 2019 at 03:52:13PM -0700, Logan Gunthorpe wrote: > > > *shrug* so what if the special GUP called a VMA op instead of > > > traversing the VMA PTEs today? Why does it really matter? It could > > > easily change to a

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-31 Thread Jerome Glisse
On Thu, Jan 31, 2019 at 09:05:01AM +0100, Christoph Hellwig wrote: > On Wed, Jan 30, 2019 at 08:44:20PM +, Jason Gunthorpe wrote: > > Not really, for MRs most drivers care about DMA addresses only. The > > only reason struct page ever gets involved is because it is part of > > the GUP, SGL and

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-31 Thread Jerome Glisse
On Thu, Jan 31, 2019 at 09:02:03AM +0100, Christoph Hellwig wrote: > On Wed, Jan 30, 2019 at 01:50:27PM -0500, Jerome Glisse wrote: > > I do not see how VMA changes are any different than using struct page > > in respect to userspace exposure. Those vma callback do not need t

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 10:51:55PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 05:47:05PM -0500, Jerome Glisse wrote: > > On Wed, Jan 30, 2019 at 10:33:04PM +, Jason Gunthorpe wrote: > > > On Wed, Jan 30, 2019 at 05:30:27PM -0500, Jerome Glisse wrote: > >

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 10:33:04PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 05:30:27PM -0500, Jerome Glisse wrote: > > > > What is the problem in the HMM mirror that it needs this restriction? > > > > No restriction at all here. I think i just wasn

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 09:56:07PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 04:45:25PM -0500, Jerome Glisse wrote: > > On Wed, Jan 30, 2019 at 08:50:00PM +, Jason Gunthorpe wrote: > > > On Wed, Jan 30, 2019 at 03:43:32PM -0500, Jerome Glisse wrote: > >

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 08:50:00PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 03:43:32PM -0500, Jerome Glisse wrote: > > On Wed, Jan 30, 2019 at 08:11:19PM +, Jason Gunthorpe wrote: > > > On Wed, Jan 30, 2019 at 01:00:02PM -0700, Logan Gunthorpe wrote: >

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 08:11:19PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 01:00:02PM -0700, Logan Gunthorpe wrote: > > > We never changed SGLs. We still use them to pass p2pdma pages, only we > > need to be a bit careful where we send the entire SGL. I see no reason > > why we can

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 12:52:44PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-30 12:22 p.m., Jerome Glisse wrote: > > On Wed, Jan 30, 2019 at 06:56:59PM +, Jason Gunthorpe wrote: > >> On Wed, Jan 30, 2019 at 10:17:27AM -0700, Logan Gunthorpe wrote: > >>

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 06:56:59PM +, Jason Gunthorpe wrote: > On Wed, Jan 30, 2019 at 10:17:27AM -0700, Logan Gunthorpe wrote: > > > > > > On 2019-01-29 9:18 p.m., Jason Gunthorpe wrote: > > > Every attempt to give BAR memory to struct page has run into major > > > trouble, IMHO, so I like t

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 11:13:11AM -0700, Logan Gunthorpe wrote: > > > On 2019-01-30 10:44 a.m., Jason Gunthorpe wrote: > > I don't see why a special case with a VMA is really that different. > > Well one *really* big difference is the VMA changes necessarily expose > specialized new functionali

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 06:26:53PM +0100, Christoph Hellwig wrote: > On Wed, Jan 30, 2019 at 10:55:43AM -0500, Jerome Glisse wrote: > > Even outside GPU driver, device driver like RDMA just want to share their > > doorbell to other device and they do not want to see those doorbell

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 10:33:39AM +, Koenig, Christian wrote: > Am 30.01.19 um 09:02 schrieb Christoph Hellwig: > > On Tue, Jan 29, 2019 at 08:58:35PM +, Jason Gunthorpe wrote: > >> On Tue, Jan 29, 2019 at 01:39:49PM -0700, Logan Gunthorpe wrote: > >> > >>> implement the mapping. And I don

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 09:00:06AM +0100, Christoph Hellwig wrote: > On Wed, Jan 30, 2019 at 04:18:48AM +, Jason Gunthorpe wrote: > > Every attempt to give BAR memory to struct page has run into major > > trouble, IMHO, so I like that this approach avoids that. > > Way less problems than not h

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-30 Thread Jerome Glisse
On Wed, Jan 30, 2019 at 04:30:27AM +, Jason Gunthorpe wrote: > On Tue, Jan 29, 2019 at 07:08:06PM -0500, Jerome Glisse wrote: > > On Tue, Jan 29, 2019 at 11:02:25PM +, Jason Gunthorpe wrote: > > > On Tue, Jan 29, 2019 at 03:44:00PM -0500, Jerome Glisse wrote: > > &

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 06:17:43PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 4:47 p.m., Jerome Glisse wrote: > > The whole point is to allow to use device memory for range of virtual > > address of a process when it does make sense to use device memory for > &

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 11:02:25PM +, Jason Gunthorpe wrote: > On Tue, Jan 29, 2019 at 03:44:00PM -0500, Jerome Glisse wrote: > > > > But this API doesn't seem to offer any control - I thought that > > > control was all coming from the mm/hmm notifiers trigge

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 03:58:45PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 2:50 p.m., Jerome Glisse wrote: > > No this is the non HMM case i am talking about here. Fully ignore HMM > > in this frame. A GPU driver that do not support or use HMM in anyway > >

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 02:30:49PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 1:57 p.m., Jerome Glisse wrote: > > GPU driver must be in control and must be call to. Here there is 2 cases > > in this patchset and i should have instead posted 2 separate patchset as &g

Re: [RFC PATCH 1/5] pci/p2p: add a function to test peer to peer capability

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 01:44:09PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 12:44 p.m., Greg Kroah-Hartman wrote: > > On Tue, Jan 29, 2019 at 11:24:09AM -0700, Logan Gunthorpe wrote: > >> > >> > >> On 2019-01-29 10:47 a.m., jgli...@redhat.com wrote: > >>> +bool pci_test_p2p(struct device

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 01:39:49PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 12:32 p.m., Jason Gunthorpe wrote: > > Jerome, I think it would be nice to have a helper scheme - I think the > > simple case would be simple remapping of PCI BAR memory, so if we > > could have, say something li

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 08:24:36PM +, Jason Gunthorpe wrote: > On Tue, Jan 29, 2019 at 02:50:55PM -0500, Jerome Glisse wrote: > > > GPU driver do want more control :) GPU driver are moving things around > > all the time and they have more memory than bar space (on newer pl

Re: [RFC PATCH 1/5] pci/p2p: add a function to test peer to peer capability

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 02:56:38PM -0500, Alex Deucher wrote: > On Tue, Jan 29, 2019 at 12:47 PM wrote: > > > > From: Jérôme Glisse > > > > device_test_p2p() return true if two devices can peer to peer to > > each other. We add a generic function as different inter-connect > > can support peer to

Re: [RFC PATCH 2/5] drivers/base: add a function to test peer to peer capability

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 08:46:05PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 29, 2019 at 12:47:25PM -0500, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > device_test_p2p() return true if two devices can peer to peer to > > each other. We add a generic function as different inter-c

Re: [RFC PATCH 2/5] drivers/base: add a function to test peer to peer capability

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 11:26:01AM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 10:47 a.m., jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > device_test_p2p() return true if two devices can peer to peer to > > each other. We add a generic function as different inter-connect > > ca

Re: [RFC PATCH 1/5] pci/p2p: add a function to test peer to peer capability

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 08:44:26PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 29, 2019 at 11:24:09AM -0700, Logan Gunthorpe wrote: > > > > > > On 2019-01-29 10:47 a.m., jgli...@redhat.com wrote: > > > +bool pci_test_p2p(struct device *devA, struct device *devB) > > > +{ > > > + struct pci_dev

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 07:32:57PM +, Jason Gunthorpe wrote: > On Tue, Jan 29, 2019 at 02:11:23PM -0500, Jerome Glisse wrote: > > On Tue, Jan 29, 2019 at 11:36:29AM -0700, Logan Gunthorpe wrote: > > > > > > > > > On 2019-01-29

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 12:24:04PM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 12:11 p.m., Jerome Glisse wrote: > > On Tue, Jan 29, 2019 at 11:36:29AM -0700, Logan Gunthorpe wrote: > >> > >> > >> On 2019-01-29 10:47 a.m., jgli...@redhat.com wrot

Re: [RFC PATCH 3/5] mm/vma: add support for peer to peer to device vma

2019-01-29 Thread Jerome Glisse
On Tue, Jan 29, 2019 at 11:36:29AM -0700, Logan Gunthorpe wrote: > > > On 2019-01-29 10:47 a.m., jgli...@redhat.com wrote: > > > + /* > > +* Optional for device driver that want to allow peer to peer (p2p) > > +* mapping of their vma (which can be back by some device memory) to > > +

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-20 Thread Jerome Glisse
On Thu, Sep 20, 2018 at 01:55:43PM +0800, Kenneth Lee wrote: > On Tue, Sep 18, 2018 at 09:03:14AM -0400, Jerome Glisse wrote: > > On Tue, Sep 18, 2018 at 02:00:14PM +0800, Kenneth Lee wrote: > > > On Mon, Sep 17, 2018 at 08:37:45AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-18 Thread Jerome Glisse
On Tue, Sep 18, 2018 at 02:00:14PM +0800, Kenneth Lee wrote: > On Mon, Sep 17, 2018 at 08:37:45AM -0400, Jerome Glisse wrote: > > On Mon, Sep 17, 2018 at 04:39:40PM +0800, Kenneth Lee wrote: > > > On Sun, Sep 16, 2018 at 09:42:44PM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-17 Thread Jerome Glisse
On Mon, Sep 17, 2018 at 04:39:40PM +0800, Kenneth Lee wrote: > On Sun, Sep 16, 2018 at 09:42:44PM -0400, Jerome Glisse wrote: > > So i want to summarize issues i have as this threads have dig deep into > > details. For this i would like to differentiate two cases first the ea

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-16 Thread Jerome Glisse
So i want to summarize issues i have as this threads have dig deep into details. For this i would like to differentiate two cases first the easy one when relying on SVA/SVM. Then the second one when there is no SVA/SVM. In both cases your objectives as i understand them: [R1]- expose a common user

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-14 Thread Jerome Glisse
On Fri, Sep 14, 2018 at 06:50:55AM +, Tian, Kevin wrote: > > From: Jerome Glisse > > Sent: Thursday, September 13, 2018 10:52 PM > > > [...] > > AFAIK, on x86 and PPC at least, all PCIE devices are in the same group > > by default at boot or at least a

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-14 Thread Jerome Glisse
On Fri, Sep 14, 2018 at 11:12:01AM +0800, Kenneth Lee wrote: > On Thu, Sep 13, 2018 at 10:51:50AM -0400, Jerome Glisse wrote: > > On Thu, Sep 13, 2018 at 04:32:32PM +0800, Kenneth Lee wrote: > > > On Tue, Sep 11, 2018 at 09:40:14AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-13 Thread Jerome Glisse
On Thu, Sep 13, 2018 at 04:32:32PM +0800, Kenneth Lee wrote: > On Tue, Sep 11, 2018 at 09:40:14AM -0400, Jerome Glisse wrote: > > On Tue, Sep 11, 2018 at 02:40:43PM +0800, Kenneth Lee wrote: > > > On Mon, Sep 10, 2018 at 11:33:59PM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-11 Thread Jerome Glisse
On Tue, Sep 11, 2018 at 02:40:43PM +0800, Kenneth Lee wrote: > On Mon, Sep 10, 2018 at 11:33:59PM -0400, Jerome Glisse wrote: > > On Tue, Sep 11, 2018 at 10:42:09AM +0800, Kenneth Lee wrote: > > > On Mon, Sep 10, 2018 at 10:54:23AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-10 Thread Jerome Glisse
On Tue, Sep 11, 2018 at 10:42:09AM +0800, Kenneth Lee wrote: > On Mon, Sep 10, 2018 at 10:54:23AM -0400, Jerome Glisse wrote: > > On Mon, Sep 10, 2018 at 11:28:09AM +0800, Kenneth Lee wrote: > > > On Fri, Sep 07, 2018 at 12:53:06PM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-10 Thread Jerome Glisse
On Mon, Sep 10, 2018 at 11:28:09AM +0800, Kenneth Lee wrote: > On Fri, Sep 07, 2018 at 12:53:06PM -0400, Jerome Glisse wrote: > > On Fri, Sep 07, 2018 at 12:01:38PM +0800, Kenneth Lee wrote: > > > On Thu, Sep 06, 2018 at 09:31:33AM -0400, Jerome Glisse wrote: > > > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-07 Thread Jerome Glisse
On Fri, Sep 07, 2018 at 06:55:45PM +0100, Jean-Philippe Brucker wrote: > On 07/09/2018 17:53, Jerome Glisse wrote: > > So there is no reasons to do that under VFIO. Especialy as in your example > > it is not a real user space device driver, the userspace portion only knows >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-07 Thread Jerome Glisse
On Fri, Sep 07, 2018 at 12:01:38PM +0800, Kenneth Lee wrote: > On Thu, Sep 06, 2018 at 09:31:33AM -0400, Jerome Glisse wrote: > > Date: Thu, 6 Sep 2018 09:31:33 -0400 > > From: Jerome Glisse > > To: Kenneth Lee > > CC: Alex Williamson , Kenneth Lee > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-06 Thread Jerome Glisse
On Thu, Sep 06, 2018 at 05:45:32PM +0800, Kenneth Lee wrote: > On Tue, Sep 04, 2018 at 10:15:09AM -0600, Alex Williamson wrote: > > Date: Tue, 4 Sep 2018 10:15:09 -0600 > > From: Alex Williamson > > To: Jerome Glisse > > CC: Kenneth Lee , Jonathan Corbet , > >

Re: [RFCv2 PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-09-04 Thread Jerome Glisse
On Mon, Sep 03, 2018 at 08:51:57AM +0800, Kenneth Lee wrote: > From: Kenneth Lee > > WarpDrive is an accelerator framework to expose the hardware capabilities > directly to the user space. It makes use of the exist vfio and vfio-mdev > facilities. So the user application can send request and DMA

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-13 Thread Jerome Glisse
On Mon, Aug 13, 2018 at 05:29:31PM +0800, Kenneth Lee wrote: > > I made a quick change basing on the RFCv1 here: > > https://github.com/Kenneth-Lee/linux-kernel-warpdrive/commits/warpdrive-v0.6 > > I just made it compilable and not test it yet. But it shows how the idea is > going to be. > > T

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-10 Thread Jerome Glisse
On Fri, Aug 10, 2018 at 11:39:13AM +0800, Kenneth Lee wrote: > On Thu, Aug 09, 2018 at 10:46:13AM -0400, Jerome Glisse wrote: > > Date: Thu, 9 Aug 2018 10:46:13 -0400 > > From: Jerome Glisse > > To: Kenneth Lee > > CC: Kenneth Lee , "Tian, Kevin" > >

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-09 Thread Jerome Glisse
On Thu, Aug 09, 2018 at 04:03:52PM +0800, Kenneth Lee wrote: > On Wed, Aug 08, 2018 at 11:18:35AM -0400, Jerome Glisse wrote: > > On Wed, Aug 08, 2018 at 09:08:42AM +0800, Kenneth Lee wrote: > > > 在 2018年08月06日 星期一 11:32 下午, Jerome Glisse 写道: > > > > On Mon, Au

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-08 Thread Jerome Glisse
On Wed, Aug 08, 2018 at 09:08:42AM +0800, Kenneth Lee wrote: > > > 在 2018年08月06日 星期一 11:32 下午, Jerome Glisse 写道: > > On Mon, Aug 06, 2018 at 11:12:52AM +0800, Kenneth Lee wrote: > > > On Fri, Aug 03, 2018 at 10:39:44AM -0400, Jerome Glisse wrote: > > > > On F

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-06 Thread Jerome Glisse
On Mon, Aug 06, 2018 at 11:12:52AM +0800, Kenneth Lee wrote: > On Fri, Aug 03, 2018 at 10:39:44AM -0400, Jerome Glisse wrote: > > On Fri, Aug 03, 2018 at 11:47:21AM +0800, Kenneth Lee wrote: > > > On Thu, Aug 02, 2018 at 10:22:43AM -0400, Jerome Glisse wrote: > > > >

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-03 Thread Jerome Glisse
On Fri, Aug 03, 2018 at 03:20:43PM +0100, Alan Cox wrote: > > If we are going to have any kind of general purpose accelerator API then > > > it has to be able to implement things like > > > > Why is the existing driver model not good enough ? So you want > > a device with function X you look int

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-03 Thread Jerome Glisse
On Fri, Aug 03, 2018 at 11:47:21AM +0800, Kenneth Lee wrote: > On Thu, Aug 02, 2018 at 10:22:43AM -0400, Jerome Glisse wrote: > > Date: Thu, 2 Aug 2018 10:22:43 -0400 > > From: Jerome Glisse > > To: Kenneth Lee > > CC: "Tian, Kevin" , Hao Fang , > &

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-02 Thread Jerome Glisse
On Thu, Aug 02, 2018 at 11:10:00AM +0100, Alan Cox wrote: > > One motivation I guess, is that most accelerators lack of a > > well-abstracted high level APIs similar to GPU side (e.g. OpenCL > > clearly defines Shared Virtual Memory models). VFIO mdev > > might be an alternative common interface

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-02 Thread Jerome Glisse
On Thu, Aug 02, 2018 at 12:05:57PM +0800, Kenneth Lee wrote: > On Thu, Aug 02, 2018 at 02:33:12AM +, Tian, Kevin wrote: > > Date: Thu, 2 Aug 2018 02:33:12 + > > > From: Jerome Glisse > > > On Wed, Aug 01, 2018 at 06:22:14PM +0800, Kenneth Lee wrote

Re: [RFC PATCH 0/7] A General Accelerator Framework, WarpDrive

2018-08-01 Thread Jerome Glisse
On Wed, Aug 01, 2018 at 06:22:14PM +0800, Kenneth Lee wrote: > From: Kenneth Lee > > WarpDrive is an accelerator framework to expose the hardware capabilities > directly to the user space. It makes use of the exist vfio and vfio-mdev > facilities. So the user application can send request and DMA

Re: [PATCH 1/2] mm/mmu_notifier: avoid double notification when it is useless v2

2017-10-23 Thread Jerome Glisse
On Sat, Oct 21, 2017 at 11:47:03AM -0400, Jerome Glisse wrote: > On Sat, Oct 21, 2017 at 04:54:40PM +1100, Balbir Singh wrote: > > On Thu, 2017-10-19 at 12:58 -0400, Jerome Glisse wrote: > > > On Thu, Oct 19, 2017 at 09:53:11PM +1100, Balbir Singh wrote: > > > > O

Re: [PATCH 1/2] mm/mmu_notifier: avoid double notification when it is useless v2

2017-10-21 Thread Jerome Glisse
On Sat, Oct 21, 2017 at 04:54:40PM +1100, Balbir Singh wrote: > On Thu, 2017-10-19 at 12:58 -0400, Jerome Glisse wrote: > > On Thu, Oct 19, 2017 at 09:53:11PM +1100, Balbir Singh wrote: > > > On Thu, Oct 19, 2017 at 2:28 PM, Jerome Glisse wrote: > > > > On Thu, Oc

Re: [PATCH 1/2] mm/mmu_notifier: avoid double notification when it is useless v2

2017-10-19 Thread Jerome Glisse
On Thu, Oct 19, 2017 at 09:53:11PM +1100, Balbir Singh wrote: > On Thu, Oct 19, 2017 at 2:28 PM, Jerome Glisse wrote: > > On Thu, Oct 19, 2017 at 02:04:26PM +1100, Balbir Singh wrote: > >> On Mon, 16 Oct 2017 23:10:02 -0400 > >> jgli...@redhat.com wrote: >

Re: [PATCH 1/2] mm/mmu_notifier: avoid double notification when it is useless v2

2017-10-18 Thread Jerome Glisse
On Thu, Oct 19, 2017 at 02:04:26PM +1100, Balbir Singh wrote: > On Mon, 16 Oct 2017 23:10:02 -0400 > jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > + /* > > +* No need to call mmu_notifier_invalidate_range() as we are > > +* downgrading page table p

Re: [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback

2017-10-18 Thread Jerome Glisse
On Thu, Oct 19, 2017 at 01:43:19PM +1100, Balbir Singh wrote: > On Mon, 16 Oct 2017 23:10:01 -0400 > jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > (Andrew you already have v1 in your queue of patch 1, patch 2 is new, > > i think you can drop it patch 1 v1 for v2, v2 is bit more co

Re: [PATCH] mm/mmu_notifier: avoid double notification when it is useless

2017-10-03 Thread Jerome Glisse
On Tue, Oct 03, 2017 at 05:43:47PM -0700, Nadav Amit wrote: > Jerome Glisse wrote: > > > On Wed, Oct 04, 2017 at 01:42:15AM +0200, Andrea Arcangeli wrote: > > > >> I'd like some more explanation about the inner working of "that new > >> user"

Re: [PATCH] mm/mmu_notifier: avoid double notification when it is useless

2017-10-03 Thread Jerome Glisse
On Wed, Oct 04, 2017 at 01:42:15AM +0200, Andrea Arcangeli wrote: > Hello Jerome, > > On Fri, Sep 01, 2017 at 01:30:11PM -0400, Jerome Glisse wrote: > > +Case A is obvious you do not want to take the risk for the device to write > > to > > +a page that might no

Re: [PATCH 02/13] mm/rmap: update to new mmu_notifier semantic

2017-08-30 Thread Jerome Glisse
On Wed, Aug 30, 2017 at 04:25:54PM -0700, Nadav Amit wrote: > [cc’ing IOMMU people, which for some reason are not cc’d] > > Andrea Arcangeli wrote: > > > On Wed, Aug 30, 2017 at 11:00:32AM -0700, Nadav Amit wrote: > >> It is not trivial to flush TLBs (primary or secondary) without holding the >

Re: [PATCH 00/13] mmu_notifier kill invalidate_page callback

2017-08-29 Thread Jerome Glisse
On Tue, Aug 29, 2017 at 05:11:24PM -0700, Linus Torvalds wrote: > On Tue, Aug 29, 2017 at 4:54 PM, Jérôme Glisse wrote: > > > > Note this is barely tested. I intend to do more testing of next few days > > but i do not have access to all hardware that make use of the mmu_notifier > > API. > > Than

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-02 Thread Jerome Glisse
On Wed, Aug 02, 2017 at 08:18:02PM +0200, Christian König wrote: > Am 02.08.2017 um 19:33 schrieb Jerome Glisse: > > On Wed, Aug 02, 2017 at 07:23:58PM +0200, Christian König wrote: > > > Am 02.08.2017 um 19:13 schrieb Jerome Glisse: > > > > On Wed, Aug 02, 2017

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-02 Thread Jerome Glisse
On Wed, Aug 02, 2017 at 07:23:58PM +0200, Christian König wrote: > Am 02.08.2017 um 19:13 schrieb Jerome Glisse: > > On Wed, Aug 02, 2017 at 07:05:11PM +0200, Christian König wrote: > > > Am 02.08.2017 um 18:43 schrieb Jerome Glisse: > > > > On Wed, Aug 02, 2017

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-02 Thread Jerome Glisse
On Wed, Aug 02, 2017 at 07:05:11PM +0200, Christian König wrote: > Am 02.08.2017 um 18:43 schrieb Jerome Glisse: > > On Wed, Aug 02, 2017 at 10:26:40AM +0200, Christian König wrote: > > > [SNIP] > > So to summarize you are saying you do not trust the value you g

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-02 Thread Jerome Glisse
On Wed, Aug 02, 2017 at 10:26:40AM +0200, Christian König wrote: > Hi Jerome, > > sorry for being a bit late to the discussion and the top posting. > > But I think you miss a very important point here, which makes the whole > discussion on how to implement completely superfluous: > > We already

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-01 Thread Jerome Glisse
On Tue, Aug 01, 2017 at 05:38:05PM -0400, Tom St Denis wrote: > On 01/08/17 05:01 PM, Jerome Glisse wrote: > > > Unless you can nop that in a config invariant fashion (like you can for > > > tracers) that's a NAK from the get go. And we'd need to buffer them to be

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-01 Thread Jerome Glisse
On Tue, Aug 01, 2017 at 04:26:38PM -0400, Tom St Denis wrote: > Was trying to walk away from this ... :-) (all in good fun). > > > On 01/08/17 03:55 PM, Jerome Glisse wrote: > > On Tue, Aug 01, 2017 at 03:28:26PM -0400, Tom St Denis wrote: > > > Adding the AMDG

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-01 Thread Jerome Glisse
On Tue, Aug 01, 2017 at 03:28:26PM -0400, Tom St Denis wrote: > Adding the AMDGPU maintainers to get their opinions. > > Context: > https://lists.linuxfoundation.org/pipermail/iommu/2017-August/023489.html > > (and others in case you missed it on the list). > > > O

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-01 Thread Jerome Glisse
On Tue, Aug 01, 2017 at 02:25:02PM -0400, Tom St Denis wrote: > On 01/08/17 02:04 PM, Jerome Glisse wrote: > > On Tue, Aug 01, 2017 at 01:32:35PM -0400, Tom St Denis wrote: > > > On 01/08/17 01:25 PM, Jerome Glisse wrote: > > > > On Tue, Aug 01, 2017 at 06:07:

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-01 Thread Jerome Glisse
On Tue, Aug 01, 2017 at 01:32:35PM -0400, Tom St Denis wrote: > On 01/08/17 01:25 PM, Jerome Glisse wrote: > > On Tue, Aug 01, 2017 at 06:07:48AM -0400, Tom St Denis wrote: > > > Hi, > > > > > > We're working on a user space debugger for AMDGPU devices an

Re: Feature Request: Ability to decode bus/dma address back into physical address

2017-08-01 Thread Jerome Glisse
On Tue, Aug 01, 2017 at 06:07:48AM -0400, Tom St Denis wrote: > Hi, > > We're working on a user space debugger for AMDGPU devices and are trying to > figure out a "proper" way of taking mapped pages and converting them back to > physical addresses so the debugger can read memory that was sent to t

Re: What differences and relations between SVM, HSA, HMM and Unified Memory?

2017-07-17 Thread Jerome Glisse
On Mon, Jul 17, 2017 at 07:57:23PM +0800, Yisheng Xie wrote: > Hi Jean-Philippe, > > On 2017/6/12 19:37, Jean-Philippe Brucker wrote: > > Hello, > > > > On 10/06/17 05:06, Wuzongyong (Cordius Wu, Euler Dept) wrote: > >> Hi, > >> > >> Could someone explain differences and relations between the SVM

Re: Support SVM without PASID

2017-07-10 Thread Jerome Glisse
On Sun, Jul 09, 2017 at 08:45:57AM +0530, valmiki wrote: > > > Hi, > > > > > > In SMMUv3 architecture document i see "PASIDs are optional, > > > configurable, and of a size determined by the minimum > > > of the endpoint". > > > > > > So if PASID's are optional and not supported by PCIe end point

Re: What differences and relations between SVM, HSA, HMM and Unified Memory?

2017-06-12 Thread Jerome Glisse
On Sat, Jun 10, 2017 at 04:06:28AM +, Wuzongyong (Cordius Wu, Euler Dept) wrote: > Hi, > > Could someone explain differences and relations between the SVM > (Shared Virtual Memory, by Intel), HSA(Heterogeneous System > Architecture, by AMD), HMM(Heterogeneous Memory Management, by Glisse) > a

Re: [PATCH] iommu/amd: Fix amd_iommu_detect() (does not fix any issues).

2015-10-26 Thread Jerome Glisse
On Tue, Oct 27, 2015 at 09:47:48AM +0900, Jerome Glisse wrote: > On Mon, Oct 26, 2015 at 12:07:17PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Aug 31, 2015 at 06:13:03PM -0400, j.gli...@gmail.com wrote: > > > From: Jérôme Glisse > > > > > > Fix amd_iommu_

Re: [PATCH] iommu/amd: Fix amd_iommu_detect() (does not fix any issues).

2015-10-26 Thread Jerome Glisse
On Mon, Oct 26, 2015 at 12:07:17PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Aug 31, 2015 at 06:13:03PM -0400, j.gli...@gmail.com wrote: > > From: Jérôme Glisse > > > > Fix amd_iommu_detect() to return positive value on success, like > > intended, and not zero. This will not change anything i

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

2015-10-12 Thread Jerome Glisse
-07-08 at 13:03 -0400, Jerome Glisse wrote: > > > > Now regarding the device side, if we were to cleanup inside the file release > > callback than we would be broken in front of fork. Imagine the following : > > - process A open device file and mirror its address space (hm

Re: [RFC PATCH] dma/swiotlb: Add helper for device driver to opt-out from swiotlb.

2015-09-22 Thread Jerome Glisse
On Thu, Sep 17, 2015 at 03:31:58PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 17, 2015 at 03:07:47PM -0400, Jerome Glisse wrote: > > On Thu, Sep 17, 2015 at 03:02:51PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Thu, Sep 17, 2015 at 02:22:38PM -0400, jgli...@redhat.com w

Re: [RFC PATCH] dma/swiotlb: Add helper for device driver to opt-out from swiotlb.

2015-09-17 Thread Jerome Glisse
On Thu, Sep 17, 2015 at 03:31:58PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 17, 2015 at 03:07:47PM -0400, Jerome Glisse wrote: > > On Thu, Sep 17, 2015 at 03:02:51PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Thu, Sep 17, 2015 at 02:22:38PM -0400, jgli...@redhat.com w

Re: [RFC PATCH] dma/swiotlb: Add helper for device driver to opt-out from swiotlb.

2015-09-17 Thread Jerome Glisse
On Thu, Sep 17, 2015 at 03:24:25PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 17, 2015 at 03:11:14PM -0400, Jerome Glisse wrote: > > On Thu, Sep 17, 2015 at 03:06:57PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Thu, Sep 17, 2015 at 03:02:51PM -0400, Konrad Rzeszutek Wilk

Re: [RFC PATCH] dma/swiotlb: Add helper for device driver to opt-out from swiotlb.

2015-09-17 Thread Jerome Glisse
On Thu, Sep 17, 2015 at 03:06:57PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 17, 2015 at 03:02:51PM -0400, Konrad Rzeszutek Wilk wrote: > > On Thu, Sep 17, 2015 at 02:22:38PM -0400, jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > > > The swiotlb dma backend is not appropriate

Re: [RFC PATCH] dma/swiotlb: Add helper for device driver to opt-out from swiotlb.

2015-09-17 Thread Jerome Glisse
On Thu, Sep 17, 2015 at 03:02:51PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 17, 2015 at 02:22:38PM -0400, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > The swiotlb dma backend is not appropriate for some devices like > > GPU where bounce buffer or slow dma page allocations is

Re: [PATCH 0/6] IOMMU/DMA map_resource support for peer-to-peer

2015-05-07 Thread Jerome Glisse
is; Joerg Roedel; open list:INTEL IOMMU (VT-d); linux- > >> p...@vger.kernel.org; Terence Ripperda; John Hubbard; Jerome Glisse; Dave > >> Jiang; David S. Miller; Alex Williamson > >> Subject: Re: [PATCH 0/6] IOMMU/DMA map_resource support for peer-to-peer > >> >

Re: IOMMU and domain binding/unbinding logic

2015-03-26 Thread Jerome Glisse
On Thu, Mar 26, 2015 at 06:09:35PM +0100, Joerg Roedel wrote: > Hi Jerome, > > On Thu, Mar 26, 2015 at 12:50:47PM -0400, Jerome Glisse wrote: > > So how comes it still looks like it is working properly ? My best guest > > it is because it is by default in passthrough, but i

IOMMU and domain binding/unbinding logic

2015-03-26 Thread Jerome Glisse
Hi, I was looking at IOMMUv2 and AMD APU kfd driver registration and initialization (drivers/gpu/drm/amd/amdkfd/kfd_device.c). I am left puzzle with 2 things. General IOMMU question, my understanding is that each device is associated with one domain only (ignoring device that have several alias i

Re: [PATCH 0/3 v3] mmu_notifier: Allow to manage CPU external TLBs

2014-09-12 Thread Jerome Glisse
On Fri, Sep 12, 2014 at 12:19:37PM -0700, Andrew Morton wrote: > On Fri, 12 Sep 2014 20:47:39 +0200 Joerg Roedel wrote: > > > thanks for your review, I tried to answer your questions below. > > You'd be amazed how helpful that was ;) > > > Fair enough, I hope I clarified a few things with my ex

Re: [PATCH 0/3 v3] mmu_notifier: Allow to manage CPU external TLBs

2014-09-12 Thread Jerome Glisse
On Fri, Sep 12, 2014 at 12:10:36PM -0700, Andrew Morton wrote: > On Wed, 10 Sep 2014 20:02:12 -0400 Jerome Glisse wrote: > > > On Wed, Sep 10, 2014 at 03:01:25PM -0700, Andrew Morton wrote: > > > On Tue, 9 Sep 2014 17:43:51 +0200 Joerg Roedel wrote: > > > > &g

Re: [PATCH 0/3 v3] mmu_notifier: Allow to manage CPU external TLBs

2014-09-12 Thread Jerome Glisse
On Wed, Sep 10, 2014 at 08:02:12PM -0400, Jerome Glisse wrote: > On Wed, Sep 10, 2014 at 03:01:25PM -0700, Andrew Morton wrote: > > On Tue, 9 Sep 2014 17:43:51 +0200 Joerg Roedel wrote: > > > > > here is a patch-set to extend the mmu_notifiers in the Linux > >

Re: [PATCH 0/3 v3] mmu_notifier: Allow to manage CPU external TLBs

2014-09-10 Thread Jerome Glisse
On Wed, Sep 10, 2014 at 03:01:25PM -0700, Andrew Morton wrote: > On Tue, 9 Sep 2014 17:43:51 +0200 Joerg Roedel wrote: > > > here is a patch-set to extend the mmu_notifiers in the Linux > > kernel to allow managing CPU external TLBs. Those TLBs may > > be implemented in IOMMUs or any other exter

Re: [PATCH 0/3 v2] mmu_notifier: Allow to manage CPU external TLBs

2014-07-31 Thread Jerome Glisse
On Tue, Jul 29, 2014 at 06:18:10PM +0200, Joerg Roedel wrote: > Changes V1->V2: > > * Rebase to v3.16-rc7 > * Added call of ->invalidate_range to > __mmu_notifier_invalidate_end() so that the subsystem > doesn't need to register an ->invalidate_end() call-back, > subsystems will likely eithe

Re: [PATCH 1/3] mmu_notifier: Add mmu_notifier_invalidate_range()

2014-07-25 Thread Jerome Glisse
On Fri, Jul 25, 2014 at 11:38:06PM +0200, Joerg Roedel wrote: > On Fri, Jul 25, 2014 at 01:16:39PM -0700, Jesse Barnes wrote: > > > To allow managing external TLBs the MMU-notifiers need to > > > catch the moment when pages are unmapped but not yet freed. > > > This new notifier catches that moment

Re: [PATCH 1/3] mmu_notifier: Add mmu_notifier_invalidate_range()

2014-07-25 Thread Jerome Glisse
On Fri, Jul 25, 2014 at 01:16:39PM -0700, Jesse Barnes wrote: > On Thu, 24 Jul 2014 16:35:39 +0200 > Joerg Roedel wrote: > > > From: Joerg Roedel > > > > This notifier closes an important gap with the current > > invalidate_range_start()/end() notifiers. The _start() part > > is called when all

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

2014-07-08 Thread Jerome Glisse
On Tue, Jul 08, 2014 at 10:00:59AM +0200, j...@8bytes.org wrote: > On Mon, Jul 07, 2014 at 01:43:03PM +0300, Oded Gabbay wrote: > > As Jerome pointed out, there are a couple of subsystems/drivers who > > don't rely on file descriptors but on the tear-down of mm struct, e.g. > > aio, ksm, uprobes, k

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

2014-07-03 Thread Jerome Glisse
On Fri, Jul 04, 2014 at 01:15:41AM +0200, Joerg Roedel wrote: > Hi Jerome, > > On Thu, Jul 03, 2014 at 02:30:26PM -0400, Jerome Glisse wrote: > > Joerg do you still object to this patch ? > > Yes. > > > Again the natural place to call this is from mmput an

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

2014-07-03 Thread Jerome Glisse
On Tue, Jul 01, 2014 at 05:32:09PM -0400, Jerome Glisse wrote: > On Tue, Jul 01, 2014 at 11:06:20PM +0200, Joerg Roedel wrote: > > On Tue, Jul 01, 2014 at 03:33:44PM -0400, Jerome Glisse wrote: > > > On Tue, Jul 01, 2014 at 01:00:18PM +0200, Joerg Roedel wrote: > > >

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

2014-07-01 Thread Jerome Glisse
On Tue, Jul 01, 2014 at 11:06:20PM +0200, Joerg Roedel wrote: > On Tue, Jul 01, 2014 at 03:33:44PM -0400, Jerome Glisse wrote: > > On Tue, Jul 01, 2014 at 01:00:18PM +0200, Joerg Roedel wrote: > > > No, its not in this case. The file descriptor is used to connect a > > >

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

2014-07-01 Thread Jerome Glisse
On Tue, Jul 01, 2014 at 01:00:18PM +0200, Joerg Roedel wrote: > On Tue, Jul 01, 2014 at 09:29:49AM +, Gabbay, Oded wrote: > > In the KFD, we need to maintain a notion of each compute process. > > Therefore, we have an object called "kfd_process" that is created for > > each process that uses th

Re: [PATCH 1/6] mmput: use notifier chain to call subsystem exit handler.

2014-06-30 Thread Jerome Glisse
On Mon, Jun 30, 2014 at 08:16:23PM +0200, Joerg Roedel wrote: > On Mon, Jun 30, 2014 at 12:06:05PM -0400, Jerome Glisse wrote: > > No this patch does not duplicate it. Current user of mmu_notifier > > rely on file close code path to call mmu_notifier_unregister. New > > cod

  1   2   >