Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-05-27 Thread Kirti Wankhede
On 5/27/2021 10:30 AM, David Gibson wrote: On Wed, May 26, 2021 at 02:48:03AM +0530, Kirti Wankhede wrote: On 5/26/2021 1:22 AM, Jason Gunthorpe wrote: On Wed, May 26, 2021 at 12:56:30AM +0530, Kirti Wankhede wrote: 2. iommu backed mdev devices for SRIOV where mdev device is created per

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-05-26 Thread Kirti Wankhede
On 5/26/2021 4:22 AM, Alex Williamson wrote: On Wed, 26 May 2021 00:56:30 +0530 Kirti Wankhede wrote: On 5/25/2021 5:07 AM, Jason Gunthorpe wrote: On Mon, May 24, 2021 at 05:52:58PM +1000, David Gibson wrote: I don't really see a semantic distinction between "always one-device g

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-05-25 Thread Kirti Wankhede
On 5/26/2021 1:22 AM, Jason Gunthorpe wrote: On Wed, May 26, 2021 at 12:56:30AM +0530, Kirti Wankhede wrote: 2. iommu backed mdev devices for SRIOV where mdev device is created per VF (mdev device == VF device) then that mdev device has same iommu protection scope as VF associated

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-05-25 Thread Kirti Wankhede
On 5/25/2021 5:07 AM, Jason Gunthorpe wrote: On Mon, May 24, 2021 at 05:52:58PM +1000, David Gibson wrote: I don't really see a semantic distinction between "always one-device groups" and "groups don't matter". Really the only way you can afford to not care about groups is if they're

Re: [PATCH 1/5] vfio/iommu_type1: Fixes vfio_dma_populate_bitmap to avoid dirty lose

2021-01-13 Thread Kirti Wankhede
On 1/13/2021 2:50 AM, Alex Williamson wrote: On Thu, 7 Jan 2021 17:28:57 +0800 Keqian Zhu wrote: Defer checking whether vfio_dma is of fully-dirty in update_user_bitmap is easy to lose dirty log. For example, after promoting pinned_scope of vfio_iommu, vfio_dma is not considered as

Re: [PATCH v7 8/9] vfio/type1: Add domain at(de)taching group helpers

2019-03-26 Thread Kirti Wankhede
d-off-by: Liu Yi L > Signed-off-by: Lu Baolu > Reviewed-by: Jean-Philippe Brucker Reviewed-by: Kirti Wankhede Thanks, Kirti > --- > drivers/vfio/vfio_iommu_type1.c | 84 ++--- > 1 file changed, 77 insertions(+), 7 deletions(-) > > diff --git a

Re: [PATCH v8 7/9] vfio/mdev: Add iommu related member in mdev_device

2019-03-26 Thread Kirti Wankhede
t; + * @iommu_device: a pci device which represents the iommu for @dev. > + * > + * Return 0 for success, otherwise negative error value. > + */ > +int mdev_set_iommu_device(struct device *dev, struct device *iommu_device); > + > +struct device *mdev_get_iommu_device(struct device *dev); > + &

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-12-03 Thread Kirti Wankhede
On 11/21/2018 2:15 PM, Christoph Hellwig wrote: > On Wed, Nov 21, 2018 at 02:22:08AM +0530, Kirti Wankhede wrote: >> It is about how mdev framework can be used by existing drivers. These >> symbols doesn't use any other exported symbols. > > That is an unfortunat

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-20 Thread Kirti Wankhede
On 11/16/2018 2:27 PM, Christoph Hellwig wrote: > On Fri, Nov 16, 2018 at 09:20:48AM +0800, Lu Baolu wrote: >>> Please keep symbols mdev_set/get_iommu_device(dev, iommu_device) non-GPL >>> same as other exported symbols from mdev_core module. >> >> Yes. It will be fixed in the next version. >

Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device

2018-11-15 Thread Kirti Wankhede
On 11/7/2018 7:18 AM, Lu Baolu wrote: > Hi Alex, > > On 11/7/18 7:53 AM, Alex Williamson wrote: >> On Mon,  5 Nov 2018 15:34:06 +0800 >> Lu Baolu wrote: >> >>> A parent device might create different types of mediated >>> devices. For example, a mediated device could be created >>> by the