Re: [PATCH 1/5] iommu/tegra-smmu: Fix domain_alloc

2019-01-24 Thread navneet kumar
Thanks for the feedback, Robin, and, Dmitry. I mostly agree with all your comments, pls see my responses inline. I'll make these fixes in V2. On 1/17/19 8:50 AM, Robin Murphy wrote: > On 17/01/2019 15:13, Dmitry Osipenko wrote: >> 16.01.2019 23:50, Navneet Kumar пишет: >>> *

Re: [PATCH 2/5] iommu/tegra-smmu: Use non-secure register for flushing

2019-01-24 Thread navneet kumar
On 1/17/19 7:25 AM, Dmitry Osipenko wrote: > 16.01.2019 23:50, Navneet Kumar пишет: >> Use PTB_ASID instead of SMMU_CONFIG to flush smmu. >> PTB_ASID can be accessed from non-secure mode, SMMU_CONFIG cannot be. >> Using SMMU_CONFIG could pose a problem when kernel doesn'

[PATCH 3/5] iommu/tegra-smmu: Fix client enablement order

2019-01-16 Thread Navneet Kumar
Enable clients' translation only after setting up the swgroups. Signed-off-by: Navneet Kumar --- drivers/iommu/tegra-smmu.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index fa175d9..1a44cf6

[PATCH 5/5] iommu/tegra-smmu: Add resv_regions ops

2019-01-16 Thread Navneet Kumar
Add support for get/put reserved regions. Signed-off-by: Navneet Kumar --- drivers/iommu/tegra-smmu.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 4b43c63..e848a45 100644 --- a/drivers/iommu

[PATCH 2/5] iommu/tegra-smmu: Use non-secure register for flushing

2019-01-16 Thread Navneet Kumar
Use PTB_ASID instead of SMMU_CONFIG to flush smmu. PTB_ASID can be accessed from non-secure mode, SMMU_CONFIG cannot be. Using SMMU_CONFIG could pose a problem when kernel doesn't have secure mode access enabled from boot. Signed-off-by: Navneet Kumar --- drivers/iommu/tegra-smmu.c | 2 +- 1

[PATCH 4/5] iommu/tegra-smmu: Add PCI support

2019-01-16 Thread Navneet Kumar
Add support for PCI devices. Signed-off-by: Navneet Kumar --- drivers/iommu/tegra-smmu.c | 47 +- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index 1a44cf6..4b43c63 100644

[PATCH 1/5] iommu/tegra-smmu: Fix domain_alloc

2019-01-16 Thread Navneet Kumar
* Allocate dma iova cookie for a domain while adding dma iommu devices. * Perform a stricter check for domain type parameter. Signed-off-by: Navneet Kumar --- drivers/iommu/tegra-smmu.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions(-) diff