Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges

2021-01-27 Thread Paul Kocialkowski
es: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting > dma_pfn_offset"), > Suggested-by: Robin Murphy > Signed-off-by: Yong Wu > Signed-off-by: Paul Kocialkowski > Reviewed-by: Rob Herring > --- > drivers/of/device.c | 10 +++--- > 1 file changed, 7

Re: [PATCH v6 06/33] of/device: Move dma_range_map before of_iommu_configure

2021-01-19 Thread Paul Kocialkowski
nges, this looks good to me! Thanks, Paul > > > > Robin. > > > > [1] > > https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ce...@arm.com/ > > > > >> > > >>> return -EPROBE_DEFER; > > >>> } > > >>> > > >>> @@ -181,7 +183,6 @@ int of_dma_configure_id(struct device *dev, struct > > >>> device_node *np, > > >>> > > >>> arch_setup_dma_ops(dev, dma_start, size, iommu, coherent); > > >>> > > >>> - dev->dma_range_map = map; > > >>> return 0; > > >>> } > > >>> EXPORT_SYMBOL_GPL(of_dma_configure_id); > > >>> -- > > >>> 2.18.0 > > >>> > > > > > > ___ > > > iommu mailing list > > > iommu@lists.linux-foundation.org > > > https://lists.linuxfoundation.org/mailman/listinfo/iommu > > > > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v6 06/33] of/device: Move dma_range_map before of_iommu_configure

2021-01-19 Thread Paul Kocialkowski
> https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ce...@arm.com/ > > > > > > > > return -EPROBE_DEFER; > > > > } > > > > @@ -181,7 +183,6 @@ int of_dma_configure_id(struct device *dev, struct > > > > device_nod

Re: [PATCH v4 5/5] drm/sun4i: mixer: Call of_dma_configure if there's an IOMMU

2020-05-15 Thread Paul Kocialkowski
e DRM > virtual device to configure it in the same way than the mixers. Although I'm not very familiar with the DMA API, this looks legit to me and matches what's already done in sun4i_backend for the interconnect. So: Reviewed-by: Paul Kocialkowski Cheers, Paul > Signed-off-by: Maxime Ripard