Re: [PATCH 1/1] iommu/vt-d: Fix build error of pasid_enable_wpe() with !X86

2021-04-11 Thread Randy Dunlap
) __builtin_expect(!!(x), 0) > | > > Add the missing dependency. > > Cc: Sanjay Kumar > Cc: Jacob Pan > Cc: Randy Dunlap > Reported-by: kernel test robot > Reported-by: Randy Dunlap > Fixes: f68c7f539b6e9 ("iommu/vt-d: Enable write protect for supervi

Re: linux-next: Tree for Apr 9 (drivers/iommu/intel/pasid.c)

2021-04-10 Thread Randy Dunlap
ely(!(cr0 & X86_CR0_WP))) { | ^~ ../include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ -- ~Randy

Re: [PATCH v3 2/2] iommu: add Unisoc iommu basic driver

2021-02-03 Thread Randy Dunlap
On 2/3/21 1:07 AM, Chunyan Zhang wrote: > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > index 192ef8f61310..99e7712f3903 100644 > --- a/drivers/iommu/Kconfig > +++ b/drivers/iommu/Kconfig > @@ -408,4 +408,16 @@ config VIRTIO_IOMMU > > Say Y here if you intend to run this

Re: [PATCH 1/1] iommu/vt-d: Fix compile error [-Werror=implicit-function-declaration]

2021-01-30 Thread Randy Dunlap
("iommu/vt-d: Add qi_submit trace event") > Reported-by: kernel test robot > Reported-by: Randy Dunlap > Signed-off-by: Lu Baolu > --- > drivers/iommu/intel/Makefile | 2 +- > drivers/iommu/intel/iommu.c| 1 - > include/trace/events/intel_iommu.h | 2

linux-next-20210129: drivers/iommu/intel/dmar.c

2021-01-29 Thread Randy Dunlap
, ^~~ ftrace_nmi_exit Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap config-r7511.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman

Re: [PATCH 01/13] x86: Secure Launch Kconfig

2020-09-24 Thread Randy Dunlap
On 9/24/20 7:58 AM, Ross Philipson wrote: > Initial bits to bring in Secure Launch functionality. Add Kconfig > options for compiling in/out the Secure Launch code. > > Signed-off-by: Ross Philipson Hi, from Documentation/process/coding-style.rst: Lines under a ``config`` definition are

Re: [PATCH v9 1/7] docs: IOMMU user API

2020-09-16 Thread Randy Dunlap
On 9/11/20 2:57 PM, Jacob Pan wrote: > IOMMU UAPI is newly introduced to support communications between guest > virtual IOMMU and host IOMMU. There has been lots of discussions on how > it should work with VFIO UAPI and userspace in general. > > This document is intended to clarify the UAPI

Re: [PATCH v7 3/9] docs: x86: Add documentation for SVA (Shared Virtual Addressing)

2020-09-05 Thread Randy Dunlap
Hi, I'll add a few edits other than those that Borislav made. (nice review job, BP) On 8/27/20 8:06 AM, Fenghua Yu wrote: > From: Ashok Raj > > ENQCMD and Data Streaming Accelerator (DSA) and all of their associated > features are a complicated stack with lots of interconnected pieces. > This

Re: [PATCH v2 3/9] iommu/ioasid: Introduce ioasid_set APIs

2020-08-24 Thread Randy Dunlap
On 8/24/20 11:28 AM, Jean-Philippe Brucker wrote: >> +/** >> + * struct ioasid_set - Meta data about ioasid_set >> + * @type: Token types and other features > nit: doesn't follow struct order > >> + * @token: Unique to identify an IOASID set >> + * @xa: XArray to store ioasid_set

Re: [PATCH v2 3/9] iommu/ioasid: Introduce ioasid_set APIs

2020-08-24 Thread Randy Dunlap
On 8/24/20 11:28 AM, Jean-Philippe Brucker wrote: >> +/** >> + * struct ioasid_data - Meta data about ioasid >> + * >> + * @id: Unique ID >> + * @users Number of active users >> + * @state Track state of the IOASID >> + * @set Meta data of the set this IOASID belongs to

Re: [PATCH v7 1/3] dma-contiguous: provide the ability to reserve per-numa CMA

2020-08-21 Thread Randy Dunlap
On 8/21/20 4:33 AM, Barry Song wrote: > --- > -v7: with respect to Will's comments > * move to use for_each_online_node > * add description if users don't specify pernuma_cma > * provide default value for CONFIG_DMA_PERNUMA_CMA > > .../admin-guide/kernel-parameters.txt | 11 ++ >

Re: [PATCH v6 1/2] dma-contiguous: provide the ability to reserve per-numa CMA

2020-08-20 Thread Randy Dunlap
On 8/20/20 7:26 PM, Barry Song wrote: > > > Cc: Jonathan Cameron > Cc: Christoph Hellwig > Cc: Marek Szyprowski > Cc: Will Deacon > Cc: Robin Murphy > Cc: Ganapatrao Kulkarni > Cc: Catalin Marinas > Cc: Nicolas Saenz Julienne > Cc: Steve Capper > Cc: Andrew Morton > Cc: Mike Rapoport

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-08 Thread Randy Dunlap
On 4/8/20 8:36 AM, Christoph Hellwig wrote: > On Wed, Apr 08, 2020 at 08:15:19AM -0700, Matthew Wilcox wrote: > config ZSMALLOC_PGTABLE_MAPPING > bool "Use page table mapping to access object in zsmalloc" > - depends on ZSMALLOC > + depends on ZSMALLOC=y It's a bool so

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-08 Thread Randy Dunlap
On 4/8/20 8:15 AM, Matthew Wilcox wrote: > On Wed, Apr 08, 2020 at 05:12:03PM +0200, Peter Zijlstra wrote: >> On Wed, Apr 08, 2020 at 08:01:00AM -0700, Randy Dunlap wrote: >>> Hi, >>> >>> On 4/8/20 4:59 AM, Christoph Hellwig wrote: >>>> diff --git a

Re: [PATCH 10/28] mm: only allow page table mappings for built-in zsmalloc

2020-04-08 Thread Randy Dunlap
Hi, On 4/8/20 4:59 AM, Christoph Hellwig wrote: > diff --git a/mm/Kconfig b/mm/Kconfig > index 36949a9425b8..614cc786b519 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -702,7 +702,7 @@ config ZSMALLOC > > config ZSMALLOC_PGTABLE_MAPPING > bool "Use page table mapping to access object

Re: [PATCH 09/28] mm: rename CONFIG_PGTABLE_MAPPING to CONFIG_ZSMALLOC_PGTABLE_MAPPING

2020-04-08 Thread Randy Dunlap
2 +- > mm/zsmalloc.c| 8 > 4 files changed, 7 insertions(+), 7 deletions(-) > Looks good. Thanks. Acked-by: Randy Dunlap -- ~Randy ___ iommu mailing list iommu@lists.linux-foundation.org https://lis

Re: [PATCH] dma-mapping: mark dma_alloc_need_uncached as __always_inline

2019-07-08 Thread Randy Dunlap
On 7/8/19 12:57 PM, Christoph Hellwig wrote: > Without the __always_inline at least i386 configs that have > CONFIG_OPTIMIZE_INLINING set seem fail to inline > dma_alloc_need_uncached, leading to a linker error because of > undefined symbols. > > Reported-by: Randy Du

Re: linux-next: Tree for Jul 5 (dma)

2019-07-05 Thread Randy Dunlap
On 7/5/19 3:30 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190704: > on i386: ld: kernel/dma/direct.o: in function `dma_direct_alloc': direct.c:(.text+0x1658): undefined reference to `arch_dma_alloc' ld: kernel/dma/direct.o: in function `dma_direct_free': direct.c:(.text+0x1704):

Re: [RFC PATCH v3 11/21] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2019-05-14 Thread Randy Dunlap
On 5/14/19 7:02 AM, Ricardo Neri wrote: > diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug > index 15d0fbe27872..376a5db81aec 100644 > --- a/arch/x86/Kconfig.debug > +++ b/arch/x86/Kconfig.debug > @@ -169,6 +169,17 @@ config IOMMU_LEAK > config HAVE_MMIOTRACE_SUPPORT > def_bool

Re: [RFC PATCH v3 04/21] x86/hpet: Add hpet_set_comparator() for periodic and one-shot modes

2019-05-14 Thread Randy Dunlap
On 5/14/19 7:01 AM, Ricardo Neri wrote: > Instead of setting the timer period directly in hpet_set_periodic(), add a > new helper function hpet_set_comparator() that only sets the accumulator > and comparator. hpet_set_periodic() will only prepare the timer for > periodic mode and leave the

Re: [RFC PATCH v3 03/21] x86/hpet: Calculate ticks-per-second in a separate function

2019-05-14 Thread Randy Dunlap
On 5/14/19 7:01 AM, Ricardo Neri wrote: > It is easier to compute the expiration times of an HPET timer by using > its frequency (i.e., the number of times it ticks in a second) than its > period, as given in the capabilities register. > > In addition to the HPET char driver, the HPET-based

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-16 Thread Randy Dunlap
On 11/16/18 12:15 AM, Souptick Joarder wrote: > On Fri, Nov 16, 2018 at 12:11 PM Matthew Wilcox wrote: >> >> On Fri, Nov 16, 2018 at 11:00:30AM +0530, Souptick Joarder wrote: >>> On Thu, Nov 15, 2018 at 11:44 PM Randy Dunlap wrote: >>>> On 11/15/18 7:45 A

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-15 Thread Randy Dunlap
On 11/15/18 7:45 AM, Souptick Joarder wrote: > Previouly drivers have their own way of mapping range of > kernel pages/memory into user vma and this was done by > invoking vm_insert_page() within a loop. > > As this pattern is common across different drivers, it can > be generalized by creating a

Re: [PATCH] dma-direct: document the zone selection logic

2018-10-01 Thread Randy Dunlap
On 10/1/18 1:10 PM, Christoph Hellwig wrote: > What we are doing here isn't quite obvious, so add a comment explaining > it. > > Signed-off-by: Christoph Hellwig > --- > kernel/dma/direct.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/kernel/dma/direct.c

Re: [PATCH 1/7] vfio/sdmdev: Add documents for WarpDrive framework

2018-09-06 Thread Randy Dunlap
Hi, On 09/02/2018 05:51 PM, Kenneth Lee wrote: > From: Kenneth Lee > > WarpDrive is a common user space accelerator framework. Its main component > in Kernel is called sdmdev, Share Domain Mediated Device. It exposes > the hardware capabilities to the user space via vfio-mdev. So processes in

Re: [PATCH 7/7] vfio/sdmdev: add user sample

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > From: Kenneth Lee > > This is the sample code to demostrate how WrapDrive user application > should be. > > It contains: > > 1. wd.[ch], the common library to provide WrapDrive interface. WarpDrive > 2.

Re: [PATCH 6/7] crypto: add sdmdev support to Hisilicon QM

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > diff --git a/drivers/crypto/hisilicon/Kconfig > b/drivers/crypto/hisilicon/Kconfig > index 1d155708cd69..b85fab48fdab 100644 > --- a/drivers/crypto/hisilicon/Kconfig > +++ b/drivers/crypto/hisilicon/Kconfig > @@ -17,6 +17,16 @@ config

Re: [PATCH 4/7] crypto: add hisilicon Queue Manager driver

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > diff --git a/drivers/crypto/hisilicon/Kconfig > b/drivers/crypto/hisilicon/Kconfig > index 8ca9c503bcb0..02a6eef84101 100644 > --- a/drivers/crypto/hisilicon/Kconfig > +++ b/drivers/crypto/hisilicon/Kconfig > @@ -1,4 +1,8 @@ > #

Re: [PATCH 3/7] vfio: add sdmdev support

2018-09-02 Thread Randy Dunlap
On 09/02/2018 05:52 PM, Kenneth Lee wrote: > diff --git a/drivers/vfio/sdmdev/Kconfig b/drivers/vfio/sdmdev/Kconfig > new file mode 100644 > index ..51474272870d > --- /dev/null > +++ b/drivers/vfio/sdmdev/Kconfig > @@ -0,0 +1,10 @@ > +# SPDX-License-Identifier: GPL-2.0 > +config

Re: [RFC PATCH 11/11] powerpc/svm: Increase SWIOTLB buffer size

2018-08-24 Thread Randy Dunlap
On 08/24/2018 09:25 AM, Thiago Jung Bauermann wrote: > From: Anshuman Khandual > > SWIOTLB buffer default size (64MB) is not enough for large sequential write > operations which eventually leads to kernel crash like here. > > virtio-pci :00:05.0: swiotlb buffer is full (sz: 327680 bytes) >

Re: [RFC PATCH 3/7] vfio: add spimdev support

2018-08-01 Thread Randy Dunlap
On 08/01/2018 03:22 AM, Kenneth Lee wrote: > From: Kenneth Lee > > SPIMDEV is "Share Parent IOMMU Mdev". It is a vfio-mdev. But differ from > the general vfio-mdev: > > 1. It shares its parent's IOMMU. > 2. There is no hardware resource attached to the mdev is created. The > hardware resource

Re: [PATCH v9 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-06-14 Thread Randy Dunlap
On 06/12/2018 02:41 PM, Gary R Hook wrote: > Implement a skeleton framework for debugfs support in the AMD > IOMMU. Add an AMD-specific Kconfig boolean that depends upon > general enablement of DebugFS in the IOMMU. > > Signed-off-by: Gary R Hook Gary, Looks good to me. Thanks. > --- >

Re: [RFC PATCH 22/23] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter

2018-06-13 Thread Randy Dunlap
On 06/13/2018 05:58 PM, Ricardo Neri wrote: > On Tue, Jun 12, 2018 at 10:26:57PM -0700, Randy Dunlap wrote: >> On 06/12/2018 05:57 PM, Ricardo Neri wrote: >>> diff --git a/Documentation/admin-guide/kernel-parameters.txt >>> b/Documentation/admin-guide/kernel-param

Re: [RFC PATCH 22/23] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter

2018-06-12 Thread Randy Dunlap
On 06/12/2018 05:57 PM, Ricardo Neri wrote: > diff --git a/Documentation/admin-guide/kernel-parameters.txt > b/Documentation/admin-guide/kernel-parameters.txt > index f2040d4..a8833c7 100644 > --- a/Documentation/admin-guide/kernel-parameters.txt > +++

Re: [RFC PATCH 16/23] watchdog/hardlockup: Add an HPET-based hardlockup detector

2018-06-12 Thread Randy Dunlap
Hi, On 06/12/2018 05:57 PM, Ricardo Neri wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c40c7b7..6e79833 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -828,6 +828,16 @@ config HARDLOCKUP_DETECTOR_PERF > bool > select SOFTLOCKUP_DETECTOR > >

Re: [PATCH v8 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-06-04 Thread Randy Dunlap
On 05/29/2018 11:39 AM, Greg KH wrote: > On Tue, May 29, 2018 at 01:23:23PM -0500, Gary R Hook wrote: >> Implement a skeleton framework for debugfs support in the >> AMD IOMMU. Add a hidden boolean to Kconfig that is defined >> for the AMD IOMMU when general IOMMY DebugFS support is >> enabled. >>

Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-05-18 Thread Randy Dunlap
On 05/18/2018 08:20 AM, Gary R Hook wrote: > On 05/15/2018 08:46 AM, Joerg Roedel wrote: >> On Mon, May 14, 2018 at 03:00:50PM -0500, Gary R Hook wrote: >>> This was brought up a few weeks ago in, I believe, version 3 of this patch. >>> That question was discussed (because that's what I did the

Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-05-14 Thread Randy Dunlap
On 05/14/2018 01:00 PM, Gary R Hook wrote: > On 05/14/2018 12:50 PM, Randy Dunlap wrote: >> On 05/14/2018 10:20 AM, Gary R Hook wrote: >>> Implement a skeleton framework for debugfs support in the >>> AMD IOMMU. >>> >>> Signed-off-by: Gary R Hook &l

Re: [PATCH v7 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-05-14 Thread Randy Dunlap
On 05/14/2018 10:20 AM, Gary R Hook wrote: > Implement a skeleton framework for debugfs support in the > AMD IOMMU. > > Signed-off-by: Gary R Hook > --- > drivers/iommu/Makefile|5 + > drivers/iommu/amd_iommu_debugfs.c | 39 >

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Randy Dunlap
On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap <rdun...@infradead.org> wrote: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove km

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Randy Dunlap
On 02/13/2018 02:09 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> On 02/12/2018 04:28 AM, Michael Ellerman wrote: >>> Randy Dunlap <rdun...@infradead.org> writes: >>> >>>> From: Randy Dunlap <rdun...@infr

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-12 Thread Randy Dunlap
On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmeml

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-12 Thread Randy Dunlap
On 02/12/2018 04:28 AM, Michael Ellerman wrote: > Randy Dunlap <rdun...@infradead.org> writes: > >> From: Randy Dunlap <rdun...@infradead.org> >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmeml

[PATCH] headers: untangle kmemleak.h from mm.h

2018-02-11 Thread Randy Dunlap
From: Randy Dunlap <rdun...@infradead.org> Currently #includes for no obvious reason. It looks like it's only a convenience, so remove kmemleak.h from slab.h and add to any users of kmemleak_* that don't already #include it. Also remove from source files that do not use it. This is

Re: [PATCH 22/34] dma-mapping: add an arch_dma_supported hook

2018-02-02 Thread Randy Dunlap
On 01/12/2018 12:42 AM, Christoph Hellwig wrote: > To implement the x86 forbid_dac and iommu_sac_force we want an arch hook > so that it can apply the global options across all dma_map_ops > implementations. > > Signed-off-by: Christoph Hellwig > --- >

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-15 Thread Randy Dunlap
On 10/15/17 20:29, Randy Dunlap wrote: > On 10/15/17 20:27, Randy Dunlap wrote: >> On 10/15/17 19:27, Marian Mihailescu wrote: >>> After commit 7844572c633964c864d9f32dc3f2a8ffe5d70371, dma_noop_ops >>> are built only for architectures that use it. >>> >>&

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-15 Thread Randy Dunlap
On 10/15/17 20:27, Randy Dunlap wrote: > On 10/15/17 19:27, Marian Mihailescu wrote: >> After commit 7844572c633964c864d9f32dc3f2a8ffe5d70371, dma_noop_ops >> are built only for architectures that use it. >> >> For ARM architecture, CONFIG_DMA_NOOP_OPS is not selected

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-15 Thread Randy Dunlap
On 10/15/17 19:27, Marian Mihailescu wrote: > After commit 7844572c633964c864d9f32dc3f2a8ffe5d70371, dma_noop_ops > are built only for architectures that use it. > > For ARM architecture, CONFIG_DMA_NOOP_OPS is not selected, and cannot > be selected. > > However,

Re: [PATCH v2] iommu: exynos: Fix trivial typos

2014-08-04 Thread Randy Dunlap
insertions(+), 25 deletions(-) Acked-by: Randy Dunlap rdun...@infradead.org Thanks. -- ~Randy ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 1/1] iommu: exynos: Fix trivial typos

2014-08-02 Thread Randy Dunlap
On 08/01/14 23:03, Sachin Kamat wrote: Fixed trivial typos and grammar to improve readability. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/iommu/exynos-iommu.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git