Re: [PATCH v3 2/3] dt-bindings: iommu: add DART iommu bindings

2021-06-10 Thread Rob Herring
g = <0x82f8 0x4000>; > + interrupts = <1 781 4>; > + #iommu-cells = <1>; > +}; > + > +master1 { > + iommus = <&{/dart1} 0>; /dart1 is a path, but 'dart1' is a label. You need '' (or '&{/iommu@82f8}' but that doesn't reall

[PATCH 2/2] iommu: Drop unnecessary of_iommu.h includes

2021-05-27 Thread Rob Herring
-Philippe Brucker Cc: Frank Rowand Cc: linux-arm-ker...@lists.infradead.org Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 - drivers/iommu/arm/arm-smmu/arm-smmu.c | 1 - drivers/iommu/arm/arm-smmu/qcom_iommu.c | 1

[PATCH 1/2] iommu: Remove unused of_get_dma_window()

2021-05-27 Thread Rob Herring
Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- drivers/iommu/of_iommu.c | 68 include/linux/of_iommu.h | 17 ++ 2 files changed, 3 insertions(+), 82 deletions(-) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iom

Re: [PATCH v4] iommu/of: Fix pci_request_acs() before enumerating PCI devices

2021-05-21 Thread Rob Herring
U linkage") > Signed-off-by: Xingang Wang > --- > drivers/iommu/of_iommu.c | 1 - > drivers/pci/of.c | 8 +++- > 2 files changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Rob Herring > diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c > index a9d2df0

Re: [PATCH v2 1/5] dt-bindings: reserved-memory: Document memory region specifier

2021-05-20 Thread Rob Herring
On Fri, Apr 23, 2021 at 06:32:30PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Reserved memory region phandle references can be accompanied by a > specifier that provides additional information about how that specific > reference should be treated. > > One use-case is to mark a

Re: [PATCH v3] iommu/of: Fix pci_request_acs() before enumerating PCI devices

2021-05-20 Thread Rob Herring
On Thu, May 20, 2021 at 2:28 AM Wang Xingang wrote: > > From: Xingang Wang > > When booting with devicetree, the pci_request_acs() is called after the > enumeration and initialization of PCI devices, thus the ACS is not > enabled. And ACS should be enabled when IOMMU is detected for the > PCI

Re: [PATCH v2] iommu/of: Fix pci_request_acs() before enumerating PCI devices

2021-05-19 Thread Rob Herring
On Mon, May 17, 2021 at 01:17:05PM +, Wang Xingang wrote: > From: Xingang Wang > > When booting with devicetree, the pci_request_acs() is called after the > enumeration and initialization of PCI devices, thus the ACS is not > enabled. This patch add check for IOMMU in of_core_init(), and

Re: [PATCH v4 1/6] dt-bindings: iommu: rockchip: Convert IOMMU to DT schema

2021-05-07 Thread Rob Herring
rtions(+), 38 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > create mode 100644 > Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > Reviewed-by: Rob Herring ___ iommu mailing list iommu@

Re: [PATCH v3 2/4] dt-bindings: iommu: rockchip: Add compatible for v2

2021-05-06 Thread Rob Herring
; > version 2: > - Add power-domains property > > .../devicetree/bindings/iommu/rockchip,iommu.yaml | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring ___ iommu mailing l

Re: [PATCH v3 1/4] dt-bindings: iommu: rockchip: Convert IOMMU to DT schema

2021-05-06 Thread Rob Herring
On Tue, May 04, 2021 at 10:41:21AM +0200, Benjamin Gaignard wrote: > Convert Rockchip IOMMU to DT schema > > Signed-off-by: Benjamin Gaignard > --- > version 2: > - Change maintainer > - Change reg maxItems > - Change interrupt maxItems > > .../bindings/iommu/rockchip,iommu.txt | 38

Re: [PATCH v2 2/4] dt-bindings: iommu: rockchip: Add compatible for v2

2021-04-30 Thread Rob Herring
On Thu, Apr 22, 2021 at 04:16:00PM +0200, Benjamin Gaignard wrote: > Add compatible for the second version of IOMMU hardware block. > RK356x IOMMU can also be link to a power domain. > > Signed-off-by: Benjamin Gaignard > --- > version 2: > - Add power-domains property > >

Re: [PATCH v2 1/4] dt-bindings: iommu: rockchip: Convert IOMMU to DT schema

2021-04-30 Thread Rob Herring
On Thu, Apr 22, 2021 at 02:16:53PM -0300, Ezequiel Garcia wrote: > (Adding Kever) > > Hi Benjamin, > > Thanks a lot for working on this, it looks amazing. Together with the great > work > that Rockchip is doing, it seems RK3566/RK3568 will have decent support very > soon. > > One comment

Re: [PATCH 0/3] Apple M1 DART IOMMU driver

2021-03-23 Thread Rob Herring
On Sun, Mar 21, 2021 at 05:00:50PM +0100, Mark Kettenis wrote: > > Date: Sat, 20 Mar 2021 15:19:33 + > > From: Sven Peter > > > > Hi, > > > > After Hector's initial work [1] to bring up Linux on Apple's M1 it's time to > > bring up more devices. Most peripherals connected to the SoC are

Re: [PATCH 2/3] dt-bindings: iommu: add DART iommu bindings

2021-03-21 Thread Rob Herring
On Sat, 20 Mar 2021 15:20:08 +, Sven Peter wrote: > DART (Device Address Resolution Table) is the iommu found on Apple > ARM SoCs such as the M1. > > Signed-off-by: Sven Peter > --- > .../bindings/iommu/apple,t8103-dart.yaml | 82 +++ > MAINTAINERS

Re: [PATCH v4 13/14] dt-bindings: of: Add restricted DMA pool

2021-03-10 Thread Rob Herring
On Wed, Mar 10, 2021 at 9:08 AM Will Deacon wrote: > > Hi Claire, > > On Tue, Feb 09, 2021 at 02:21:30PM +0800, Claire Chang wrote: > > Introduce the new compatible string, restricted-dma-pool, for restricted > > DMA. One can specify the address and length of the restricted DMA memory > > region

Re: [PATCH v3 1/2] dt-bindings: iommu: add bindings for sprd iommu

2021-02-10 Thread Rob Herring
On Fri, Feb 5, 2021 at 1:21 AM Chunyan Zhang wrote: > > Hi Rob, > > On Fri, 5 Feb 2021 at 07:25, Rob Herring wrote: > > > > On Wed, Feb 03, 2021 at 05:07:26PM +0800, Chunyan Zhang wrote: > > > From: Chunyan Zhang > > > > > > This iomm

Re: [PATCH v3 1/2] dt-bindings: iommu: add bindings for sprd iommu

2021-02-04 Thread Rob Herring
On Wed, Feb 03, 2021 at 05:07:26PM +0800, Chunyan Zhang wrote: > From: Chunyan Zhang > > This iommu module can be used by Unisoc's multimedia devices, such as > display, Image codec(jpeg) and a few signal processors, including > VSP(video), GSP(graphic), ISP(image), and CPP(camera pixel

Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-03 Thread Rob Herring
On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote: > Quoting Rob Herring (2021-02-02 12:55:42) > > > > diff --git > > a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml > > > > b/Documentation/devicetree/bindings/clock/al

Re: [PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-03 Thread Rob Herring
On Wed, Feb 03, 2021 at 09:01:23AM +0100, Geert Uytterhoeven wrote: > Hi Rob, > > On Tue, Feb 2, 2021 at 9:55 PM Rob Herring wrote: > > Properties in if/then schemas weren't getting checked by the meta-schemas. > > Enabling meta-schema checks finds several errors. > &g

[PATCH 3/3] dt-bindings: Fix errors in 'if' schemas

2021-02-02 Thread Rob Herring
hoeven Cc: Linus Walleij Cc: Daniel Lezcano Cc: linux-cry...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linux-l...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: linux-g...@vger.kernel.org Signed-off-by: Rob Herring --- .../devicetree/bindings/crypto/allwinner,sun8i-ce.

[PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-02 Thread Rob Herring
c: linux-g...@vger.kernel.org Cc: linux-...@vger.kernel.org Cc: iommu@lists.linux-foundation.org Cc: linux-watch...@vger.kernel.org Signed-off-by: Rob Herring --- .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml| 2 +- Documentation/devicetree/bindings/clock/arm,syscon-icst

[PATCH 2/3] dt-bindings: iommu: renesas, ipmmu-vmsa: Make 'power-domains' conditionally required

2021-02-02 Thread Rob Herring
be conditioned on !renesas,ipmmu-vmsa. Cc: Joerg Roedel Cc: Will Deacon Cc: Yoshihiro Shimoda Cc: iommu@lists.linux-foundation.org Signed-off-by: Rob Herring --- .../bindings/iommu/renesas,ipmmu-vmsa.yaml | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges

2021-01-27 Thread Rob Herring
; consumer devices. > > [1] > https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ce...@arm.com/ > > CC: Rob Herring > CC: Frank Rowand > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting > dma_pfn_offset"), > S

Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges

2021-01-27 Thread Rob Herring
On Wed, Jan 27, 2021 at 7:13 AM Robin Murphy wrote: > > [ + Christoph, Marek ] > > On 2021-01-27 13:00, Paul Kocialkowski wrote: > > Hi, > > > > On Tue 19 Jan 21, 18:52, Yong Wu wrote: > >> The commit e0d072782c73 ("dma-mapping: introduce DMA range map, > >> supplanting dma_pfn_offset") always

Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges

2021-01-27 Thread Rob Herring
he dma_address requirements of its iommu > consumer devices. > > [1] > https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ce...@arm.com/ > > CC: Rob Herring > CC: Frank Rowand > Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplant

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-21 Thread Rob Herring
On Wed, Jan 20, 2021 at 7:10 PM Robin Murphy wrote: > > On 2021-01-20 21:31, Rob Herring wrote: > > On Wed, Jan 20, 2021 at 11:30 AM Robin Murphy wrote: > >> > >> On 2021-01-20 16:53, Rob Herring wrote: > >>> On Wed, Jan 06, 2021 at 11:41:23AM +0800, Cl

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-20 Thread Rob Herring
On Wed, Jan 20, 2021 at 11:30 AM Robin Murphy wrote: > > On 2021-01-20 16:53, Rob Herring wrote: > > On Wed, Jan 06, 2021 at 11:41:23AM +0800, Claire Chang wrote: > >> Introduce the new compatible string, restricted-dma-pool, for restricted > >> DMA. One can

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-20 Thread Rob Herring
On Wed, Jan 06, 2021 at 11:41:23AM +0800, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the device tree. If this goes into DT, I think we

Re: [PATCH v6 06/33] of/device: Move dma_range_map before of_iommu_configure

2021-01-14 Thread Rob Herring
t; + dev->dma_range_map = map; > iommu = of_iommu_configure(dev, np, id); > if (PTR_ERR(iommu) == -EPROBE_DEFER) { > kfree(map); > + dev->dma_range_map = NULL; Not really going to matter, but you should probably clear

Re: [RFC PATCH 1/2] dt-bindings: iommu: add bindings for sprd iommu

2021-01-13 Thread Rob Herring
On Fri, Jan 8, 2021 at 5:34 AM Chunyan Zhang wrote: > > On Fri, 8 Jan 2021 at 10:25, Rob Herring wrote: > > > > On Wed, Dec 23, 2020 at 07:16:32PM +0800, Chunyan Zhang wrote: > > > From: Chunyan Zhang > > > > > > This patch only adds bindings

Re: [PATCH 2/2] dt-bindings: arm-smmu: Add binding for Qcom SDX55 SMMU

2021-01-12 Thread Rob Herring
Reviewed-by: Vinod Koul > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH 1/2] dt-bindings: iommu: add bindings for sprd iommu

2021-01-07 Thread Rob Herring
On Wed, Dec 23, 2020 at 07:16:32PM +0800, Chunyan Zhang wrote: > From: Chunyan Zhang > > This patch only adds bindings to support display iommu, support for others > would be added once finished tests with those devices, such as Image > codec(jpeg) processor, a few signal processors, including

Re: [PATCH v2 1/4] dt-bindings: reserved-memory: Document "active" property

2020-12-18 Thread Rob Herring
> On 2020-11-05 16:43, Thierry Reding wrote: > > > > > On Thu, Sep 24, 2020 at 01:27:25PM +0200, Thierry Reding wrote: > > > > > > On Tue, Sep 15, 2020 at 02:36:48PM +0200, Thierry Reding wrote: > > > > > > > On Mon, Sep 14, 2020 at 04:08:

Re: [PATCH v5 05/27] dt-bindings: memory: mediatek: Rename header guard for SMI header file

2020-12-10 Thread Rob Herring
-- > 6 files changed, 12 insertions(+), 12 deletions(-) > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v4 04/24] dt-bindings: memory: mediatek: Add domain definition

2020-11-16 Thread Rob Herring
e. > > This is a preparing patch for multi-domain support. > > Signed-off-by: Yong Wu > --- > include/dt-bindings/memory/mtk-smi-larb-port.h | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > Acked-by: Rob Herring _

Re: [PATCH v4 01/24] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema

2020-11-16 Thread Rob Herring
2 files changed, 167 insertions(+), 105 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > create mode 100644 > Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml > Reviewed-by: Rob Herring ___

Re: [PATCH v5 1/3] dt-bindings: memory: mediatek: Convert SMI to DT schema

2020-11-05 Thread Rob Herring
create mode 100644 > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > delete mode 100644 > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > create mode 100644 > Documentation/devicetree/bindings/memory-controllers/

Re: [PATCH v5 3/7] of/address: Introduce of_dma_get_max_cpu_address()

2020-11-02 Thread Rob Herring
- Rename function > - Correct subject > - Add support to start parsing from an arbitrary device node in order >for the function to work with unit tests > > drivers/of/address.c | 42 ++ > include/linux/of.h

Re: [PATCH v4 1/3] dt-bindings: memory: mediatek: Convert SMI to DT schema

2020-10-30 Thread Rob Herring
On Fri, 30 Oct 2020 17:12:52 +0800, Yong Wu wrote: > Convert MediaTek SMI to DT schema. > > CC: Fabien Parent > CC: Ming-Fan Chen > CC: Matthias Brugger > Signed-off-by: Yong Wu > --- > .../mediatek,smi-common.txt | 50 --- > .../mediatek,smi-common.yaml

Re: [PATCH v4 4/7] of: unittest: Add test for of_dma_get_max_cpu_address()

2020-10-26 Thread Rob Herring
DMA guards > > drivers/of/unittest.c | 18 ++ > 1 file changed, 18 insertions(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()

2020-10-16 Thread Rob Herring
On Thu, Oct 15, 2020 at 12:42 AM Christoph Hellwig wrote: > > > +phys_addr_t __init of_dma_get_max_cpu_address(struct device_node *np) > > +{ > > + phys_addr_t max_cpu_addr = PHYS_ADDR_MAX; > > + struct of_range_parser parser; > > + phys_addr_t subtree_max_addr; > > + struct

Re: [PATCH v3 4/8] of: unittest: Add test for of_dma_get_max_cpu_address()

2020-10-14 Thread Rob Herring
On Wed, Oct 14, 2020 at 2:12 PM Nicolas Saenz Julienne wrote: > > Introduce a test for of_dma_get_max_cup_address(), it uses the same DT > data as the rest of dma-ranges unit tests. > > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/of/unittest.c | 20 > 1 file

Re: [PATCH v3 3/8] of/address: Introduce of_dma_get_max_cpu_address()

2020-10-14 Thread Rob Herring
On Wed, Oct 14, 2020 at 2:12 PM Nicolas Saenz Julienne wrote: > > Introduce of_dma_get_max_cpu_address(), which provides the highest CPU > physical address addressable by all DMA masters in the system. It's > specially useful for setting memory zones sizes at early boot time. > > Signed-off-by:

Re: [PATCH v2 2/5] of/address: Introduce of_dma_lower_bus_limit()

2020-10-14 Thread Rob Herring
On Wed, Oct 14, 2020 at 6:52 AM Nicolas Saenz Julienne wrote: > > Hi Rob, > > On Mon, 2020-10-12 at 10:25 -0500, Rob Herring wrote: > > On Sat, Oct 10, 2020 at 10:12 AM Nicolas Saenz Julienne > > wrote: > > > The function provides the CPU physica

Re: [PATCH v2 2/5] of/address: Introduce of_dma_lower_bus_limit()

2020-10-12 Thread Rob Herring
On Sat, Oct 10, 2020 at 10:12 AM Nicolas Saenz Julienne wrote: > > The function provides the CPU physical address addressable by the most > constrained bus in the system. It might be useful in order to > dynamically set up memory zones during boot. > > Signed-off-by: Nicolas Saenz Julienne > ---

Re: [PATCH 1/4] of/fdt: Update zone_dma_bits when running in bcm2711

2020-10-01 Thread Rob Herring
ink we could keep this entirely in the arm64 setup_machine_fdt() and > > > not pollute the core code with RPi4-specific code. > > > > Actually, even better, could we not move the check to > > arm64_memblock_init() when we initialise zone_dma_bits? > > I d

Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema

2020-09-18 Thread Rob Herring
On Mon, Sep 14, 2020 at 11:51 PM Yong Wu wrote: > > On Mon, 2020-09-14 at 17:22 -0600, Rob Herring wrote: > > On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote: > > > Convert MediaTek IOMMU to DT schema. > > > > > > Signed-off-by: Yong Wu

Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-16 Thread Rob Herring
On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: > > > So I get a performance regression with the dma-coherent approach, even if > > it's > > clearly the cleaner. > > That's bizarre -- this should really be the faster of the two. Coherency may not be free. CortexA9 had something like

Re: [PATCH v2 06/23] dt-bindings: mediatek: Add binding for mt8192 IOMMU and SMI

2020-09-14 Thread Rob Herring
mory/mt8192-larb-port.h | 239 ++ > 4 files changed, 251 insertions(+), 5 deletions(-) > create mode 100644 include/dt-bindings/memory/mt8192-larb-port.h > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 02/23] dt-bindings: memory: mediatek: Convert SMI to DT schema

2020-09-14 Thread Rob Herring
On Sat, Sep 05, 2020 at 04:08:59PM +0800, Yong Wu wrote: > Convert MediaTek SMI to DT schema. > > Signed-off-by: Yong Wu > --- > .../mediatek,smi-common.txt | 49 -- > .../mediatek,smi-common.yaml | 96 +++ >

Re: [PATCH v2 01/23] dt-bindings: iommu: mediatek: Convert IOMMU to DT schema

2020-09-14 Thread Rob Herring
On Sat, Sep 05, 2020 at 04:08:58PM +0800, Yong Wu wrote: > Convert MediaTek IOMMU to DT schema. > > Signed-off-by: Yong Wu > --- > .../bindings/iommu/mediatek,iommu.txt | 103 > .../bindings/iommu/mediatek,iommu.yaml| 150 ++ > 2 files changed, 150

Re: [PATCH v2 1/4] dt-bindings: reserved-memory: Document "active" property

2020-09-14 Thread Rob Herring
On Fri, Sep 04, 2020 at 02:59:57PM +0200, Thierry Reding wrote: > From: Thierry Reding > > Reserved memory regions can be marked as "active" if hardware is > expected to access the regions during boot and before the operating > system can take control. One example where this is useful is for the

Re: [PATCH] dt-bindings: iommu: renesas,ipmmu-vmsa: Sort compatible string in increasing number of the SoC

2020-08-24 Thread Rob Herring
ion(+), 1 deletion(-) > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC v2 4/5] dt-bindings: of: Add plumbing for restricted DMA pool

2020-07-31 Thread Rob Herring
On Tue, Jul 28, 2020 at 01:01:39PM +0800, Claire Chang wrote: > Introduce the new compatible string, device-swiotlb-pool, for restricted > DMA. One can specify the address and length of the device swiotlb memory > region by device-swiotlb-pool in the device tree. > > Signed-off-by: Claire Chang

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-31 Thread Rob Herring
On Thu, Jul 30, 2020 at 10:44 AM Jim Quinlan wrote: > > On Wed, Jul 29, 2020 at 10:28 AM Rob Herring wrote: > > > > On Wed, Jul 29, 2020 at 12:19 AM Christoph Hellwig wrote: > > > > > > On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote:

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-29 Thread Rob Herring
On Wed, Jul 29, 2020 at 12:19 AM Christoph Hellwig wrote: > > On Tue, Jul 28, 2020 at 02:24:51PM -0400, Jim Quinlan wrote: > > I started using devm_kcalloc() but at least two reviewers convinced me > > to just use kcalloc(). In addition, when I was using devm_kcalloc() > > it was awkward because

Re: [PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-28 Thread Rob Herring
On Fri, Jul 24, 2020 at 2:45 PM Jim Quinlan wrote: > > The new field 'dma_range_map' in struct device is used to facilitate the > use of single or multiple offsets between mapping regions of cpu addrs and > dma addrs. It subsumes the role of "dev->dma_pfn_offset" which was only > capable of

Re: [PATCH 18/21] iommu/mediatek: Add support for multi domain

2020-07-23 Thread Rob Herring
On Sat, Jul 11, 2020 at 02:48:43PM +0800, Yong Wu wrote: > Some HW IP(ex: CCU) require the special iova range. That means the > iova got from dma_alloc_attrs for that devices must locate in his > special range. In this patch, we allocate a special iova_range for > each a special requirement and

Re: [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: Add r8a774e1 support

2020-07-20 Thread Rob Herring
changed, 1 insertion(+) > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 8/9] dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC

2020-07-20 Thread Rob Herring
as,ravb.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 1/9] dt-bindings: iommu: renesas, ipmmu-vmsa: Add r8a774e1 support

2020-07-20 Thread Rob Herring
On Mon, Jul 13, 2020 at 10:35:12PM +0100, Lad Prabhakar wrote: > Document RZ/G2H (R8A774E1) SoC bindings. > > Signed-off-by: Lad Prabhakar > --- > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 + > 1 file changed, 1 insertion(+) Ack

Re: [PATCH 3/9] arm64: dts: renesas: r8a774e1: Add IPMMU device nodes

2020-07-20 Thread Rob Herring
renesas/r8a774e1.dtsi | 121 ++ > 1 file changed, 121 insertions(+) Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 04/21] dt-binding: mediatek: Add binding for mt8192 IOMMU and SMI

2020-07-20 Thread Rob Herring
On Sat, Jul 11, 2020 at 02:48:29PM +0800, Yong Wu wrote: > This patch adds decriptions for mt8192 IOMMU and SMI. > > mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation > table format. The M4U-SMI HW diagram is as below: > > EMI >

Re: [PATCH 02/21] dt-binding: memory: mediatek: Extend LARB_NR_MAX to 32

2020-07-20 Thread Rob Herring
On Sat, 11 Jul 2020 14:48:27 +0800, Yong Wu wrote: > Extend the max larb number definition as mt8192 has larb_nr over 16. > > Signed-off-by: Yong Wu > --- > include/dt-bindings/memory/mtk-smi-larb-port.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH 01/21] dt-binding: memory: mediatek: Add a common larb-port header file

2020-07-20 Thread Rob Herring
eletions(-) > create mode 100644 include/dt-bindings/memory/mtk-smi-larb-port.h > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 1/4] dt-bindings: mediatek: add mediatek,infracfg phandle

2020-07-15 Thread Rob Herring
On Thu, Jul 02, 2020 at 05:37:17PM +0800, Miles Chen wrote: > Add a description for mediatek,infracfg. We can check if 4GB mode > is enable by reading it instead of checking the unexported > symbol "max_pfn". > > This is a step towards building mtk_iommu as a kernel module. You determined this

Re: [PATCH v10 4/5] dt-bindings: arm-smmu: add binding for Tegra194 SMMU

2020-07-14 Thread Rob Herring
On Mon, Jul 13, 2020 at 8:10 AM Robin Murphy wrote: > > On 2020-07-10 21:29, Krishna Reddy wrote: > > Thanks Rob. One question on setting "minItems: ". Please see below. > > > >>> +allOf: > >>> + - if: > >>> + properties: > >>> +compatible: > >>> + contains: > >>> +

Re: [PATCH v2 06/12] of/iommu: Make of_map_rid() PCI agnostic

2020-07-13 Thread Rob Herring
e RID instances/names to a generic "id" tag. > > No functionality change intended. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Joerg Roedel > Cc: Robin Murphy > Cc: Marc Zyngier > --- > drivers/iomm

Re: [PATCH v3 3/4] dt-bindings: arm-smmu: add compatible string for Marvell Armada-AP806 SMMU-500

2020-07-13 Thread Rob Herring
gt; +  - enum: > > > +  - marvell,ap806-smmu-500 > > > > Isn't a single-valued enum just a constant? :P > > That's how copy-paste engineering ends up :) It's fine like this if you expect more SoCs to be added. Either way, Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v10 4/5] dt-bindings: arm-smmu: add binding for Tegra194 SMMU

2020-07-09 Thread Rob Herring
On Tue, Jul 07, 2020 at 10:00:16PM -0700, Krishna Reddy wrote: > Add binding for NVIDIA's Tegra194 SoC SMMU. > > Signed-off-by: Krishna Reddy > --- > .../devicetree/bindings/iommu/arm,smmu.yaml| 18 ++ > 1 file changed, 18 insertions(+) > > diff --git

Re: [PATCH v2 10/12] of/irq: Make of_msi_map_rid() PCI bus agnostic

2020-06-30 Thread Rob Herring
d by all busses that require > input/output ID translations. > > No functional change intended. > > Signed-off-by: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Rob Herring > Cc: Marc Zyngier > --- > drivers/of/irq.c | 28 ++-- > drivers/

Re: [PATCH v2 08/12] dt-bindings: arm: fsl: Add msi-map device-tree binding for fsl-mc bus

2020-06-30 Thread Rob Herring
operty. > In addition, deprecate msi-parent property which no longer makes sense > now that we support translating the MSIs. > > Signed-off-by: Laurentiu Tudor > Signed-off-by: Diana Craciun > Cc: Rob Herring > --- > .../devicetree/bindings/misc/fsl,qoriq-mc.txt |

Re: [PATCH v2 09/12] of/irq: make of_msi_map_get_device_domain() bus agnostic

2020-06-30 Thread Rob Herring
an input parameter. > > Signed-off-by: Diana Craciun > Signed-off-by: Lorenzo Pieralisi > Acked-by: Bjorn Helgaas# pci/msi.c > Cc: Bjorn Helgaas > Cc: Rob Herring > Cc: Marc Zyngier > --- > drivers/of/irq.c | 8 +--- > drivers/pci/msi.c | 2 +- >

Re: [PATCH v2 07/12] of/device: Add input id to of_dma_configure()

2020-06-30 Thread Rob Herring
d parameter, > leaving current functionality unchanged. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Laurentiu Tudor > --- > drivers/bus/fsl-mc/fsl-mc-bus.c | 4 +- > drivers/iommu/of_iommu.c| 81 +

Re: [PATCH v8 3/7] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-06-17 Thread Rob Herring
le string so that they can be identified in the > arm-smmu implementation specific code. > > Signed-off-by: Jordan Crouse > --- > > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring _

Re: [PATCH 1/2] dt-bindings: iommu: renesas, ipmmu-vmsa: add r8a77961 support

2020-06-17 Thread Rob Herring
On Thu, 11 Jun 2020 20:10:29 +0900, Yoshihiro Shimoda wrote: > Add support for r8a77961 (R-Car M3-W+). > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v2 1/8] dt-bindings: arm-smmu: Add sm8150 and sm8250 compatible strings

2020-06-17 Thread Rob Herring
On Tue, 09 Jun 2020 15:40:19 -0400, Jonathan Marek wrote: > Add compatible strings for sm8150 and sm8250 iommus to documentation. > > Signed-off-by: Jonathan Marek > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [PATCH v4 01/17] media: dt-binding: mtk-vcodec: Separating mtk-vcodec encode node.

2020-06-09 Thread Rob Herring
On Sat, May 30, 2020 at 04:10:02PM +0800, Yong Wu wrote: > From: Maoguang Meng > > Update binding document since the avc and vp8 hardware encoder in > mt8173 are now separated. Separate "mediatek,mt8173-vcodec-enc" to > "mediatek,mt8173-vcodec-vp8-enc" and "mediatek,mt8173-vcodec-avc-enc". The

Re: [PATCH v2 00/14] PCI: brcmstb: enable PCIe for STB chips

2020-05-29 Thread Rob Herring
On Tue, May 26, 2020 at 03:12:39PM -0400, Jim Quinlan wrote: > v2: > Commit: "device core: Add ability to handle multiple dma offsets" > o Added helper func attach_dma_pfn_offset_map() in address.c (Chistoph) > o Helpers funcs added to __phys_to_dma() & __dma_to_phys() (Christoph) > o Added

Re: [PATCH v2 09/14] device core: Add ability to handle multiple dma offsets

2020-05-29 Thread Rob Herring
On Wed, May 27, 2020 at 9:43 AM Jim Quinlan wrote: > > Hi Nicolas, > > On Wed, May 27, 2020 at 11:00 AM Nicolas Saenz Julienne > wrote: > > > > Hi Jim, > > one thing comes to mind, there is a small test suite in > > drivers/of/unittest.c > > (specifically of_unittest_pci_dma_ranges()) you could

Re: [PATCH 09/12] dt-bindings: arm: fsl: Add msi-map device-tree binding for fsl-mc bus

2020-05-22 Thread Rob Herring
On Fri, May 22, 2020 at 3:57 AM Diana Craciun OSS wrote: > > On 5/22/2020 12:42 PM, Robin Murphy wrote: > > On 2020-05-22 00:10, Rob Herring wrote: > >> On Thu, May 21, 2020 at 7:00 AM Lorenzo Pieralisi > >> wrote: > >>> > >>> From: Lau

Re: [PATCH 09/12] dt-bindings: arm: fsl: Add msi-map device-tree binding for fsl-mc bus

2020-05-22 Thread Rob Herring
On Fri, May 22, 2020 at 3:42 AM Robin Murphy wrote: > > On 2020-05-22 00:10, Rob Herring wrote: > > On Thu, May 21, 2020 at 7:00 AM Lorenzo Pieralisi > > wrote: > >> > >> From: Laurentiu Tudor > >> > >> The existing bindings cannot be used t

Re: [PATCH 10/12] of/irq: Make of_msi_map_rid() PCI bus agnostic

2020-05-21 Thread Rob Herring
d by all busses that require > input/output ID translations. > > Leave a wrapper function of_msi_map_rid() in place to keep > existing PCI code mapping requester ID syntactically unchanged. > > No functional change intended. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Her

Re: [PATCH 09/12] dt-bindings: arm: fsl: Add msi-map device-tree binding for fsl-mc bus

2020-05-21 Thread Rob Herring
map property. > > Signed-off-by: Laurentiu Tudor > Cc: Rob Herring > --- > .../devicetree/bindings/misc/fsl,qoriq-mc.txt | 30 +-- > 1 file changed, 27 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt

Re: [PATCH 07/12] of/device: Add input id to of_dma_configure()

2020-05-21 Thread Rob Herring
d parameter, > leaving current functionality unchanged. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Laurentiu Tudor > --- > drivers/bus/fsl-mc/fsl-mc-bus.c | 4 ++- > drivers/iommu/of_iommu.c| 53 +

Re: [PATCH 06/12] of/iommu: Make of_map_rid() PCI agnostic

2020-05-21 Thread Rob Herring
s much. And there's only 3 callers. > No functionality change intended. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Joerg Roedel > Cc: Robin Murphy > Cc: Marc Zyngier > --- > drivers/iommu/of_iommu.c | 2 +- > drivers/of/base.c| 42 +

Re: [PATCH v5 19/38] drm: panfrost: fix common struct sg_table related issues

2020-05-14 Thread Rob Herring
g_table nents > vs. orig_nents misuse' thread: > https://lore.kernel.org/linux-iommu/20200513132114.6046-1-m.szyprow...@samsung.com/T/ > --- > drivers/gpu/drm/panfrost/panfrost_gem.c | 4 ++-- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 7 +++ > 2 files changed, 5 insertions(+), 6 deletions(

Re: [PATCH v3 2/5] dt-bindings: display: sun8i-mixer: Allow for an iommu property

2020-05-12 Thread Rob Herring
.yaml > | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v5] dt-bindings: iommu: renesas,ipmmu-vmsa: convert to json-schema

2020-05-05 Thread Rob Herring
On Tue, 21 Apr 2020 14:15:52 +0900, Yoshihiro Shimoda wrote: > Convert Renesas VMSA-Compatible IOMMU bindings documentation > to json-schema. > > Note that original documentation doesn't mention renesas,ipmmu-vmsa > for R-Mobile APE6. But, R-Mobile APE6 is similar to the R-Car > Gen2. So,

Re: [PATCH] of_device: removed #include that caused a recursion in included headers

2020-04-20 Thread Rob Herring
On Mon, Apr 13, 2020 at 04:35:53PM +0300, Hadar Gat wrote: > Both of_platform.h and of_device.h were included each other. > In of_device.h, removed unneeded #include to of_platform.h > and added include to of_platform.h in the files that needs it. Guess we forgot about that temporary comment!

Re: [PATCH] dt-bndings: iommu: renesas,ipmmu-vmsa: convert to json-schema

2020-04-20 Thread Rob Herring
On Mon, Apr 13, 2020 at 07:25:33PM +0900, Yoshihiro Shimoda wrote: > Convert Renesas VMSA-Compatible IOMMU bindings documentation > to json-schema. > > Signed-off-by: Yoshihiro Shimoda > --- > .../bindings/iommu/renesas,ipmmu-vmsa.txt | 73 -- >

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom: Add iommus property

2020-03-30 Thread Rob Herring
changed, 3 insertions(+) > Acked-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v3] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-03-19 Thread Rob Herring
On Wed, Mar 18, 2020 at 4:19 PM Will Deacon wrote: > > Hi Rob, > > On Mon, Feb 24, 2020 at 04:31:29PM -0600, Rob Herring wrote: > > Arm SMMUv3.2 adds support for TLB range invalidate operations. > > Support for range invalidate is determined by the RIL bit

Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk

2020-02-25 Thread Rob Herring
On Tue, Feb 18, 2020 at 11:20 AM Will Deacon wrote: > > On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote: > > Cc: Will Deacon > > Cc: Robin Murphy > > Cc: Joerg Roedel > > Cc: iommu@lists.linux-foundation.org > > Signed-off-by: Rob H

[PATCH v3] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-02-24 Thread Rob Herring
-off-by: Rob Herring --- v3: - Use inv_range local instead of modifying granule - Simplify the TG calculation - Use shift instead of divide by power of 2. --- drivers/iommu/arm-smmu-v3.c | 69 +++-- 1 file changed, 67 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-02-21 Thread Rob Herring
On Fri, Feb 21, 2020 at 10:19 AM Robin Murphy wrote: > > On 20/02/2020 5:54 pm, Rob Herring wrote: > > On Mon, Feb 17, 2020 at 1:17 PM Robin Murphy wrote: > >> > >> On 13/02/2020 9:49 pm, Rob Herring wrote: > >>> On Thu, Jan 30, 2020 at 11:34 AM Robin Mu

Re: [PATCH v2] iommu/arm-smmu-v3: Add SMMUv3.2 range invalidation support

2020-02-20 Thread Rob Herring
On Mon, Feb 17, 2020 at 1:17 PM Robin Murphy wrote: > > On 13/02/2020 9:49 pm, Rob Herring wrote: > > On Thu, Jan 30, 2020 at 11:34 AM Robin Murphy wrote: > >> > >> On 30/01/2020 3:06 pm, Auger Eric wrote: > >>> Hi Rob, > >>> On 1/17/20

Re: [PATCH 01/11] dt-bindings: PCI: generic: Add ats-supported property

2020-02-19 Thread Rob Herring
--- > Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Rob Herring ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [RFC PATCH 00/11] Removing Calxeda platform support

2020-02-18 Thread Rob Herring
On Tue, Feb 18, 2020 at 12:14 PM Andre Przywara wrote: > > On Tue, 18 Feb 2020 11:13:10 -0600 > Rob Herring wrote: > > Hi, > > > Calxeda has been defunct for 6 years now. Use of Calxeda servers carried > > on for some time afterwards primarily as distro builders fo

Re: [RFC PATCH 11/11] dt-bindings: Remove Calxeda platforms bindings

2020-02-18 Thread Rob Herring
On Tue, Feb 18, 2020 at 11:23 AM Will Deacon wrote: > > On Tue, Feb 18, 2020 at 11:13:21AM -0600, Rob Herring wrote: > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > .../devicetree/bindings/arm/calxeda.yaml | 22 -- &g

  1   2   3   4   >