Re: IOVA allocation dependency between firmware buffer and remaining buffers

2020-09-24 Thread Shaik Ameer Basha
Hi Robin and Marek, On Thu, Sep 24, 2020 at 4:36 PM Robin Murphy wrote: > > On 2020-09-24 11:47, Marek Szyprowski wrote: > > Hi Robin, > > > > On 24.09.2020 12:40, Robin Murphy wrote: > >> On 2020-09-24 11:16, Thierry Reding wrote: > >>> On Thu, Sep 24, 2020 at 10:46:46AM +0200, Marek

Re: IOVA allocation dependency between firmware buffer and remaining buffers

2020-04-24 Thread Shaik Ameer Basha
On Fri, Apr 24, 2020 at 8:59 PM Robin Murphy wrote: > > On 2020-04-24 4:04 pm, Ajay kumar wrote: > > Can someone check this? > > > > On Mon, Apr 20, 2020 at 9:24 PM Ajay kumar wrote: > >> > >> Hi All, > >> > >> I have an IOMMU master which has limitations as mentioned below: > >> 1) The IOMMU

[PATCH] documentation/iommu: Add note on existing DT binding status

2014-05-13 Thread Shaik Ameer Basha
The current dt binding for Exynos System MMU can be changed, if found incompatible with the support for Generic IOMMU Binding. This patch adds a note to the binding documentation stating the same. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- .../devicetree/bindings/iommu/samsung

Re: [PATCH v13 00/19] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-13 Thread Shaik Ameer Basha
On Tue, May 13, 2014 at 10:50 PM, Joerg Roedel j...@8bytes.org wrote: On Mon, May 12, 2014 at 11:44:45AM +0530, Shaik Ameer Basha wrote: Cho KyongHo (18): iommu/exynos: fix build errors iommu/exynos: change error handling when page table update is failed iommu/exynos: allocate lv2 page

[PATCH v13 03/19] iommu/exynos: allocate lv2 page table from own slab

2014-05-12 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Since kmalloc() does not guarantee that the allignment of 1KiB when it allocates 1KiB, it is required to allocate lv2 page table from own slab that guarantees alignment of 1KiB Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer

[PATCH v13 01/19] iommu/exynos: fix build errors

2014-05-12 Thread Shaik Ameer Basha
KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 255 ++ 1 file changed, 85 insertions(+), 170 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index

[PATCH v13 04/19] iommu/exynos: fix L2TLB invalidation

2014-05-12 Thread Shaik Ameer Basha
the target translation information to guarantee that the L2TLB has no stale data. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 32 +++- 1 file changed, 27 insertions(+), 5

[PATCH v13 08/19] iommu/exynos: remove dbgname from drvdata of a System MMU

2014-05-12 Thread Shaik Ameer Basha
-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 32 +--- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index ef771a2..be7a7b9 100644 --- a/drivers/iommu/exynos

[PATCH v13 17/19] iommu/exynos: support for device tree

2014-05-12 Thread Shaik Ameer Basha
-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 283 +++--- 1 file changed, 158 insertions(+), 125 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos

[PATCH v13 14/19] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2014-05-12 Thread Shaik Ameer Basha
From: Antonios Motakis a.mota...@virtualopensystems.com Patch written by Antonios Motakis a.mota...@virtualopensystems.com: IOMMU groups are expected by certain users of the IOMMU API, e.g. VFIO. Since each device is behind its own System MMU, we can allocate a new IOMMU group for each device.

[PATCH v13 13/19] iommu/exynos: use exynos-iommu specific typedef

2014-05-12 Thread Shaik Ameer Basha
from 32 bit to 64 bit. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 101 -- 1 file changed, 59 insertions(+), 42 deletions(-) diff --git a/drivers/iommu/exynos

[PATCH v13 16/19] documentation: iommu: add binding document of Exynos System MMU

2014-05-12 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This patch adds a description of the device tree binding for the Samsung Exynos System MMU. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- .../devicetree/bindings/iommu/samsung,sysmmu.txt

[PATCH v13 11/19] iommu/exynos: remove custom fault handler

2014-05-12 Thread Shaik Ameer Basha
Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 80 +- 1 file changed, 24 insertions(+), 56 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index 5af5c5c..c1be65f 100644 --- a/drivers/iommu/exynos

[PATCH v13 00/19] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-05-12 Thread Shaik Ameer Basha
comments from 'Sachin Kamat', 'Tomasz Figa' and 'Shaik Ameer Basha' - Uses macro names instead of magic numbers for clock description in DT - Moved DT binding document to seperate patch - dtsi changes are separated into multiple patches - patch description of some patches are updated according

[PATCH v13 05/19] iommu/exynos: remove prefetch buffer setting

2014-05-12 Thread Shaik Ameer Basha
of System MMU v3. Prefetch buffers must be controled with care because there are some restrictions in H/W design. The interface and implementation to initiate prefetch buffers will be prepared later. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com

[PATCH v13 07/19] iommu/exynos: always enable runtime PM

2014-05-12 Thread Shaik Ameer Basha
to remove the condition to see if the probing device has a parent device. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iommu

[PATCH v13 15/19] iommu/exynos: enhanced error messages

2014-05-12 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Some redundant error message is removed and some error messages are changed to error level from debug level. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c

[PATCH v13 02/19] iommu/exynos: change error handling when page table update is failed

2014-05-12 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This patch changes not to panic on any error when updating page table. Instead prints error messages with callstack. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos

[PATCH v13 10/19] iommu/exynos: gating clocks of master H/W

2014-05-12 Thread Shaik Ameer Basha
control registers of System MMU is prohibited unless both of the gating clocks of System MMU and its master H/W. CC: Tomasz Figa t.f...@samsung.com Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 40

[PATCH v13 12/19] iommu/exynos: change rwlock to spinlock

2014-05-12 Thread Shaik Ameer Basha
-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index c1be65f..d89ad5f 100644 --- a/drivers/iommu/exynos-iommu.c

[PATCH v13 06/19] iommu/exynos: add missing cache flush for removed page table entries

2014-05-12 Thread Shaik Ameer Basha
t.f...@samsung.com Tested-by: Grant Grundler grund...@chromium.org Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/exynos-iommu.c b

[PATCH v13 19/19] iommu/exynos: apply workaround of caching fault page table entries

2014-05-12 Thread Shaik Ameer Basha
32 page table entries. This is the size between 256K ~ 384K. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 163 +- 1 file changed, 146 insertions(+), 17

[PATCH v13 18/19] iommu/exynos: turn on useful configuration options

2014-05-12 Thread Shaik Ameer Basha
is ignored. This patch also adds simplifies the sysmmu version checking by introducing some macros. Signed-off-by: Cho KyongHo pullip@samsung.com Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com --- drivers/iommu/exynos-iommu.c | 38 ++ 1 file

Re: [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-04-30 Thread Shaik Ameer Basha
On Mon, Apr 28, 2014 at 2:04 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 27 April 2014 13:07:32 Shaik Ameer Basha wrote: The current exynos-iommu(System MMU) driver does not work autonomously since it is lack of support for power management of peripheral blocks. For example, MFC device

[PATCH v12 03/31] iommu/exynos: change error handling when page table update is failed

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This patch changes not to panic on any error when updating page table. Instead prints error messages with callstack. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 58 -- 1

[PATCH v12 02/31] iommu/exynos: add missing cache flush for removed page table entries

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This commit adds cache flush for removed small and large page entries in exynos_iommu_unmap(). Missing cache flush of removed page table entries can cause missing page fault interrupt when a master IP accesses an unmapped area. Reviewed-by: Tomasz Figa

[PATCH v12 04/31] iommu/exynos: fix L2TLB invalidation

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com L2TLB is 8-way set-associative TLB with 512 entries. The number of sets is 64. A single 4KB(small page) translation information is cached only to a set whose index is the same with the lower 6 bits of the page frame number. A single 64KB(large page)

[PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-04-27 Thread Shaik Ameer Basha
fixes and enhancements of the current driver. Change log: v12: - Rebased to the latest 3.15-rc2 master branch git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master (3.15-rc2) - Addressed v11 review comments from 'Sachin Kamat', 'Tomasz Figa' and 'Shaik Ameer Basha' - Uses

[PATCH v12 01/31] iommu/exynos: do not include removed header

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without removing remaining use of it from exynos-iommu driver, thus causing a compilation error. This patch fixes the

[PATCH v12 07/31] iommu/exynos: always enable runtime PM

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Checking if the probing device has a parent device was just to discover if the probing device is involved in a power domain when the power domain controlled by Samsung's custom implementation. Since generic IO power domain is applied, it is required to

[PATCH v12 08/31] iommu/exynos: handle one instance of sysmmu with a device descriptor

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com System MMU driver is changed to control only a single instance of System MMU at a time. Since a single instance of System MMU has only a single clock descriptor for its clock gating, single address range for control registers, there is no need to obtain

[PATCH v12 06/31] iommu/exynos: allocate lv2 page table from own slab

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Since kmalloc() does not guarantee that the allignment of 1KiB when it allocates 1KiB, it is required to allocate lv2 page table from own slab that guarantees alignment of 1KiB Signed-off-by: Cho KyongHo pullip@samsung.com ---

[PATCH v12 19/31] iommu/exynos: change rwlock to spinlock

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Since acquiring read_lock is not more frequent than write_lock, it is not beneficial to use rwlock, this commit changes rwlock to spinlock. Reviewed-by: Grant Grundler grund...@chromium.org Signed-off-by: Cho KyongHo pullip@samsung.com ---

[PATCH v12 16/31] iommu/exynos: turn on useful configuration options

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This turns on FLPD_CACHE, ACGEN and SYSSEL. FLPD_CACHE is a cache of 1st level page table entries that contains the address of a 2nd level page table to reduce latency of page table walking. ACGEN is architectural clock gating that gates clocks by System

[PATCH v12 21/31] iommu/exynos: fix address handling

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Use of __pa and __va macro is changed to virt_to_phys and phys_to_virt which are recommended in driver code. printk formatting of physical address is also fixed to %pa. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c |

[PATCH v12 10/31] iommu/exynos: use managed device helper functions

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This patch uses managed device helper functions in the probe(). Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 68 -- 1 file changed, 25 insertions(+), 43 deletions(-) diff

[PATCH v12 14/31] iommu/exynos: remove custom fault handler

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This commit removes custom fault handler. The device drivers that need to register fault handler can register with iommu_set_fault_handler(). CC: Grant Grundler grund...@chromium.org Signed-off-by: Cho KyongHo pullip@samsung.com ---

[PATCH v12 23/31] iommu/exynos: use simpler function to get MMU version

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This commit changes the function to get MMU version simpler. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 30 ++ 1 file changed, 6 insertions(+), 24 deletions(-) diff --git

[PATCH v12 29/31] ARM: dts: add System MMU nodes of exynos4x12

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This patch adds System MMU nodes that are specifict to exynos4x12 series. Signed-off-by: Cho KyongHo pullip@samsung.com --- arch/arm/boot/dts/exynos4x12.dtsi | 78 - 1 file changed, 77 insertions(+), 1

[PATCH v12 24/31] iommu/exynos: apply workaround of caching fault page table entries

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This patch contains 2 workaround for the System MMU v3.x. System MMU v3.2 and v3.3 has FLPD cache that caches first level page table entries to reduce page table walking latency. However, the FLPD cache is filled with a first level page table entry even

[PATCH v12 28/31] ARM: dts: add System MMU nodes of exynos4210

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This patch adds System MMUs that are specific to exynos4210. Signed-off-by: Cho KyongHo pullip@samsung.com --- arch/arm/boot/dts/exynos4210.dtsi | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git

[PATCH v12 22/31] iommu/exynos: use exynos-iommu specific typedef

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This commit introduces sysmmu_pte_t for page table entries and sysmmu_iova_t vor I/O virtual address that is manipulated by exynos-iommu driver. The purpose of the typedef is to remove dependencies to the driver code from the change of CPU architecture

[PATCH v12 25/31] iommu/exynos: enhanced error messages

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Some redundant error message is removed and some error messages are changed to error level from debug level. Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/iommu/exynos-iommu.c | 23 +-- 1 file changed, 9

[PATCH v12 30/31] ARM: dts: add System MMU nodes of exynos5250

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com Signed-off-by: Cho KyongHo pullip@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 270 - 1 file changed, 267 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi

[PATCH v12 26/31] clk: exynos: add gate clock descriptions of System MMU

2014-04-27 Thread Shaik Ameer Basha
From: Cho KyongHo pullip@samsung.com This adds gate clocks of all System MMUs and their master IPs that are not apeared in clk-exynos5250.c and clk-exynos5420.c Signed-off-by: Cho KyongHo pullip@samsung.com --- drivers/clk/samsung/clk-exynos5250.c | 36

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-04-22 Thread Shaik Ameer Basha
before using? i = 0; Regards, Shaik Ameer Basha + struct platform_device *master = of_find_device_by_node(node); + struct exynos_iommu_owner *owner; + struct sysmmu_list_data *list_data; - platform_set_drvdata(pdev, data

Re: [PATCH v11 12/27] ARM: dts: Add description of System MMU of Exynos SoCs

2014-04-21 Thread Shaik Ameer Basha
402, clock 401; Regards, Shaik Ameer Basha ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu