[PATCH v2] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE
Take into account that sg->offset can be bigger than PAGE_SIZE when
setting segment sg->dma_address. Otherwise sg->dma_address will point
at diffrent page, what makes DMA not possible with erros like this:
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa70c0 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7040 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7080 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7100 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7000 flags=0x0020]
Additinally with wrong sg->dma_address unmap_sg will free wrong pages,
what what can cause crashes like this:
Feb 28 19:27:45 kernel: BUG: Bad page state in process cinnamon pfn:39e8b1
Feb 28 19:27:45 kernel: Disabling lock debugging due to kernel taint
Feb 28 19:27:45 kernel: flags: 0x200()
Feb 28 19:27:45 kernel: raw: 0200 0301
Feb 28 19:27:45 kernel: raw: 0001
Feb 28 19:27:45 kernel: page dumped because: nonzero _refcount
Feb 28 19:27:45 kernel: Modules linked in: ccm fuse arc4 nct6775 hwmon_vid
amdgpu nls_iso8859_1 nls_cp437 edac_mce_amd vfat fat kvm_amd ccp rng_core kvm
mt76x0u mt76x0_common mt76x02_usb irqbypass mt76_usb mt76x02_lib mt76
crct10dif_pclmul crc32_pclmul chash mac80211 amd_iommu_v2 ghash_clmulni_intel
gpu_sched i2c_algo_bit ttm wmi_bmof snd_hda_codec_realtek snd_hda_codec_generic
drm_kms_helper snd_hda_codec_hdmi snd_hda_intel drm snd_hda_codec aesni_intel
snd_hda_core snd_hwdep aes_x86_64 crypto_simd snd_pcm cfg80211 cryptd mousedev
snd_timer glue_helper pcspkr r8169 input_leds realtek agpgart libphy rfkill snd
syscopyarea sysfillrect sysimgblt fb_sys_fops soundcore sp5100_tco k10temp
i2c_piix4 wmi evdev gpio_amdpt pinctrl_amd mac_hid pcc_cpufreq acpi_cpufreq sg
ip_tables x_tables ext4(E) crc32c_generic(E) crc16(E) mbcache(E) jbd2(E)
fscrypto(E) sd_mod(E) hid_generic(E) usbhid(E) hid(E) dm_mod(E) serio_raw(E)
atkbd(E) libps2(E) crc32c_intel(E) ahci(E) libahci(E) libata(E) xhci
_pci(E) xhci_hcd(E)
Feb 28 19:27:45 kernel: scsi_mod(E) i8042(E) serio(E) bcache(E) crc64(E)
Feb 28 19:27:45 kernel: CPU: 2 PID: 896 Comm: cinnamon Tainted: GB W E
4.20.12-arch1-1-custom #1
Feb 28 19:27:45 kernel: Hardware name: To Be Filled By O.E.M. To Be Filled By
O.E.M./B450M Pro4, BIOS P1.20 06/26/2018
Feb 28 19:27:45 kernel: Call Trace:
Feb 28 19:27:45 kernel: dump_stack+0x5c/0x80
Feb 28 19:27:45 kernel: bad_page.cold.29+0x7f/0xb2
Feb 28 19:27:45 kernel: __free_pages_ok+0x2c0/0x2d0
Feb 28 19:27:45 kernel: skb_release_data+0x96/0x180
Feb 28 19:27:45 kernel: __kfree_skb+0xe/0x20
Feb 28 19:27:45 kernel: tcp_recvmsg+0x894/0xc60
Feb 28 19:27:45 kernel: ? reuse_swap_page+0x120/0x340
Feb 28 19:27:45 kernel: ? ptep_set_access_flags+0x23/0x30
Feb 28 19:27:45 kernel: inet_recvmsg+0x5b/0x100
Feb 28 19:27:45 kernel: __sys_recvfrom+0xc3/0x180
Feb 28 19:27:45 kernel: ? handle_mm_fault+0x10a/0x250
Feb 28 19:27:45 kernel: ? syscall_trace_enter+0x1d3/0x2d0
Feb 28 19:27:45 kernel: ? __audit_syscall_exit+0x22a/0x290
Feb 28 19:27:45 kernel: __x64_sys_recvfrom+0x24/0x30
Feb 28 19:27:45 kernel: do_syscall_64+0x5b/0x170
Feb 28 19:27:45 kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9
Cc: sta...@vger.kernel.org
Reported-and-tested-by: Jan Viktorin
Reviewed-by: Alexander Duyck
Signed-off-by: Stanislaw Gruszka
---
v2: add comment
drivers/iommu/amd_iommu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 6b0760dafb3e..696c78225dd1 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2604,7 +2604,11 @@ static int map_sg(struct device *dev, struct scatterlist
*sglist,
/* Everything is mapped - write the right values into s->dma_address */
for_each_sg(sglist, s, nelems, i) {
- s->dma_address += address + s->offset;
+ /* Add in the remaining piece of the scatter-gather offset that
+* was masked out when we were determining the physical address
+* via (sg_phys(s) & PAGE_MASK) earlier.
+*/
+ s->dma_address += address + (s->offset & ~PAGE_MASK);
s->dma_length = s->length;
}
--
2.7.5
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Mon, Mar 11, 2019 at 09:43:19AM +0100, Stanislaw Gruszka wrote: > > > However after fixing that mt76usb still did not work. To make things > > > work we had to change rx frag size from 2048 to PAGE_SIZE and change > > > virt_to_head_page() to virt_to_page() when setting SG's. > > > > > I think I understand why first change was needed. If we do 2 separate > > > dma maps of 2 different buffers in single page i.e (PAGE + off=0 > > > and PAGE + off=2048) it causes problem. So either map_sg() return > > > error which mt76usb does not handle correctly or there is issue > > > in AMD IOMMU because two dma maps use the same page. > > Any comment on that? Is fine or not to do 2 or more dma mappings > within the same single page on AMD IOMMU? If not, is there any > mechanism for drivers to find out about this limitation to prevent > to prepare wrong SG buffers? FTR: it was confirmed by Jan (bug reporter) the 2 or more dma mappings within single page works with AMD IOMMU. Most likely it was needed previously to workaround this sg->offset problem until proper fix to AMD IOMMU was applied. Stanislaw ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE
On Mon, Mar 11, 2019 at 08:47:44AM -0700, Alexander Duyck wrote:
> > drivers/iommu/amd_iommu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> > index 6b0760dafb3e..949621f33624 100644
> > --- a/drivers/iommu/amd_iommu.c
> > +++ b/drivers/iommu/amd_iommu.c
> > @@ -2604,7 +2604,7 @@ static int map_sg(struct device *dev, struct
> > scatterlist *sglist,
> >
> > /* Everything is mapped - write the right values into s->dma_address */
> > for_each_sg(sglist, s, nelems, i) {
> > - s->dma_address += address + s->offset;
> > + s->dma_address += address + (s->offset & ~PAGE_MASK);
> > s->dma_length = s->length;
> > }
> >
>
> You should add a comment calling out that this is needed because the
> sg_phys(s) call above this is masked with PAGE_MASK. Then this makes
> much more sense. Otherwise I would have assumed you needed either the
> full offset or none.
Would something like this
/*
* Everything is mapped - write the right values into s->dma_address.
* Take into account s->offset can be bigger than page size and sg_phys(s)
* address has to be aligned to page granularity.
*/
be appropriate ?
Stanislaw
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH] iommu/amd: fix sg->dma_address for sg->offset bigger than PAGE_SIZE
Take into account that sg->offset can be bigger than PAGE_SIZE when
setting segment sg->dma_address. Otherwise sg->dma_address will point
at diffrent page, what makes DMA not possible with erros like this:
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa70c0 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7040 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7080 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7100 flags=0x0020]
xhci_hcd :38:00.3: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x
address=0xfdaa7000 flags=0x0020]
Additinally with wrong sg->dma_address unmap_sg will free wrong pages,
what what can cause crashes like this:
Feb 28 19:27:45 kernel: BUG: Bad page state in process cinnamon pfn:39e8b1
Feb 28 19:27:45 kernel: Disabling lock debugging due to kernel taint
Feb 28 19:27:45 kernel: flags: 0x200()
Feb 28 19:27:45 kernel: raw: 0200 0301
Feb 28 19:27:45 kernel: raw: 0001
Feb 28 19:27:45 kernel: page dumped because: nonzero _refcount
Feb 28 19:27:45 kernel: Modules linked in: ccm fuse arc4 nct6775 hwmon_vid
amdgpu nls_iso8859_1 nls_cp437 edac_mce_amd vfat fat kvm_amd ccp rng_core kvm
mt76x0u mt76x0_common mt76x02_usb irqbypass mt76_usb mt76x02_lib mt76
crct10dif_pclmul crc32_pclmul chash mac80211 amd_iommu_v2 ghash_clmulni_intel
gpu_sched i2c_algo_bit ttm wmi_bmof snd_hda_codec_realtek snd_hda_codec_generic
drm_kms_helper snd_hda_codec_hdmi snd_hda_intel drm snd_hda_codec aesni_intel
snd_hda_core snd_hwdep aes_x86_64 crypto_simd snd_pcm cfg80211 cryptd mousedev
snd_timer glue_helper pcspkr r8169 input_leds realtek agpgart libphy rfkill snd
syscopyarea sysfillrect sysimgblt fb_sys_fops soundcore sp5100_tco k10temp
i2c_piix4 wmi evdev gpio_amdpt pinctrl_amd mac_hid pcc_cpufreq acpi_cpufreq sg
ip_tables x_tables ext4(E) crc32c_generic(E) crc16(E) mbcache(E) jbd2(E)
fscrypto(E) sd_mod(E) hid_generic(E) usbhid(E) hid(E) dm_mod(E) serio_raw(E)
atkbd(E) libps2(E) crc32c_intel(E) ahci(E) libahci(E) libata(E) xhci
_pci(E) xhci_hcd(E)
Feb 28 19:27:45 kernel: scsi_mod(E) i8042(E) serio(E) bcache(E) crc64(E)
Feb 28 19:27:45 kernel: CPU: 2 PID: 896 Comm: cinnamon Tainted: GB W E
4.20.12-arch1-1-custom #1
Feb 28 19:27:45 kernel: Hardware name: To Be Filled By O.E.M. To Be Filled By
O.E.M./B450M Pro4, BIOS P1.20 06/26/2018
Feb 28 19:27:45 kernel: Call Trace:
Feb 28 19:27:45 kernel: dump_stack+0x5c/0x80
Feb 28 19:27:45 kernel: bad_page.cold.29+0x7f/0xb2
Feb 28 19:27:45 kernel: __free_pages_ok+0x2c0/0x2d0
Feb 28 19:27:45 kernel: skb_release_data+0x96/0x180
Feb 28 19:27:45 kernel: __kfree_skb+0xe/0x20
Feb 28 19:27:45 kernel: tcp_recvmsg+0x894/0xc60
Feb 28 19:27:45 kernel: ? reuse_swap_page+0x120/0x340
Feb 28 19:27:45 kernel: ? ptep_set_access_flags+0x23/0x30
Feb 28 19:27:45 kernel: inet_recvmsg+0x5b/0x100
Feb 28 19:27:45 kernel: __sys_recvfrom+0xc3/0x180
Feb 28 19:27:45 kernel: ? handle_mm_fault+0x10a/0x250
Feb 28 19:27:45 kernel: ? syscall_trace_enter+0x1d3/0x2d0
Feb 28 19:27:45 kernel: ? __audit_syscall_exit+0x22a/0x290
Feb 28 19:27:45 kernel: __x64_sys_recvfrom+0x24/0x30
Feb 28 19:27:45 kernel: do_syscall_64+0x5b/0x170
Feb 28 19:27:45 kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9
Cc: sta...@vger.kernel.org
Reported-and-tested-by: jan.vikto...@gmail.com
Signed-off-by: Stanislaw Gruszka
---
drivers/iommu/amd_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 6b0760dafb3e..949621f33624 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2604,7 +2604,7 @@ static int map_sg(struct device *dev, struct scatterlist
*sglist,
/* Everything is mapped - write the right values into s->dma_address */
for_each_sg(sglist, s, nelems, i) {
- s->dma_address += address + s->offset;
+ s->dma_address += address + (s->offset & ~PAGE_MASK);
s->dma_length = s->length;
}
--
2.7.5
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Sun, Mar 03, 2019 at 11:20:45PM -0800, Rosen Penev wrote:
> On Sun, Mar 3, 2019 at 11:10 PM Stanislaw Gruszka wrote:
> >
> > On Thu, Feb 28, 2019 at 02:40:29PM +0100, Joerg Roedel wrote:
> > > On Thu, Feb 28, 2019 at 01:19:48PM +0100, Stanislaw Gruszka wrote:
> > > > Nevermind, the patch is wrong, s->dma_address is initalized in
> > > > sg_num_pages().
> > >
> > > Yes, it is. In sg_num_pages() the offset into the IOMMU mapping is
> > > stored in s->dma_address, taking also the segment boundary mask into
> > > account. map_sg() later only adds the base-address to that.
> >
> > I have some more info about the issues in
> > https://bugzilla.kernel.org/show_bug.cgi?id=202673
> >
> > We have some bugs in mt76. Apparently we should not use
> > page_frag_alloc() with size bigger than PAGE_SIZE as page_frag_alloc()
> > can fallback to single page allocation. And also we should not make
> > sizes unaligned as pointed in commit:
> > 3bed3cc4156e ("net: Do not allocate page fragments that are not skb aligned"
> As a small and totally unrelated note, page_frag_alloc is only used in
> mt76 and the nvme driver ;)
And there is nvme problem on AMD IOMMU:
https://bugzilla.kernel.org/show_bug.cgi?id=202665
While page_frag_alloc() should be used with cautious, at least care of
size alignment with ARCH_DMA_MINALIGN (not for IOMMU, but standard arch
dma), at this point I think some of those issues are AMD IOMMU problems.
> > However after fixing that mt76usb still did not work. To make things
> > work we had to change rx frag size from 2048 to PAGE_SIZE and change
> > virt_to_head_page() to virt_to_page() when setting SG's.
>
> > I think I understand why first change was needed. If we do 2 separate
> > dma maps of 2 different buffers in single page i.e (PAGE + off=0
> > and PAGE + off=2048) it causes problem. So either map_sg() return
> > error which mt76usb does not handle correctly or there is issue
> > in AMD IOMMU because two dma maps use the same page.
Any comment on that? Is fine or not to do 2 or more dma mappings
within the same single page on AMD IOMMU? If not, is there any
mechanism for drivers to find out about this limitation to prevent
to prepare wrong SG buffers?
> > But I don't understand why the second change was needed. Without
> > it we have issue with incorrect page->_refcount . It is somehow
> > related with AMD IOMMU, because on different platforms we do not
> > have such problems.
I think I found a bug in amd iommu code when setting sg->dma_address
with sg->offset > PAGE_SIZE. Will post fix shortly.
Stanislaw
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Thu, Feb 28, 2019 at 02:40:29PM +0100, Joerg Roedel wrote:
> On Thu, Feb 28, 2019 at 01:19:48PM +0100, Stanislaw Gruszka wrote:
> > Nevermind, the patch is wrong, s->dma_address is initalized in
> > sg_num_pages().
>
> Yes, it is. In sg_num_pages() the offset into the IOMMU mapping is
> stored in s->dma_address, taking also the segment boundary mask into
> account. map_sg() later only adds the base-address to that.
I have some more info about the issues in
https://bugzilla.kernel.org/show_bug.cgi?id=202673
We have some bugs in mt76. Apparently we should not use
page_frag_alloc() with size bigger than PAGE_SIZE as page_frag_alloc()
can fallback to single page allocation. And also we should not make
sizes unaligned as pointed in commit:
3bed3cc4156e ("net: Do not allocate page fragments that are not skb aligned"
However after fixing that mt76usb still did not work. To make things
work we had to change rx frag size from 2048 to PAGE_SIZE and change
virt_to_head_page() to virt_to_page() when setting SG's.
I think I understand why first change was needed. If we do 2 separate
dma maps of 2 different buffers in single page i.e (PAGE + off=0
and PAGE + off=2048) it causes problem. So either map_sg() return
error which mt76usb does not handle correctly or there is issue
in AMD IOMMU because two dma maps use the same page.
But I don't understand why the second change was needed. Without
it we have issue with incorrect page->_refcount . It is somehow
related with AMD IOMMU, because on different platforms we do not
have such problems.
Joerg, could you look at this ? Thanks.
Stanislaw
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Thu, Feb 28, 2019 at 11:42:24AM +0100, Stanislaw Gruszka wrote: > On Thu, Feb 28, 2019 at 10:04:12AM +0100, Stanislaw Gruszka wrote: > > On Tue, Feb 26, 2019 at 12:24:08PM +0100, Stanislaw Gruszka wrote: > > > On Tue, Feb 26, 2019 at 11:44:13AM +0100, Joerg Roedel wrote: > > > > On Tue, Feb 26, 2019 at 11:34:51AM +0100, Stanislaw Gruszka wrote: > > > > > On Tue, Feb 26, 2019 at 11:05:36AM +0100, Joerg Roedel wrote: > > > > > If sg->offset > PAGE_SIZE is fine then most likely we have problem > > > > > with > > > > > alignment. > > > > > > > > The map_sg implementation in the AMD IOMMU driver uses sg_phys() which > > > > handles the sg->page + sg->offset calculation fine. > > > > > > > > > Note hat issue is with dma_map_sg(), switching to dma_map_single() > > > > > by using urb->transfer_buffer instead of urb->sg make things work > > > > > on AMD IOMMU. > > > > > > > > On the other hand this points to a bug in the driver, I'll look further > > > > if I can spot something there. > > > > > > I think so too. And I have done some changes that avoid strange allocation > > > scheme and use usb synchronous messages instead of allocating buffers > > > with unaligned sizes. However things work ok on Intel IOMMU and > > > there is no documentation what are dma_map_sg() requirement versus > > > dma_map_single() which works. I think there are some unwritten > > > requirements and things can work on some platforms and fails on others > > > (different IOMMUs, no-IOMMU on some ARCHes) > > > > For the record: we have another bug report with this issue: > > https://bugzilla.kernel.org/show_bug.cgi?id=202673 > > > > I provided there patch that change alignment for page_frag_alloc() and > > it did not fixed the problem. So this is not alignment issue. > > Now I think it could be page->refcount issue ... > > I looked at the map_sg() in amd_iommu.c code and one line looks suspicious > to me, seems we can use not correctly initialized s->dma_address (should be 0, > but I think can be non-zero if SG was reused). The code also seems do > not do correct thing if there is more than one SG with multiple pages > on individual segments. Something like in below patch seems to be more > appropriate to me (not tested nor compiled). Nevermind, the patch is wrong, s->dma_address is initalized in sg_num_pages(). Stanislaw ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Thu, Feb 28, 2019 at 10:04:12AM +0100, Stanislaw Gruszka wrote:
> On Tue, Feb 26, 2019 at 12:24:08PM +0100, Stanislaw Gruszka wrote:
> > On Tue, Feb 26, 2019 at 11:44:13AM +0100, Joerg Roedel wrote:
> > > On Tue, Feb 26, 2019 at 11:34:51AM +0100, Stanislaw Gruszka wrote:
> > > > On Tue, Feb 26, 2019 at 11:05:36AM +0100, Joerg Roedel wrote:
> > > > If sg->offset > PAGE_SIZE is fine then most likely we have problem with
> > > > alignment.
> > >
> > > The map_sg implementation in the AMD IOMMU driver uses sg_phys() which
> > > handles the sg->page + sg->offset calculation fine.
> > >
> > > > Note hat issue is with dma_map_sg(), switching to dma_map_single()
> > > > by using urb->transfer_buffer instead of urb->sg make things work
> > > > on AMD IOMMU.
> > >
> > > On the other hand this points to a bug in the driver, I'll look further
> > > if I can spot something there.
> >
> > I think so too. And I have done some changes that avoid strange allocation
> > scheme and use usb synchronous messages instead of allocating buffers
> > with unaligned sizes. However things work ok on Intel IOMMU and
> > there is no documentation what are dma_map_sg() requirement versus
> > dma_map_single() which works. I think there are some unwritten
> > requirements and things can work on some platforms and fails on others
> > (different IOMMUs, no-IOMMU on some ARCHes)
>
> For the record: we have another bug report with this issue:
> https://bugzilla.kernel.org/show_bug.cgi?id=202673
>
> I provided there patch that change alignment for page_frag_alloc() and
> it did not fixed the problem. So this is not alignment issue.
> Now I think it could be page->refcount issue ...
I looked at the map_sg() in amd_iommu.c code and one line looks suspicious
to me, seems we can use not correctly initialized s->dma_address (should be 0,
but I think can be non-zero if SG was reused). The code also seems do
not do correct thing if there is more than one SG with multiple pages
on individual segments. Something like in below patch seems to be more
appropriate to me (not tested nor compiled).
Stanislaw
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 34c9aa76a7bd..9c8887250b82 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2517,6 +2517,7 @@ static int map_sg(struct device *dev, struct scatterlist
*sglist,
prot = dir2prot(direction);
/* Map all sg entries */
+ npages = 0;
for_each_sg(sglist, s, nelems, i) {
int j, pages = iommu_num_pages(sg_phys(s), s->length,
PAGE_SIZE);
@@ -2524,7 +2525,7 @@ static int map_sg(struct device *dev, struct scatterlist
*sglist,
unsigned long bus_addr, phys_addr;
int ret;
- bus_addr = address + s->dma_address + (j <<
PAGE_SHIFT);
+ bus_addr = address + ((npages + j) << PAGE_SHIFT);
phys_addr = (sg_phys(s) & PAGE_MASK) + (j <<
PAGE_SHIFT);
ret = iommu_map_page(domain, bus_addr, phys_addr,
PAGE_SIZE, prot, GFP_ATOMIC);
if (ret)
@@ -2532,6 +2533,8 @@ static int map_sg(struct device *dev, struct scatterlist
*sglist,
mapped_pages += 1;
}
+
+ npages += mapped_pages;
}
/* Everything is mapped - write the right values into s->dma_address */
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Tue, Feb 26, 2019 at 12:24:08PM +0100, Stanislaw Gruszka wrote: > On Tue, Feb 26, 2019 at 11:44:13AM +0100, Joerg Roedel wrote: > > On Tue, Feb 26, 2019 at 11:34:51AM +0100, Stanislaw Gruszka wrote: > > > On Tue, Feb 26, 2019 at 11:05:36AM +0100, Joerg Roedel wrote: > > > If sg->offset > PAGE_SIZE is fine then most likely we have problem with > > > alignment. > > > > The map_sg implementation in the AMD IOMMU driver uses sg_phys() which > > handles the sg->page + sg->offset calculation fine. > > > > > Note hat issue is with dma_map_sg(), switching to dma_map_single() > > > by using urb->transfer_buffer instead of urb->sg make things work > > > on AMD IOMMU. > > > > On the other hand this points to a bug in the driver, I'll look further > > if I can spot something there. > > I think so too. And I have done some changes that avoid strange allocation > scheme and use usb synchronous messages instead of allocating buffers > with unaligned sizes. However things work ok on Intel IOMMU and > there is no documentation what are dma_map_sg() requirement versus > dma_map_single() which works. I think there are some unwritten > requirements and things can work on some platforms and fails on others > (different IOMMUs, no-IOMMU on some ARCHes) For the record: we have another bug report with this issue: https://bugzilla.kernel.org/show_bug.cgi?id=202673 I provided there patch that change alignment for page_frag_alloc() and it did not fixed the problem. So this is not alignment issue. Now I think it could be page->refcount issue ... Stanislaw ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Tue, Feb 26, 2019 at 11:44:13AM +0100, Joerg Roedel wrote: > On Tue, Feb 26, 2019 at 11:34:51AM +0100, Stanislaw Gruszka wrote: > > On Tue, Feb 26, 2019 at 11:05:36AM +0100, Joerg Roedel wrote: > > If sg->offset > PAGE_SIZE is fine then most likely we have problem with > > alignment. > > The map_sg implementation in the AMD IOMMU driver uses sg_phys() which > handles the sg->page + sg->offset calculation fine. > > > Note hat issue is with dma_map_sg(), switching to dma_map_single() > > by using urb->transfer_buffer instead of urb->sg make things work > > on AMD IOMMU. > > On the other hand this points to a bug in the driver, I'll look further > if I can spot something there. I think so too. And I have done some changes that avoid strange allocation scheme and use usb synchronous messages instead of allocating buffers with unaligned sizes. However things work ok on Intel IOMMU and there is no documentation what are dma_map_sg() requirement versus dma_map_single() which works. I think there are some unwritten requirements and things can work on some platforms and fails on others (different IOMMUs, no-IOMMU on some ARCHes) Stanislaw ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Tue, Feb 26, 2019 at 11:05:36AM +0100, Joerg Roedel wrote:
> On Mon, Feb 18, 2019 at 03:37:48PM +0100, Stanislaw Gruszka wrote:
> > 0001-mt76x02u-use-usb_bulk_msg-to-upload-firmware.patch
> > 0002-mt76usb-do-not-use-compound-head-page-for-SG-I-O.patch
> >
> > Or problem can be solved by just one of it (either first or second).
> >
> > Additionally I'm not 100% sure if
> >
> > 0002-mt76usb-do-not-use-compound-head-page-for-SG-I-O.patch
> >
> > is correct. So perhaps some IOMMU maintainer could look at it.
>
> The patch looks good, but I don't understand why it is needed. The AMD
> IOMMU driver should handle sg->offset > PAGE_SIZE just fine. Can you
> verify that this is the problem? I will look into that again if it turns
> out there is bug in the IOMMU driver.
I'm try to get that information from bug reporter, but I can't get it so
far.
If sg->offset > PAGE_SIZE is fine then most likely we have problem with
alignment. We use page_frag_alloc() in mt76usb for buffer allocation
in scheme like this
page_frag_alloc(max_payload); // something like 14434
page_frag_alloc(1024);
page_frag_alloc(2048)
page_frag_alloc(2048)
page_frag_alloc(2048)
...
page_frag_alloc works smart and fast way internally by allocating
fragments just but changing internal offset:
offset = nc->offset - fragsz;
if (unlikely(offset < 0)) {
page = virt_to_page(nc->va);
.
.
.
}
nc->offset = offset;
return nc->va + offset;
but unlike other allocators like kmalloc that make effort to provide
ARCH_DMA_MINALIGN buffers, it does not care about alignment. Above
scheme of allocation in mt76usb breaks it.
Note hat issue is with dma_map_sg(), switching to dma_map_single()
by using urb->transfer_buffer instead of urb->sg make things work
on AMD IOMMU.
Stanislaw
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
On Mon, Feb 18, 2019 at 05:01:59PM +, Robin Murphy wrote:
> On 18/02/2019 14:37, Stanislaw Gruszka wrote:
> [...]
> >Another issue is that dma_map_sg() & dma_map_page() may require some
> >constraints. I'm not sure about that and I want to clarify that with
> >CCed mm maintainers. I think DMA drivers may expect sg->offset < PAGE_SIZE
> >for both dma_map_sg() and dma_map_page(). Additionally dma_map_page()
> >maight expect that offset & length specify buffer within one page.
>
> Luckily, this came up a while back[1] and we seemed to reach a
> consensus that sg->offset >= PAGE_SIZE for dma_map_sg() was weird
> but valid. IIRC it was only the Intel IOMMU code which failed to
> handle that case appropriately (and which I fixed) - the AMD IOMMU
> code always looked like it should be OK, but I'm not sure I've ever
> seen definitive test results (and I don't have hardware to do so
> myself).
Funny that we have problems on AMD IOMMU and not with Intel IOMMU.
> For dma_map_page(), length >= PAGE_SIZE should be perfectly valid
> and handled correctly. The offset >= PAGE_SIZE case is a bit harder
> to justify, but at the same time has less scope for the DMA API
> backend to get it wrong, so either way is likely to be OK in
> practice (in particular the AMD IOMMU code looks like it won't have
> a problem, since its map_page() implementation converts page and
> offset to a plain physical address before doing anything else).
Thanks for clarify this. So my patch which do:
- page = virt_to_head_page(data);
+ page = virt_to_page(data);
offset = data - page_address(page);
sg_set_page(>sg[i], page, sglen, offset);
should not be necessary as IOMMU driver do exactly the same internally.
Are there any alignment requirement for offset for dma_map_{page,sg} ?
It will work with let say sg->offset=113 or we have make sure it is
aligned to some boundary. If so, what boundary ?
Stanislaw
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: MT76x2U crashes XHCI driver on AMD Ryzen system
(cc: IOMMU & page_frag_alloc maintainers) On Tue, Jan 15, 2019 at 10:04:01AM +0100, Lorenzo Bianconi wrote: > > On Mon, Jan 14, 2019 at 1:18 AM Lorenzo Bianconi > > wrote: > > > > > > > On Sun, Jan 13, 2019 at 11:00 AM Lorenzo Bianconi > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > On Sun, Jan 13, 2019 at 5:33 AM, Lorenzo Bianconi > > > > > > wrote: > > > > > > > > > > > > Direct. No VM used. This is the only peripheral causing this issue. > > > > > > > > > > > > Is the device connected to a usb3.0 port? If so, could you please > > > > > > try to connect the dongle to a 2.0 one? > > > > > > > > > > > > I tried through a USB 2.0 port. Shouldn't make a difference as they > > > > > > both use the xhci driver. > > > > > > > > > > > > > > > > mt76x2u supports scatter-gather on usb 3.0 (not on 2.0) > > > > Tried a USB 3 port. Same result. > > > > > > > > > > > Could you please double check if IOMMU is enabled? > > > > > > > > > > > > > > > > Have you tried to disable it? Does it make any difference? > > > > No idea how. UEFI doesn't seem to show anything similar. > > > > > > > > Similar bug report: https://bugzilla.kernel.org/show_bug.cgi?id=202241 FWIW: I provided some patches in the bugzilla, which were reported to solve the problem. But I looking for confirmation if both are needed: 0001-mt76x02u-use-usb_bulk_msg-to-upload-firmware.patch 0002-mt76usb-do-not-use-compound-head-page-for-SG-I-O.patch Or problem can be solved by just one of it (either first or second). Additionally I'm not 100% sure if 0002-mt76usb-do-not-use-compound-head-page-for-SG-I-O.patch is correct. So perhaps some IOMMU maintainer could look at it. > > > You should be able to disable iommu using GRUB_CMDLINE_LINUX in > > > /etc/default/grub (I guess setting iommu=off and reinstalling grub) > > > https://wiki.gentoo.org/wiki/IOMMU_SWIOTLB > > Yep. Working great now. I wonder what mt76 is doing to cause the crash > > though... > > Thanks for bisecting the issue. Lorenzo, what you mean by 'bisecting' here ? Someone did 'git bisect' on this issue? > I think amd iommu does not support well usb scatter-gather > (used by default in mt76u). I am working on a series in order to add the > possibility to > disable it. Even if that true that AMD IOMMU does not support 'well' SG (what I think is not true) disabling SG in mt76 driver is not right solution. Right solution would be propagate the issue to AMD IOMMU maintainers (already CCed). One problem in mt76 is page_frag_alloc() usage with different sizes. page_frag_alloc() unlike like other allocators do not assure alignment and relay on callers to provide buffers sizes that are aligned. Unaligned buffer might then not be appropriate for DMA. Another issue is that dma_map_sg() & dma_map_page() may require some constraints. I'm not sure about that and I want to clarify that with CCed mm maintainers. I think DMA drivers may expect sg->offset < PAGE_SIZE for both dma_map_sg() and dma_map_page(). Additionally dma_map_page() maight expect that offset & length specify buffer within one page. Stanislaw ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
