Re: [PATCH] dcdbas: Fix Intel-IOMMU domain allocation failure

2019-01-28 Thread Szabolcs Fruhwald via iommu
On Fri, Jan 25, 2019 at 5:12 AM Robin Murphy wrote: > > On 25/01/2019 11:58, Andy Shevchenko wrote: > > On Fri, Jan 25, 2019 at 3:50 AM Szabolcs Fruhwald > > wrote: > > > > First of all, please do not top post! > > > >> I took a quick look at arch_setup_pdev_archdata(), overridden it in > >> dcd

Re: [PATCH] dcdbas: Fix Intel-IOMMU domain allocation failure

2019-01-24 Thread Szabolcs Fruhwald via iommu
Hi Andy, I took a quick look at arch_setup_pdev_archdata(), overridden it in dcdbas.c and it works well (despite it's being called twice, since it's called from platform_device_alloc and platform_device_register). However, as I am not super familiar with ELF weak method references, especially wit

Re: [PATCH] dcdbas: Fix Intel-IOMMU domain allocation failure

2019-01-24 Thread Szabolcs Fruhwald via iommu
(+iommu list for visibility and confirmation of the intended constant externalization, see 2nd point below) Hi Mario, Thanks for your comments, see my answers inline below. On Thu, Jan 24, 2019 at 7:16 AM wrote: > > > -Original Message- > > From: platform-driver-x86-ow...@vger.kernel.org