Re: [PATCH 0/3] drm: panfrost: Coherency support

2020-09-17 Thread Tomeu Vizoso
On 9/17/20 12:38 PM, Steven Price wrote: On 16/09/2020 18:46, Rob Herring wrote: On Wed, Sep 16, 2020 at 11:04 AM Alyssa Rosenzweig wrote: So I get a performance regression with the dma-coherent approach, even if it's clearly the cleaner. That's bizarre -- this should really be the

Re: [PATCH 0/3] iommu/io-pgtable-arm: Mali LPAE improvements

2019-09-23 Thread Tomeu Vizoso
On Thu, 19 Sep 2019 at 10:31, Will Deacon wrote: > > On Wed, Sep 11, 2019 at 06:19:40PM +0100, Robin Murphy wrote: > > On 2019-09-11 5:20 pm, Will Deacon wrote: > > > On Wed, Sep 11, 2019 at 06:19:04PM +0200, Neil Armstrong wrote: > > > > On 11/09/2019 16:42, Robin Murphy wrote: > > > > > Here's

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-06-10 Thread Tomeu Vizoso
On Wed, 29 May 2019 at 19:38, Robin Murphy wrote: > > On 29/05/2019 16:09, Tomeu Vizoso wrote: > > On Tue, 21 May 2019 at 18:11, Clément Péron wrote: > >> > > [snip] > >> [ 345.204813] panfrost 180.gpu: mmu irq status=1 > >> [ 345.209617] panf

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-05-31 Thread Tomeu Vizoso
On Wed, 29 May 2019 at 19:38, Robin Murphy wrote: > > On 29/05/2019 16:09, Tomeu Vizoso wrote: > > On Tue, 21 May 2019 at 18:11, Clément Péron wrote: > >> > > [snip] > >> [ 345.204813] panfrost 180.gpu: mmu irq status=1 > >> [ 345.209617] panf

Re: [PATCH v6 0/6] Allwinner H6 Mali GPU support

2019-05-29 Thread Tomeu Vizoso
On Tue, 21 May 2019 at 18:11, Clément Péron wrote: > [snip] > [ 345.204813] panfrost 180.gpu: mmu irq status=1 > [ 345.209617] panfrost 180.gpu: Unhandled Page fault in AS0 at VA > 0x02400400 From what I can see here, 0x02400400 points to the first byte of the first

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-10 Thread Tomeu Vizoso
On Wed, 10 Apr 2019 at 12:20, Steven Price wrote: > > On 08/04/2019 22:04, Rob Herring wrote: > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > >> > >> On 01/04/2019 08:47, Rob Herring wrote: > >>> This adds the initial driver for panfrost which supports Arm Mali > >>> Midgard and Bifrost

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-09 Thread Tomeu Vizoso
On Mon, 8 Apr 2019 at 23:04, Rob Herring wrote: > > On Fri, Apr 5, 2019 at 7:30 AM Steven Price wrote: > > > > On 01/04/2019 08:47, Rob Herring wrote: > > > This adds the initial driver for panfrost which supports Arm Mali > > > Midgard and Bifrost family of GPUs. Currently, only the T860 and >

Re: [PATCH] iommu/rockchip: Fix "is stall active" check

2016-04-06 Thread Tomeu Vizoso
imed out" error when unbinding the >> display-subsystem, but the RK_MMU_STATUS value printed in the error >> message indicated that stall active was set. >> >> [1] http://article.gmane.org/gmane.comp.video.dri.devel/150721 > > So it seems both you and Tomeu wer

[PATCH] iommu/rockchip: Only log stall errors when attaching

2016-03-22 Thread Tomeu Vizoso
Move the logging of timeouts when stalling the MMU to rk_iommu_attach_device, as it's expected that sometimes the MMU won't get stalled when detaching a device, and it's not a real problem that would need to be communicated to the user. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.

[PATCH] iommu/rockchip: Don't feed NULL res pointers to devres

2016-03-21 Thread Tomeu Vizoso
If we do, devres prints a "invalid resource" string in the error loglevel. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/iommu/rockchip-iommu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockch

Re: [PATCH v3 01/12] clk: tegra: Implement memory-controller clock

2014-10-20 Thread Tomeu Vizoso
name and parent_name from the passed args? With that change: Reviewed-By: Tomeu Vizoso tomeu.viz...@collabora.com Cheers, Tomeu + 16, 1, 0, mc_div_table, lock); +} diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c