[PATCH] iommu/mediatek: check return value after calling platform_get_resource()

2022-07-04 Thread Yang Yingliang via iommu
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Fixes: 42d57fc58aeb ("iommu/mediatek: Initialise/Remove for multi bank dev") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/iommu/mtk_iommu.c | 2 ++ 1 file

[PATCH -next] iommu/dma: Fix missing mutex_init() in iommu_get_msi_cookie()

2022-06-27 Thread Yang Yingliang via iommu
omain initialization") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/iommu/dma-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c index 1910f4f1612b..e29157380c48 100644 --- a/drivers/iommu/dma-iom

[PATCH] iommu/arm-smmu-v3: check return value after calling platform_get_resource()

2022-04-25 Thread Yang Yingliang via iommu
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu

[PATCH] iommu/arm-smmu: fix possible null-ptr-deref in arm_smmu_device_probe()

2022-04-25 Thread Yang Yingliang via iommu
;iommu/arm-smmu: Make use of the iommu_register interface") Signed-off-by: Yang Yingliang --- drivers/iommu/arm/arm-smmu/arm-smmu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c index 568

[PATCH] iommu/dart: check return value after calling platform_get_resource()

2022-04-25 Thread Yang Yingliang via iommu
quot;iommu/dart: Add DART iommu driver") Signed-off-by: Yang Yingliang --- drivers/iommu/apple-dart.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c index decafb07ad08..15b77f16cfa3 100644 --- a/drivers/iomm

[PATCH -next] iommu/arm-smmu: Fix missing unlock on error in arm_smmu_device_group()

2021-08-20 Thread Yang Yingliang
Add the missing unlock before return from function arm_smmu_device_group() in the error handling case. Fixes: b1a1347912a7 ("iommu/arm-smmu: Fix race condition during iommu_group creation") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/iommu/arm/arm-smmu/arm-

[PATCH v2] iommu: return error code when it can't get group

2020-11-26 Thread Yang Yingliang
It's better to return error code if it can't get group in iommu_probe_device(). It's no function change. Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/iommu/iommu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/iommu.c

Re: [PATCH] iommu: fix return error code in iommu_probe_device()

2020-11-25 Thread Yang Yingliang
On 2020/11/25 19:35, Will Deacon wrote: On Wed, Nov 25, 2020 at 09:54:34AM +0800, Yang Yingliang wrote: On 2020/11/18 6:41, Will Deacon wrote: On Tue, Nov 17, 2020 at 07:11:28PM +0800, Yang Yingliang wrote: On 2020/11/17 17:40, Lu Baolu wrote: On 2020/11/17 10:52, Yang Yingliang wrote: If

Re: [PATCH] iommu: fix return error code in iommu_probe_device()

2020-11-24 Thread Yang Yingliang
On 2020/11/18 6:41, Will Deacon wrote: On Tue, Nov 17, 2020 at 07:11:28PM +0800, Yang Yingliang wrote: On 2020/11/17 17:40, Lu Baolu wrote: On 2020/11/17 10:52, Yang Yingliang wrote: If iommu_group_get() failed, it need return error code in iommu_probe_device(). Fixes: cf193888bfbd ("

Re: [PATCH] iommu: fix return error code in iommu_probe_device()

2020-11-17 Thread Yang Yingliang
On 2020/11/17 17:40, Lu Baolu wrote: Hi Yingliang, On 2020/11/17 10:52, Yang Yingliang wrote: If iommu_group_get() failed, it need return error code in iommu_probe_device(). Fixes: cf193888bfbd ("iommu: Move new probe_device path...") Reported-by: Hulk Robot Signed-off-by: Yang

[PATCH] iommu: fix return error code in iommu_probe_device()

2020-11-16 Thread Yang Yingliang
If iommu_group_get() failed, it need return error code in iommu_probe_device(). Fixes: cf193888bfbd ("iommu: Move new probe_device path...") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang --- drivers/iommu/iommu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di