Re: [PATCH] vfio: Remove VFIO_TYPE1_NESTING_IOMMU

2022-05-12 Thread zhangfei....@foxmail.com
On 2022/5/12 下午7:59, Jason Gunthorpe wrote: On Thu, May 12, 2022 at 07:57:26PM +0800, zhangfei@foxmail.com wrote: On 2022/5/12 下午7:32, Jason Gunthorpe via iommu wrote: On Thu, May 12, 2022 at 03:07:09PM +0800, Zhangfei Gao wrote: I can't help feeling a little wary about removing

Re: [PATCH] vfio: Remove VFIO_TYPE1_NESTING_IOMMU

2022-05-12 Thread zhangfei....@foxmail.com
On 2022/5/12 下午7:32, Jason Gunthorpe via iommu wrote: On Thu, May 12, 2022 at 03:07:09PM +0800, Zhangfei Gao wrote: I can't help feeling a little wary about removing this until IOMMUFD can actually offer a functional replacement - is it in the way of anything upcoming? From an upstream pers

Re: [PATCH] iommu/arm-smmu-v3-sva: Fix mm use-after-free

2022-04-26 Thread zhangfei....@foxmail.com
Hi, Jean On 2022/4/26 下午6:04, Jean-Philippe Brucker wrote: We currently call arm64_mm_context_put() without holding a reference to the mm, which can result in use-after-free. Call mmgrab()/mmdrop() to ensure the mm only gets freed after we unpinned the ASID. Fixes: 32784a9562fb ("iommu/arm-smmu

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-24 Thread zhangfei....@foxmail.com
Hi, Dave On 2022/4/12 下午11:35, Dave Hansen wrote: On 4/12/22 08:10, Jean-Philippe Brucker wrote: I wonder if the Intel and ARM IOMMU code differ in the way they keep references to the mm, or if this affects Intel as well, but we just haven't tested the code enough. The Arm code was written exp

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-23 Thread zhangfei....@foxmail.com
Hi, Jean On 2022/4/22 下午11:50, Jean-Philippe Brucker wrote: On Fri, Apr 22, 2022 at 09:15:01PM +0800, zhangfei@foxmail.com wrote: I'm trying to piece together what happens from the kernel point of view. * master process with mm A opens a queue fd through uacce, which

Re: Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-22 Thread zhangfei....@foxmail.com
Hi, Jean On 2022/4/22 下午6:11, Jean-Philippe Brucker wrote: On Fri, Apr 22, 2022 at 05:03:10PM +0800, zhangfei@foxmail.com wrote: [...] Have tested, still got some issue with our openssl-engine. 1. If openssl-engine does not register rsa, nginx works well. 2. If openssl-engine register

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-22 Thread zhangfei....@foxmail.com
Hi, Jean On 2022/4/21 下午2:47, zhangfei@foxmail.com wrote: On 2022/4/21 上午12:45, Jean-Philippe Brucker wrote: Hi, On Fri, Apr 15, 2022 at 02:51:08AM -0700, Fenghua Yu wrote:  From a6444e1e5bd8076f5e5c5e950d3192de327f0c9c Mon Sep 17 00:00:00 2001 From: Fenghua Yu Date: Fri, 15 Apr 2022

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-20 Thread zhangfei....@foxmail.com
On 2022/4/21 上午12:45, Jean-Philippe Brucker wrote: Hi, On Fri, Apr 15, 2022 at 02:51:08AM -0700, Fenghua Yu wrote: From a6444e1e5bd8076f5e5c5e950d3192de327f0c9c Mon Sep 17 00:00:00 2001 From: Fenghua Yu Date: Fri, 15 Apr 2022 00:51:33 -0700 Subject: [RFC PATCH] iommu/sva: Fix PASID use-afte

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-18 Thread zhangfei....@foxmail.com
On 2022/4/19 上午2:14, Jacob Pan wrote: Hi zhangfei@foxmail.com, On Sat, 16 Apr 2022 09:43:07 +0800, "zhangfei@foxmail.com" wrote: On 2022/4/16 上午5:00, Jacob Pan wrote: Hi zhangfei@foxmail.com, On Fri, 15 Apr 2022 19:52:03 +0800, "zhangfei....@foxmail.com"

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-15 Thread zhangfei....@foxmail.com
On 2022/4/16 上午5:00, Jacob Pan wrote: Hi zhangfei@foxmail.com, On Fri, 15 Apr 2022 19:52:03 +0800, "zhangfei@foxmail.com" wrote: A PASID might be still used even though it is freed on mm exit. process A: sva_bind(); ioasid_alloc() = N; // Get PASID N

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-15 Thread zhangfei....@foxmail.com
On 2022/4/15 下午8:37, Fenghua Yu wrote: Hi, Zhangfei, On Fri, Apr 15, 2022 at 07:52:03PM +0800, zhangfei@foxmail.com wrote: On 2022/4/15 下午6:50, Fenghua Yu wrote: Hi, Zhangfei, On Fri, Apr 15, 2022 at 06:14:09PM +0800, zhangfei@foxmail.com wrote: I download this patch from: https

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-15 Thread zhangfei....@foxmail.com
On 2022/4/15 下午6:50, Fenghua Yu wrote: Hi, Zhangfei, On Fri, Apr 15, 2022 at 06:14:09PM +0800, zhangfei@foxmail.com wrote: On 2022/4/15 下午5:51, Fenghua Yu wrote: On Thu, Apr 14, 2022 at 06:08:09PM +0800, zhangfei@foxmail.com wrote: On 2022/4/12 下午11:35, zhangfei@foxmail.com

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-15 Thread zhangfei....@foxmail.com
On 2022/4/15 下午5:51, Fenghua Yu wrote: On Thu, Apr 14, 2022 at 06:08:09PM +0800, zhangfei@foxmail.com wrote: On 2022/4/12 下午11:35, zhangfei@foxmail.com wrote: Hi, Fenghua On 2022/4/12 下午9:41, Fenghua Yu wrote: Hi, Zhangfei, On Tue, Apr 12, 2022 at 03:04:09PM +0800, zhangfei

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-14 Thread zhangfei....@foxmail.com
On 2022/4/12 下午11:35, zhangfei@foxmail.com wrote: Hi, Fenghua On 2022/4/12 下午9:41, Fenghua Yu wrote: Hi, Zhangfei, On Tue, Apr 12, 2022 at 03:04:09PM +0800, zhangfei@foxmail.com wrote: On 2022/4/11 下午10:52, Dave Hansen wrote: On 4/11/22 07:44, zhangfei@foxmail.com wrote: On

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-12 Thread zhangfei....@foxmail.com
Hi, Fenghua On 2022/4/12 下午9:41, Fenghua Yu wrote: Hi, Zhangfei, On Tue, Apr 12, 2022 at 03:04:09PM +0800, zhangfei@foxmail.com wrote: On 2022/4/11 下午10:52, Dave Hansen wrote: On 4/11/22 07:44, zhangfei@foxmail.com wrote: On 2022/4/11 下午10:36, Dave Hansen wrote: On 4/11/22 07:20

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-12 Thread zhangfei....@foxmail.com
On 2022/4/11 下午10:52, Dave Hansen wrote: On 4/11/22 07:44, zhangfei@foxmail.com wrote: On 2022/4/11 下午10:36, Dave Hansen wrote: On 4/11/22 07:20, zhangfei@foxmail.com wrote: Is there nothing before this call trace?  Usually there will be at least some warning text. I added

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-11 Thread zhangfei....@foxmail.com
On 2022/4/11 下午10:52, Dave Hansen wrote: On 4/11/22 07:44, zhangfei@foxmail.com wrote: On 2022/4/11 下午10:36, Dave Hansen wrote: On 4/11/22 07:20, zhangfei@foxmail.com wrote: Is there nothing before this call trace?  Usually there will be at least some warning text. I added

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-11 Thread zhangfei....@foxmail.com
On 2022/4/11 下午10:36, Dave Hansen wrote: On 4/11/22 07:20, zhangfei@foxmail.com wrote: Is there nothing before this call trace?  Usually there will be at least some warning text. I added dump_stack() in ioasid_free. Hold on a sec, though... What's the *problem* here? Did some

Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

2022-04-11 Thread zhangfei....@foxmail.com
On 2022/4/11 下午10:10, Dave Hansen wrote: On 4/11/22 07:00, Zhangfei Gao wrote: with this patchset, each time after sbin/nginx, ioasid is freed immediately. lynx test will alloc the same ioasid=1. That doesn't seem right. Isn't 'sbin/nginx' still running when lynx runs? How can they get the

Re: [PATCH RFC 07/12] iommufd: Data structure to provide IOVA to PFN mapping

2022-03-25 Thread zhangfei....@foxmail.com
Hi, Jason On 2022/3/19 上午1:27, Jason Gunthorpe via iommu wrote: This is the remainder of the IOAS data structure. Provide an object called an io_pagetable that is composed of iopt_areas pointing at iopt_pages, along with a list of iommu_domains that mirror the IOVA to PFN map. At the top this i

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2021-01-11 Thread zhangfei....@foxmail.com
Hi, Bjorn On 2020/12/18 上午4:38, Bjorn Helgaas wrote: The principles are: - I don't want to have to update a quirk for every new Device ID that needs this. Hi Bjorn and Zhangfei, We plan to use ATS/PRI to support SVA in future PCI devices. However, for current devices, we need to add

Re: [PATCH v10 2/4] uacce: add uacce driver

2020-01-10 Thread zhangfei....@foxmail.com
On 2020/1/10 下午6:10, Jonathan Cameron wrote: On Fri, 10 Jan 2020 14:55:39 +0800 "zhangfei@foxmail.com" wrote: On 2020/1/10 上午1:38, Jonathan Cameron wrote: On Mon, 16 Dec 2019 11:08:15 +0800 Zhangfei Gao wrote: From: Kenneth Lee Uacce (Unified/User-space-acces

Re: [PATCH v10 0/4] Add uacce module for Accelerator

2020-01-10 Thread zhangfei....@foxmail.com
On 2020/1/10 下午6:08, Jonathan Cameron wrote: On Fri, 10 Jan 2020 15:03:25 +0800 zhangfei wrote: On 2020/1/10 上午1:49, Jonathan Cameron wrote: On Mon, 16 Dec 2019 11:08:13 +0800 Zhangfei Gao wrote: Uacce (Unified/User-space-access-intended Accelerator Framework) targets to provide Shared

Re: [PATCH v10 2/4] uacce: add uacce driver

2020-01-09 Thread zhangfei....@foxmail.com
On 2020/1/10 上午1:38, Jonathan Cameron wrote: On Mon, 16 Dec 2019 11:08:15 +0800 Zhangfei Gao wrote: From: Kenneth Lee Uacce (Unified/User-space-access-intended Accelerator Framework) targets to provide Shared Virtual Addressing (SVA) between accelerators and processes. So accelerator can a

Re: [PATCH v3 00/13] iommu: Add PASID support to Arm SMMUv3

2019-12-09 Thread zhangfei....@foxmail.com
On 2019/12/10 上午2:05, Jean-Philippe Brucker wrote: Add support for Substream ID and PASIDs to the SMMUv3 driver. Changes since v2 [1]: * Split preparatory work into patches 5, 6, 8 and 9. * Added patch 1. Not strictly relevant, but since we're moving the DMA allocations and adding a new on

Re: [PATCH v9 00/11] SMMUv3 Nested Stage Setup (VFIO part)

2019-07-12 Thread zhangfei....@foxmail.com
On 2019/7/11 下午9:56, Eric Auger wrote: This series brings the VFIO part of HW nested paging support in the SMMUv3. The series depends on: [PATCH v9 00/14] SMMUv3 Nested Stage Setup (IOMMU part) (https://www.spinics.net/lists/kernel/msg3187714.html) 3 new IOCTLs are introduced that allow the u