Re: [PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core

2020-12-10 Thread Kalle Valo
Heiner Kallweit  writes:

> Zillions of drivers use the unlikely() hint when checking the result of
> dma_mapping_error(). This is an inline function anyway, so we can move
> the hint into the function and remove it from drivers.
>>From time to time discussions pop up how effective unlikely() is,
> and that it should be used only if something is really very unlikely.
> I think that's the case here.
>
> Patch was created with some help from coccinelle.
>
> @@
> expression dev, dma_addr;
> @@
>
> - unlikely(dma_mapping_error(dev, dma_addr))
> + dma_mapping_error(dev, dma_addr)
>
> Signed-off-by: Heiner Kallweit 
> ---
> If ok, then tbd through which tree this is supposed to go.
> Patch is based on linux-next-20201210.
> ---

[...]

>  drivers/net/wireless/ath/ath10k/htt_rx.c  |  2 +-
>  drivers/net/wireless/ath/ath10k/pci.c |  2 +-
>  drivers/net/wireless/ath/ath10k/snoc.c|  2 +-
>  drivers/net/wireless/ath/ath11k/ce.c  |  2 +-
>  drivers/net/wireless/ath/ath11k/dp_rx.c   |  2 +-
>  drivers/net/wireless/ath/ath5k/base.c |  2 +-
>  drivers/net/wireless/ath/ath9k/beacon.c   |  2 +-
>  drivers/net/wireless/ath/ath9k/recv.c | 21 +++-
>  drivers/net/wireless/ath/ath9k/xmit.c |  2 +-
>  drivers/net/wireless/ath/wil6210/txrx.c   | 10 
>  drivers/net/wireless/ath/wil6210/txrx_edma.c  |  4 +--
>  drivers/net/wireless/broadcom/b43/dma.c   |  2 +-
>  drivers/net/wireless/broadcom/b43legacy/dma.c |  2 +-
>  drivers/net/wireless/intel/iwlwifi/pcie/tx.c  | 10 
>  drivers/net/wireless/intel/iwlwifi/queue/tx.c | 10 
>  drivers/net/wireless/mediatek/mt76/dma.c  |  8 +++---
>  .../net/wireless/ralink/rt2x00/rt2x00queue.c  |  4 +--

For wireless drivers:

Acked-by: Kalle Valo 

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu


Re: [PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core

2020-12-10 Thread Wolfram Sang
On Thu, Dec 10, 2020 at 03:47:50PM +0100, Heiner Kallweit wrote:
> Zillions of drivers use the unlikely() hint when checking the result of
> dma_mapping_error(). This is an inline function anyway, so we can move
> the hint into the function and remove it from drivers.
> From time to time discussions pop up how effective unlikely() is,
> and that it should be used only if something is really very unlikely.
> I think that's the case here.
> 
> Patch was created with some help from coccinelle.
> 
> @@
> expression dev, dma_addr;
> @@
> 
> - unlikely(dma_mapping_error(dev, dma_addr))
> + dma_mapping_error(dev, dma_addr)
> 
> Signed-off-by: Heiner Kallweit 

Acked-by: Wolfram Sang  # for I2C



signature.asc
Description: PGP signature
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core

2020-12-10 Thread Heiner Kallweit
Zillions of drivers use the unlikely() hint when checking the result of
dma_mapping_error(). This is an inline function anyway, so we can move
the hint into the function and remove it from drivers.
>From time to time discussions pop up how effective unlikely() is,
and that it should be used only if something is really very unlikely.
I think that's the case here.

Patch was created with some help from coccinelle.

@@
expression dev, dma_addr;
@@

- unlikely(dma_mapping_error(dev, dma_addr))
+ dma_mapping_error(dev, dma_addr)

Signed-off-by: Heiner Kallweit 
---
If ok, then tbd through which tree this is supposed to go.
Patch is based on linux-next-20201210.
---
 drivers/crypto/cavium/cpt/cptvf_reqmanager.c  |  3 +--
 drivers/crypto/hisilicon/hpre/hpre_crypto.c   |  2 +-
 .../marvell/octeontx/otx_cptvf_reqmgr.c   |  5 ++--
 drivers/crypto/mediatek/mtk-aes.c |  2 +-
 drivers/crypto/mediatek/mtk-sha.c |  6 ++---
 drivers/crypto/qat/qat_common/qat_algs.c  |  8 +++---
 drivers/crypto/qat/qat_common/qat_asym_algs.c | 25 +--
 drivers/i2c/busses/i2c-amd-mp2-plat.c |  2 +-
 drivers/infiniband/hw/hfi1/sdma.c |  2 +-
 drivers/net/ethernet/aeroflex/greth.c |  4 +--
 drivers/net/ethernet/amazon/ena/ena_netdev.c  |  8 +++---
 .../net/ethernet/apm/xgene/xgene_enet_main.c  |  2 +-
 .../net/ethernet/aquantia/atlantic/aq_nic.c   |  5 ++--
 .../net/ethernet/aquantia/atlantic/aq_ring.c  |  2 +-
 drivers/net/ethernet/arc/emac_main.c  |  2 +-
 .../net/ethernet/atheros/atl1c/atl1c_main.c   |  6 ++---
 drivers/net/ethernet/broadcom/bgmac.c |  4 +--
 .../net/ethernet/broadcom/bnx2x/bnx2x_cmn.c   | 10 
 .../ethernet/broadcom/bnx2x/bnx2x_ethtool.c   |  2 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.c |  4 +--
 drivers/net/ethernet/chelsio/cxgb4/sge.c  |  4 +--
 drivers/net/ethernet/chelsio/cxgb4vf/sge.c|  4 +--
 drivers/net/ethernet/faraday/ftgmac100.c  |  2 +-
 drivers/net/ethernet/faraday/ftmac100.c   |  4 +--
 .../net/ethernet/freescale/dpaa/dpaa_eth.c| 13 +-
 .../net/ethernet/freescale/dpaa2/dpaa2-eth.c  | 12 -
 drivers/net/ethernet/freescale/enetc/enetc.c  |  4 +--
 drivers/net/ethernet/freescale/gianfar.c  |  6 ++---
 drivers/net/ethernet/google/gve/gve_tx.c  |  4 +--
 drivers/net/ethernet/hisilicon/hisi_femac.c   |  2 +-
 drivers/net/ethernet/hisilicon/hix5hd2_gmac.c |  4 +--
 .../net/ethernet/hisilicon/hns3/hns3_enet.c   |  4 +--
 drivers/net/ethernet/lantiq_xrx200.c  |  5 ++--
 drivers/net/ethernet/marvell/mv643xx_eth.c|  3 +--
 drivers/net/ethernet/marvell/mvneta.c |  9 +++
 drivers/net/ethernet/marvell/mvneta_bm.c  |  2 +-
 .../net/ethernet/marvell/mvpp2/mvpp2_main.c   |  8 +++---
 .../marvell/octeontx2/nic/otx2_common.c   |  2 +-
 drivers/net/ethernet/mediatek/mtk_eth_soc.c   | 10 
 drivers/net/ethernet/mellanox/mlx4/en_rx.c|  2 +-
 .../mellanox/mlx5/core/diag/rsc_dump.c|  2 +-
 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  2 +-
 .../mellanox/mlx5/core/en_accel/ktls_rx.c |  2 +-
 .../mellanox/mlx5/core/en_accel/ktls_tx.c |  2 +-
 .../net/ethernet/mellanox/mlx5/core/en_rx.c   |  2 +-
 .../net/ethernet/mellanox/mlx5/core/en_tx.c   |  6 ++---
 .../net/ethernet/neterion/vxge/vxge-config.c  |  6 ++---
 .../net/ethernet/neterion/vxge/vxge-main.c|  6 ++---
 drivers/net/ethernet/nvidia/forcedeth.c   | 21 ++--
 .../net/ethernet/pensando/ionic/ionic_txrx.c  |  2 +-
 drivers/net/ethernet/qlogic/qed/qed_ll2.c |  4 +--
 .../net/ethernet/qlogic/qede/qede_ethtool.c   |  2 +-
 drivers/net/ethernet/qlogic/qede/qede_fp.c|  8 +++---
 drivers/net/ethernet/realtek/r8169_main.c |  2 +-
 drivers/net/ethernet/rocker/rocker_main.c |  2 +-
 drivers/net/ethernet/sfc/falcon/rx.c  |  3 +--
 drivers/net/ethernet/sfc/falcon/tx.c  |  4 +--
 drivers/net/ethernet/sfc/rx_common.c  |  3 +--
 drivers/net/ethernet/sfc/tx_common.c  |  4 +--
 drivers/net/ethernet/sfc/tx_tso.c |  2 +-
 drivers/net/ethernet/sis/sis900.c | 24 --
 drivers/net/ethernet/socionext/sni_ave.c  |  2 +-
 drivers/net/ethernet/sun/sunhme.c |  8 +++---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c  |  6 ++---
 drivers/net/ethernet/ti/netcp_core.c  |  4 +--
 drivers/net/ethernet/via/via-rhine.c  |  2 +-
 .../net/ethernet/xilinx/xilinx_axienet_main.c |  6 ++---
 drivers/net/wireless/ath/ath10k/htt_rx.c  |  2 +-
 drivers/net/wireless/ath/ath10k/pci.c |  2 +-
 drivers/net/wireless/ath/ath10k/snoc.c|  2 +-
 drivers/net/wireless/ath/ath11k/ce.c  |  2 +-
 drivers/net/wireless/ath/ath11k/dp_rx.c   |  2 +-
 drivers/net/wireless/ath/ath5k/base.c |  2 +-
 drivers/net/wireless/ath/ath9k/beacon.c   |  2 +-
 drivers/net/wireless/ath/ath9k/recv.c | 21 +++-
 drivers/net/wireless/ath/ath9k/xmit.c