Re: [PATCH] iommu: Use dev_iommu_ops() for probe_finalize

[Lu Baolu]

On 2022/4/22 20:33, Robin Murphy wrote:

The ->probe_finalize hook only runs after ->probe_device succeeds,
so we can move that over to the new dev_iommu_ops() as well.

Signed-off-by: Robin Murphy 


Reviewed-by: Lu Baolu 

Best regards,
baolu


---

Another cheeky little one which doesn't need to wait...

  drivers/iommu/iommu.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 1b8dcda5fbe4..8825a4628e46 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -315,7 +315,7 @@ static int __iommu_probe_device(struct device *dev, struct 
list_head *group_list
  
  int iommu_probe_device(struct device *dev)

  {
-   const struct iommu_ops *ops = dev->bus->iommu_ops;
+   const struct iommu_ops *ops;
struct iommu_group *group;
int ret;
  
@@ -352,6 +352,7 @@ int iommu_probe_device(struct device *dev)

mutex_unlock(>mutex);
iommu_group_put(group);
  
+	ops = dev_iommu_ops(dev);

if (ops->probe_finalize)
ops->probe_finalize(dev);
  

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH] iommu: Use dev_iommu_ops() for probe_finalize

[Robin Murphy]

The ->probe_finalize hook only runs after ->probe_device succeeds,
so we can move that over to the new dev_iommu_ops() as well.

Signed-off-by: Robin Murphy 
---

Another cheeky little one which doesn't need to wait...

 drivers/iommu/iommu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 1b8dcda5fbe4..8825a4628e46 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -315,7 +315,7 @@ static int __iommu_probe_device(struct device *dev, struct 
list_head *group_list
 
 int iommu_probe_device(struct device *dev)
 {
-   const struct iommu_ops *ops = dev->bus->iommu_ops;
+   const struct iommu_ops *ops;
struct iommu_group *group;
int ret;
 
@@ -352,6 +352,7 @@ int iommu_probe_device(struct device *dev)
mutex_unlock(>mutex);
iommu_group_put(group);
 
+   ops = dev_iommu_ops(dev);
if (ops->probe_finalize)
ops->probe_finalize(dev);
 
-- 
2.35.3.dirty

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu