Re: [PATCH 1/9] iommu/arm-smmu: Switch to arch_initcall for driver registration

[Will Deacon]

On Thu, Sep 26, 2013 at 11:36:13PM +0100, Andreas Herrmann wrote:
 This should ensure that arm-smmu is initialized before other drivers
 start handling devices that propably need smmu support.
 
 Also remove module_exit function as we most likely never want to
 unload this driver.

Doesn't hurt to leave the exit function there though, right?

 Signed-off-by: Andreas Herrmann andreas.herrm...@calxeda.com
 ---
  drivers/iommu/arm-smmu.c |8 +---
  1 file changed, 1 insertion(+), 7 deletions(-)
 
 diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
 index 181c9ba..6808577 100644
 --- a/drivers/iommu/arm-smmu.c
 +++ b/drivers/iommu/arm-smmu.c
 @@ -1976,13 +1976,7 @@ static int __init arm_smmu_init(void)
   return 0;
  }
  
 -static void __exit arm_smmu_exit(void)
 -{
 - return platform_driver_unregister(arm_smmu_driver);
 -}
 -
 -module_init(arm_smmu_init);
 -module_exit(arm_smmu_exit);
 +arch_initcall(arm_smmu_init);

Why not subsys_initcall, like the other ARM IOMMUs?

Will
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH 1/9] iommu/arm-smmu: Switch to arch_initcall for driver registration

[Andreas Herrmann]

This should ensure that arm-smmu is initialized before other drivers
start handling devices that propably need smmu support.

Also remove module_exit function as we most likely never want to
unload this driver.

Signed-off-by: Andreas Herrmann andreas.herrm...@calxeda.com
---
 drivers/iommu/arm-smmu.c |8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 181c9ba..6808577 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1976,13 +1976,7 @@ static int __init arm_smmu_init(void)
return 0;
 }
 
-static void __exit arm_smmu_exit(void)
-{
-   return platform_driver_unregister(arm_smmu_driver);
-}
-
-module_init(arm_smmu_init);
-module_exit(arm_smmu_exit);
+arch_initcall(arm_smmu_init);
 
 MODULE_DESCRIPTION(IOMMU API for ARM architected SMMU implementations);
 MODULE_AUTHOR(Will Deacon will.dea...@arm.com);
-- 
1.7.9.5

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu