Re: [PATCH 12/12] dma-mapping: move the dma_declare_coherent_memory documentation

2020-09-11 Thread Christoph Hellwig
On Thu, Sep 10, 2020 at 02:51:47PM +0100, Robin Murphy wrote: > On 2020-09-08 17:47, Christoph Hellwig wrote: >> dma_declare_coherent_memory should not be in a DMA API guide aimed >> at driver writers (that is consumers of the API). Move it to a comment >> near the function instead. > > I still

Re: [PATCH 12/12] dma-mapping: move the dma_declare_coherent_memory documentation

2020-09-10 Thread Robin Murphy
On 2020-09-08 17:47, Christoph Hellwig wrote: dma_declare_coherent_memory should not be in a DMA API guide aimed at driver writers (that is consumers of the API). Move it to a comment near the function instead. I still think there might be an occasional valid use for device-local memory

[PATCH 12/12] dma-mapping: move the dma_declare_coherent_memory documentation

2020-09-08 Thread Christoph Hellwig
dma_declare_coherent_memory should not be in a DMA API guide aimed at driver writers (that is consumers of the API). Move it to a comment near the function instead. Signed-off-by: Christoph Hellwig --- Documentation/core-api/dma-api.rst | 24 kernel/dma/coherent.c