Re: [PATCH v3 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1

[Niklas Söderlund]

Hi Simon,

* Simon Horman  [2016-02-10 18:55:59 +0100]:

> Hi Niklas,
>
> I am deferring accepting this and the similar patch for the r8a7791 pending
> acceptance of the driver changes earlier in this series. Please let me know
> if you prefer a different course of action.

That sounds good, thanks.

>
> I notice that the devel branch of there renesas tree there are
> dmac nodes for the r8a7793, r8a7794 and r8a7795. Is this change,
> also suitable for those SoCs? If so, do you plan to update them?
> If not I'll add it to my todo list.

I planed to update all effected SoCs once the dependencies for this
series where accepted. But if you want to keep track of this I'm happy.
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v3 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1

[Laurent Pinchart]

Hi Niklas,

Thank you for the patch.

On Wednesday 10 February 2016 01:57:57 Niklas Söderlund wrote:

No commit message ? I'd at least mention that as a side effect of this patch 
channel 0 and 15 are disabled, reducing the effective number of channels to 14 
per DMAC.

> Signed-off-by: Niklas Söderlund 

Acked-by: Laurent Pinchart 

Same comment and ack for patch 8/8.

Note that we should still try to find a way to selectively enable the IOMMU in 
a per-device fashion, as system integrators might want it to be disabled for 
some devices. There's no urgency though.

> ---
>  arch/arm/boot/dts/r8a7790.dtsi | 30 ++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 7dfd393..048bbf8 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -294,6 +294,21 @@
>   power-domains = <_clocks>;
>   #dma-cells = <1>;
>   dma-channels = <15>;
> + iommus = <_ds 0>,
> +  <_ds 1>,
> +  <_ds 2>,
> +  <_ds 3>,
> +  <_ds 4>,
> +  <_ds 5>,
> +  <_ds 6>,
> +  <_ds 7>,
> +  <_ds 8>,
> +  <_ds 9>,
> +  <_ds 10>,
> +  <_ds 11>,
> +  <_ds 12>,
> +  <_ds 13>,
> +  <_ds 14>;
>   };
> 
>   dmac1: dma-controller@e672 {
> @@ -325,6 +340,21 @@
>   power-domains = <_clocks>;
>   #dma-cells = <1>;
>   dma-channels = <15>;
> + iommus = <_ds 15>,
> +  <_ds 16>,
> +  <_ds 17>,
> +  <_ds 18>,
> +  <_ds 19>,
> +  <_ds 20>,
> +  <_ds 21>,
> +  <_ds 22>,
> +  <_ds 23>,
> +  <_ds 24>,
> +  <_ds 25>,
> +  <_ds 26>,
> +  <_ds 27>,
> +  <_ds 28>,
> +  <_ds 29>;
>   };
> 
>   audma0: dma-controller@ec70 {

-- 
Regards,

Laurent Pinchart

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH v3 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1

[Niklas Söderlund]

Signed-off-by: Niklas Söderlund 
---
 arch/arm/boot/dts/r8a7790.dtsi | 30 ++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 7dfd393..048bbf8 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -294,6 +294,21 @@
power-domains = <_clocks>;
#dma-cells = <1>;
dma-channels = <15>;
+   iommus = <_ds 0>,
+<_ds 1>,
+<_ds 2>,
+<_ds 3>,
+<_ds 4>,
+<_ds 5>,
+<_ds 6>,
+<_ds 7>,
+<_ds 8>,
+<_ds 9>,
+<_ds 10>,
+<_ds 11>,
+<_ds 12>,
+<_ds 13>,
+<_ds 14>;
};
 
dmac1: dma-controller@e672 {
@@ -325,6 +340,21 @@
power-domains = <_clocks>;
#dma-cells = <1>;
dma-channels = <15>;
+   iommus = <_ds 15>,
+<_ds 16>,
+<_ds 17>,
+<_ds 18>,
+<_ds 19>,
+<_ds 20>,
+<_ds 21>,
+<_ds 22>,
+<_ds 23>,
+<_ds 24>,
+<_ds 25>,
+<_ds 26>,
+<_ds 27>,
+<_ds 28>,
+<_ds 29>;
};
 
audma0: dma-controller@ec70 {
-- 
2.7.1

___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu