Re: the XSK buffer pool needs be to reverted

2020-07-07 Thread Robin Murphy
On 2020-07-06 20:59, Jonathan Lemon wrote: On Wed, Jul 01, 2020 at 10:46:40AM +0100, Robin Murphy wrote: On 2020-06-30 20:08, Jonathan Lemon wrote: On Mon, Jun 29, 2020 at 02:15:16PM +0100, Robin Murphy wrote: On 2020-06-27 08:02, Christoph Hellwig wrote: On Fri, Jun 26, 2020 at 01:54:12PM

Re: the XSK buffer pool needs be to reverted

2020-07-06 Thread Jonathan Lemon
On Wed, Jul 01, 2020 at 10:46:40AM +0100, Robin Murphy wrote: > On 2020-06-30 20:08, Jonathan Lemon wrote: > > On Mon, Jun 29, 2020 at 02:15:16PM +0100, Robin Murphy wrote: > > > On 2020-06-27 08:02, Christoph Hellwig wrote: > > > > On Fri, Jun 26, 2020 at 01:54:12PM -0700, Jonathan Lemon wrote: >

Re: the XSK buffer pool needs be to reverted

2020-07-01 Thread Robin Murphy
On 2020-06-30 20:08, Jonathan Lemon wrote: On Mon, Jun 29, 2020 at 02:15:16PM +0100, Robin Murphy wrote: On 2020-06-27 08:02, Christoph Hellwig wrote: On Fri, Jun 26, 2020 at 01:54:12PM -0700, Jonathan Lemon wrote: On Fri, Jun 26, 2020 at 09:47:25AM +0200, Christoph Hellwig wrote: Note that

Re: the XSK buffer pool needs be to reverted

2020-06-30 Thread Jonathan Lemon
On Mon, Jun 29, 2020 at 02:15:16PM +0100, Robin Murphy wrote: > On 2020-06-27 08:02, Christoph Hellwig wrote: > > On Fri, Jun 26, 2020 at 01:54:12PM -0700, Jonathan Lemon wrote: > > > On Fri, Jun 26, 2020 at 09:47:25AM +0200, Christoph Hellwig wrote: > > > > > > > > Note that this is somewhat

Re: the XSK buffer pool needs be to reverted

2020-06-29 Thread Robin Murphy
On 2020-06-27 08:02, Christoph Hellwig wrote: On Fri, Jun 26, 2020 at 01:54:12PM -0700, Jonathan Lemon wrote: On Fri, Jun 26, 2020 at 09:47:25AM +0200, Christoph Hellwig wrote: Note that this is somewhat urgent, as various of the APIs that the code is abusing are slated to go away for Linux

Re: the XSK buffer pool needs be to reverted

2020-06-27 Thread Christoph Hellwig
On Fri, Jun 26, 2020 at 01:54:12PM -0700, Jonathan Lemon wrote: > On Fri, Jun 26, 2020 at 09:47:25AM +0200, Christoph Hellwig wrote: > > > > Note that this is somewhat urgent, as various of the APIs that the code > > is abusing are slated to go away for Linux 5.9, so this addition comes > > at a

Re: the XSK buffer pool needs be to reverted

2020-06-26 Thread Jonathan Lemon
On Fri, Jun 26, 2020 at 09:47:25AM +0200, Christoph Hellwig wrote: > > Note that this is somewhat urgent, as various of the APIs that the code > is abusing are slated to go away for Linux 5.9, so this addition comes > at a really bad time. Could you elaborate on what is upcoming here? Also, on

Re: the XSK buffer pool needs be to reverted

2020-06-26 Thread Björn Töpel
On 2020-06-26 14:41, Christoph Hellwig wrote: On Fri, Jun 26, 2020 at 02:22:41PM +0200, Björn Töpel wrote: [...] Understood. Wdyt about something in the lines of the diff below? It's build tested only, but removes all non-dma API usage ("poking internals"). Would that be a way forward, and

Re: the XSK buffer pool needs be to reverted

2020-06-26 Thread Christoph Hellwig
On Fri, Jun 26, 2020 at 02:22:41PM +0200, Björn Töpel wrote: > Thanks for clarifying that. Let's work on a solution that can reside in > the dma mapping core. > >> The commit seems to have a long dove tail of commits depending on it >> despite only being a month old, so maybe you can do the revert

Re: the XSK buffer pool needs be to reverted

2020-06-26 Thread Björn Töpel
On 2020-06-26 09:47, Christoph Hellwig wrote: Hi Björn, you addition of the xsk_buff_pool.c APIs in commit 2b43470add8c ("xsk: Introduce AF_XDP buffer allocation API") is unfortunately rather broken by making lots of assumptions and poking into dma-direct and swiotlb internals that are of no