Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
On Thu, Apr 30, 2020 at 02:01:20PM +0200, Greg Kroah-Hartman wrote: > In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to > permit modular drivers") a bunch of iommu symbols were exported, all > with _GPL markings except iommu_group_get_for_dev(). That export should > also be _GPL like the others. > > Cc: Will Deacon > Cc: Joerg Roedel > Cc: John Garry > Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit > modular drivers") > Signed-off-by: Greg Kroah-Hartman > --- > drivers/iommu/iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for v5.7, thanks. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
On Thu, Apr 30, 2020 at 02:23:32PM +0200, Joerg Roedel wrote: > On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote: > > Thanks, not sure how I managed to screw this up in the original patch! > > > > Acked-by: Will Deacon > > > > Joerg -- can you pick this one up please? > > Yes, will send it as a fix for 5.7, but note that this function will be > unexported in 5.8. Thanks, Joerg. Will ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
On Thu, Apr 30, 2020 at 01:17:53PM +0100, Will Deacon wrote: > Thanks, not sure how I managed to screw this up in the original patch! > > Acked-by: Will Deacon > > Joerg -- can you pick this one up please? Yes, will send it as a fix for 5.7, but note that this function will be unexported in 5.8. Regards, Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] drivers/iommu: properly export iommu_group_get_for_dev
On Thu, Apr 30, 2020 at 02:01:20PM +0200, Greg Kroah-Hartman wrote: > In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to > permit modular drivers") a bunch of iommu symbols were exported, all > with _GPL markings except iommu_group_get_for_dev(). That export should > also be _GPL like the others. > > Cc: Will Deacon > Cc: Joerg Roedel > Cc: John Garry > Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit > modular drivers") > Signed-off-by: Greg Kroah-Hartman > --- > drivers/iommu/iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 2b471419e26c..1ecbc8788fe7 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct > device *dev) > > return group; > } > -EXPORT_SYMBOL(iommu_group_get_for_dev); > +EXPORT_SYMBOL_GPL(iommu_group_get_for_dev); > > struct iommu_domain *iommu_group_default_domain(struct iommu_group *group) > { Thanks, not sure how I managed to screw this up in the original patch! Acked-by: Will Deacon Joerg -- can you pick this one up please? Cheers, Will ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH] drivers/iommu: properly export iommu_group_get_for_dev
In commit a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers") a bunch of iommu symbols were exported, all with _GPL markings except iommu_group_get_for_dev(). That export should also be _GPL like the others. Cc: Will Deacon Cc: Joerg Roedel Cc: John Garry Fixes: a7ba5c3d008d ("drivers/iommu: Export core IOMMU API symbols to permit modular drivers") Signed-off-by: Greg Kroah-Hartman --- drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 2b471419e26c..1ecbc8788fe7 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1428,7 +1428,7 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev) return group; } -EXPORT_SYMBOL(iommu_group_get_for_dev); +EXPORT_SYMBOL_GPL(iommu_group_get_for_dev); struct iommu_domain *iommu_group_default_domain(struct iommu_group *group) { -- 2.26.2 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu