From: Minghao Chi (CGEL ZTE) <chi.ming...@zte.com.cn>

Replace zero-length array with flexible-array member and make use
of the struct_size() helper in kzalloc(). For example:

struct viommu_request {
        ...
        unsigned int                    len;
        char                            buf[];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

Reported-by: Zeal Robot <zea...@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.ming...@zte.com.cn>
---
 drivers/iommu/virtio-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
index f2aa34f57454..0996d9c7c358 100644
--- a/drivers/iommu/virtio-iommu.c
+++ b/drivers/iommu/virtio-iommu.c
@@ -231,7 +231,7 @@ static int __viommu_add_req(struct viommu_dev *viommu, void 
*buf, size_t len,
        if (write_offset <= 0)
                return -EINVAL;
 
-       req = kzalloc(sizeof(*req) + len, GFP_ATOMIC);
+       req = kzalloc(struct_size(req, buf, len), GFP_ATOMIC);
        if (!req)
                return -ENOMEM;
 
-- 
2.25.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to