Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, Jun 22, 2021 at 2:17 AM Geert Uytterhoeven wrote:
>
> Hi Rob,
>
> On Tue, Jun 15, 2021 at 9:16 PM Rob Herring wrote:
> > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the
> > same size as the list is redundant and can be dropped. Note that is DT
> > schema specific behavior and not standard json-schema behavior. The tooling
> > will fixup the final schema adding any unspecified minItems/maxItems.
> >
> > This condition is partially checked with the meta-schema already, but
> > only if both 'minItems' and 'maxItems' are equal to the 'items' length.
> > An improved meta-schema is pending.
>
> > Signed-off-by: Rob Herring
>
> > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> > @@ -46,7 +46,6 @@ properties:
> >
> >clocks:
> > minItems: 3
> > -maxItems: 5
> > items:
> >- description: GMAC main clock
> >- description: MAC TX clock
>
> While resolving the conflict with commit fea99822914039c6
> ("dt-bindings: net: document ptp_ref clk in dwmac") in soc/for-next,
> I noticed the following construct for clock-names:
>
> clock-names:
> minItems: 3
> maxItems: 6
> contains:
> enum:
> - stmmaceth
> - mac-clk-tx
> - mac-clk-rx
> - ethstp
> - eth-ck
> - ptp_ref
>
> Should this use items instead of enum, and drop maxItems, or is this
> a valid construct to support specifying the clocks in random order?
> If the latter, it does mean that the order of clock-names may not
> match the order of the clock descriptions.
'contains' is true if one or more entries match the strings. So it is
really saying one of these is required. That's not really much of a
constraint. There's 'minContains' and 'maxContains' in newer
json-schema versions (not yet supported) that could add some
constraints if there has to be at least N entries from contains. An
'items' schema (as opposed to a list) would say all items have to
match one of the strings. I'm sure that's too strict.
TLDR: clocks for this binding are a mess and the above is probably all
we can do here.
Rob
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
Hi Rob,
On Tue, Jun 15, 2021 at 9:16 PM Rob Herring wrote:
> If a property has an 'items' list, then a 'minItems' or 'maxItems' with the
> same size as the list is redundant and can be dropped. Note that is DT
> schema specific behavior and not standard json-schema behavior. The tooling
> will fixup the final schema adding any unspecified minItems/maxItems.
>
> This condition is partially checked with the meta-schema already, but
> only if both 'minItems' and 'maxItems' are equal to the 'items' length.
> An improved meta-schema is pending.
> Signed-off-by: Rob Herring
> --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml
> @@ -46,7 +46,6 @@ properties:
>
>clocks:
> minItems: 3
> -maxItems: 5
> items:
>- description: GMAC main clock
>- description: MAC TX clock
While resolving the conflict with commit fea99822914039c6
("dt-bindings: net: document ptp_ref clk in dwmac") in soc/for-next,
I noticed the following construct for clock-names:
clock-names:
minItems: 3
maxItems: 6
contains:
enum:
- stmmaceth
- mac-clk-tx
- mac-clk-rx
- ethstp
- eth-ck
- ptp_ref
Should this use items instead of enum, and drop maxItems, or is this
a valid construct to support specifying the clocks in random order?
If the latter, it does mean that the order of clock-names may not
match the order of the clock descriptions.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
Hi Rob, On 6/15/21 2:15 PM, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Vinod Koul > Cc: Bartosz Golaszewski > Cc: Kamal Dasu > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Jassi Brar > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Ulf Hansson > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Vladimir Oltean > Cc: Bjorn Helgaas > Cc: Kishon Vijay Abraham I > Cc: Linus Walleij > Cc: "Uwe Kleine-König" > Cc: Lee Jones > Cc: Ohad Ben-Cohen > Cc: Mathieu Poirier > Cc: Philipp Zabel > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Mark Brown > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 1 - > .../devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml | 2 -- > .../devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 1 - > Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml | 2 -- > .../devicetree/bindings/clock/qcom,gcc-sm8350.yaml | 2 -- > .../devicetree/bindings/clock/sprd,sc9863a-clk.yaml | 1 - > .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 2 -- > Documentation/devicetree/bindings/crypto/fsl-dcp.yaml | 1 - > .../display/allwinner,sun4i-a10-display-backend.yaml| 6 -- > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 1 - > .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 > .../bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml | 2 -- > .../bindings/display/allwinner,sun8i-r40-tcon-top.yaml | 2 -- > .../devicetree/bindings/display/bridge/cdns,mhdp8546.yaml | 2 -- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 2 -- > Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- > .../devicetree/bindings/display/st,stm32-ltdc.yaml | 1 - > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 > .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > .../devicetree/bindings/edac/amazon,al-mc-edac.yaml | 2 -- > Documentation/devicetree/bindings/eeprom/at24.yaml | 1 - > Documentation/devicetree/bindings/example-schema.yaml | 2 -- > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 - > Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 1 - > Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml | 1 - > .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml| 2 -- > .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml | 1 - > .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- > .../bindings/interrupt-controller/fsl,irqsteer.yaml | 1 - > .../bindings/interrupt-controller/loongson,liointc.yaml | 1 - > Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml| 1 - > .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 - > .../devicetree/bindings/mailbox/st,stm32-ipcc.yaml | 2 -- > .../devicetree/bindings/media/amlogic,gx-vdec.yaml | 1 - > Documentation/devicetree/bindings/media/i2c/adv7604.yaml| 1 - > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml| 1 - > .../devicetree/bindings/media/qcom,sc7180-venus.yaml| 1 - > .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 1 - > .../devicetree/bindings/media/qcom,sm8250-venus.yaml| 1 - > Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 - > .../bindings/memory-controllers/mediatek,smi-common.yaml| 6 ++ > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 1 - > .../devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml| 2 -- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml| 1 - > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 -- > Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 -- > Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 1 - > Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml| 1 - > .../devicetree/bindings/net/amlogic,meson-dwmac.yaml
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
Hello ROb, On 6/15/21 9:15 PM, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > [...] > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- [...] > .../devicetree/bindings/mailbox/st,stm32-ipcc.yaml | 2 -- [...] > .../devicetree/bindings/remoteproc/st,stm32-rproc.yaml | 2 -- [...] > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 3 --- Reviewed-by: Arnaud Pouliquen Thanks, Arnaud ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Thu, Jun 17, 2021 at 10:06 AM Suman Anna wrote: > > Hi Rob, > > On 6/15/21 2:15 PM, Rob Herring wrote: > > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > > same size as the list is redundant and can be dropped. Note that is DT > > schema specific behavior and not standard json-schema behavior. The tooling > > will fixup the final schema adding any unspecified minItems/maxItems. > > > > This condition is partially checked with the meta-schema already, but > > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > > An improved meta-schema is pending. > > > > Cc: Jens Axboe > > Cc: Stephen Boyd > > Cc: Herbert Xu > > Cc: "David S. Miller" > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Vinod Koul > > Cc: Bartosz Golaszewski > > Cc: Kamal Dasu > > Cc: Jonathan Cameron > > Cc: Lars-Peter Clausen > > Cc: Thomas Gleixner > > Cc: Marc Zyngier > > Cc: Joerg Roedel > > Cc: Jassi Brar > > Cc: Mauro Carvalho Chehab > > Cc: Krzysztof Kozlowski > > Cc: Ulf Hansson > > Cc: Jakub Kicinski > > Cc: Wolfgang Grandegger > > Cc: Marc Kleine-Budde > > Cc: Andrew Lunn > > Cc: Vivien Didelot > > Cc: Vladimir Oltean > > Cc: Bjorn Helgaas > > Cc: Kishon Vijay Abraham I > > Cc: Linus Walleij > > Cc: "Uwe Kleine-König" > > Cc: Lee Jones > > Cc: Ohad Ben-Cohen > > Cc: Mathieu Poirier > > Cc: Philipp Zabel > > Cc: Paul Walmsley > > Cc: Palmer Dabbelt > > Cc: Albert Ou > > Cc: Alessandro Zummo > > Cc: Alexandre Belloni > > Cc: Greg Kroah-Hartman > > Cc: Mark Brown > > Cc: Zhang Rui > > Cc: Daniel Lezcano > > Cc: Wim Van Sebroeck > > Cc: Guenter Roeck > > Signed-off-by: Rob Herring > > --- > > .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 1 - > > .../devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml | 2 -- > > .../devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 1 - > > Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml | 2 -- > > .../devicetree/bindings/clock/qcom,gcc-sm8350.yaml | 2 -- > > .../devicetree/bindings/clock/sprd,sc9863a-clk.yaml | 1 - > > .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 2 -- > > Documentation/devicetree/bindings/crypto/fsl-dcp.yaml | 1 - > > .../display/allwinner,sun4i-a10-display-backend.yaml| 6 -- > > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 1 - > > .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 > > .../bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml | 2 -- > > .../bindings/display/allwinner,sun8i-r40-tcon-top.yaml | 2 -- > > .../devicetree/bindings/display/bridge/cdns,mhdp8546.yaml | 2 -- > > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 2 -- > > Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- > > .../devicetree/bindings/display/st,stm32-ltdc.yaml | 1 - > > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 > > .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > > .../devicetree/bindings/edac/amazon,al-mc-edac.yaml | 2 -- > > Documentation/devicetree/bindings/eeprom/at24.yaml | 1 - > > Documentation/devicetree/bindings/example-schema.yaml | 2 -- > > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 - > > Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 1 - > > Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml | 1 - > > .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml| 2 -- > > .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml | 1 - > > .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - > > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- > > .../bindings/interrupt-controller/fsl,irqsteer.yaml | 1 - > > .../bindings/interrupt-controller/loongson,liointc.yaml | 1 - > > Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml| 1 - > > .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 - > > .../devicetree/bindings/mailbox/st,stm32-ipcc.yaml | 2 -- > > .../devicetree/bindings/media/amlogic,gx-vdec.yaml | 1 - > > Documentation/devicetree/bindings/media/i2c/adv7604.yaml| 1 - > > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml| 1 - > > .../devicetree/bindings/media/qcom,sc7180-venus.yaml| 1 - > > .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 1 - > > .../devicetree/bindings/media/qcom,sm8250-venus.yaml| 1 - > > Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 - > > .../bindings/memory-controllers/mediatek,smi-common.yaml| 6 ++ > > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 1 - > > .../devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml| 2 -- > > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml| 1 - > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 -- > >
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, Jun 15, 2021 at 2:15 PM Rob Herring wrote: > > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Vinod Koul > Cc: Bartosz Golaszewski > Cc: Kamal Dasu > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Jassi Brar > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Ulf Hansson > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Vladimir Oltean > Cc: Bjorn Helgaas > Cc: Kishon Vijay Abraham I > Cc: Linus Walleij > Cc: "Uwe Kleine-König" > Cc: Lee Jones > Cc: Ohad Ben-Cohen > Cc: Mathieu Poirier > Cc: Philipp Zabel > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Mark Brown > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Signed-off-by: Rob Herring > --- > .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 1 - > .../devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml | 2 -- > .../devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 1 - > Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml | 2 -- > .../devicetree/bindings/clock/qcom,gcc-sm8350.yaml | 2 -- > .../devicetree/bindings/clock/sprd,sc9863a-clk.yaml | 1 - > .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 2 -- > Documentation/devicetree/bindings/crypto/fsl-dcp.yaml | 1 - > .../display/allwinner,sun4i-a10-display-backend.yaml| 6 -- > .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 1 - > .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 > .../bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml | 2 -- > .../bindings/display/allwinner,sun8i-r40-tcon-top.yaml | 2 -- > .../devicetree/bindings/display/bridge/cdns,mhdp8546.yaml | 2 -- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 2 -- > Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- > .../devicetree/bindings/display/st,stm32-ltdc.yaml | 1 - > .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 > .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > .../devicetree/bindings/edac/amazon,al-mc-edac.yaml | 2 -- > Documentation/devicetree/bindings/eeprom/at24.yaml | 1 - > Documentation/devicetree/bindings/example-schema.yaml | 2 -- > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 - > Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 1 - > Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml | 1 - > .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml| 2 -- > .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml | 1 - > .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- > .../bindings/interrupt-controller/fsl,irqsteer.yaml | 1 - > .../bindings/interrupt-controller/loongson,liointc.yaml | 1 - > Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml| 1 - > .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 - > .../devicetree/bindings/mailbox/st,stm32-ipcc.yaml | 2 -- > .../devicetree/bindings/media/amlogic,gx-vdec.yaml | 1 - > Documentation/devicetree/bindings/media/i2c/adv7604.yaml| 1 - > .../devicetree/bindings/media/marvell,mmp2-ccic.yaml| 1 - > .../devicetree/bindings/media/qcom,sc7180-venus.yaml| 1 - > .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 1 - > .../devicetree/bindings/media/qcom,sm8250-venus.yaml| 1 - > Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 - > .../bindings/memory-controllers/mediatek,smi-common.yaml| 6 ++ > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 1 - > .../devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml| 2 -- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml| 1 - > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 -- > Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 -- > Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 1 - > Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml| 1 - > .../devicetree/bindings/net/amlogic,meson-dwmac.yaml
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, 15 Jun 2021 at 21:15, Rob Herring wrote: > > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Vinod Koul > Cc: Bartosz Golaszewski > Cc: Kamal Dasu > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Jassi Brar > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Ulf Hansson > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Vladimir Oltean > Cc: Bjorn Helgaas > Cc: Kishon Vijay Abraham I > Cc: Linus Walleij > Cc: "Uwe Kleine-König" > Cc: Lee Jones > Cc: Ohad Ben-Cohen > Cc: Mathieu Poirier > Cc: Philipp Zabel > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Mark Brown > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Signed-off-by: Rob Herring Acked-by: Ulf Hansson # for MMC [...] Kind regards Uffe ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, Jun 15, 2021 at 01:15:43PM -0600, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Vinod Koul > Cc: Bartosz Golaszewski > Cc: Kamal Dasu > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Jassi Brar > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Ulf Hansson > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Vladimir Oltean > Cc: Bjorn Helgaas > Cc: Kishon Vijay Abraham I > Cc: Linus Walleij > Cc: "Uwe Kleine-König" > Cc: Lee Jones > Cc: Ohad Ben-Cohen > Cc: Mathieu Poirier > Cc: Philipp Zabel > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Mark Brown > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Signed-off-by: Rob Herring Acked-by: Wolfram Sang # for I2C signature.asc Description: PGP signature ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On 15.06.2021 13:15:43, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. [...] > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 2 -- Acked-by: Marc Kleine-Budde regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | signature.asc Description: PGP signature ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, 15 Jun 2021 13:15:43 -0600 Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > ... > .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - For this one, the fact it overrides maxItems elsewhere makes this a little bit odd. I guess we can get used to it being implicit. > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- Acked-by: Jonathan Cameron ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, Jun 15, 2021 at 01:15:43PM -0600, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. Acked-by: Mark Brown signature.asc Description: PGP signature ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, 2021-06-15 at 13:15 -0600, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. [...] > Documentation/devicetree/bindings/reset/fsl,imx-src.yaml| 1 - [...] > diff --git a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > index 27c5e34a3ac6..b11ac533f914 100644 > --- a/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > +++ b/Documentation/devicetree/bindings/reset/fsl,imx-src.yaml > @@ -59,7 +59,6 @@ properties: >- description: SRC interrupt >- description: CPU WDOG interrupts out of SRC > minItems: 1 > -maxItems: 2 > >'#reset-cells': > const: 1 Acked-by: Philipp Zabel regards Philipp ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On 15-06-21, 13:15, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - > Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml| 1 - > Documentation/devicetree/bindings/phy/mediatek,tphy.yaml| 2 -- > .../devicetree/bindings/phy/phy-cadence-sierra.yaml | 2 -- > .../devicetree/bindings/phy/phy-cadence-torrent.yaml| 4 > .../devicetree/bindings/phy/qcom,ipq806x-usb-phy-hs.yaml| 1 - > .../devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml| 1 - > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 - > Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 2 -- > Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml | 2 -- > Documentation/devicetree/bindings/phy/renesas,usb3-phy.yaml | 1 - Acked-By: Vinod Koul -- ~Vinod ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems
On Tue, Jun 15, 2021 at 01:15:43PM -0600, Rob Herring wrote: > If a property has an 'items' list, then a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. > > This condition is partially checked with the meta-schema already, but > only if both 'minItems' and 'maxItems' are equal to the 'items' length. > An improved meta-schema is pending. > > Cc: Jens Axboe > Cc: Stephen Boyd > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Vinod Koul > Cc: Bartosz Golaszewski > Cc: Kamal Dasu > Cc: Jonathan Cameron > Cc: Lars-Peter Clausen > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Joerg Roedel > Cc: Jassi Brar > Cc: Mauro Carvalho Chehab > Cc: Krzysztof Kozlowski > Cc: Ulf Hansson > Cc: Jakub Kicinski > Cc: Wolfgang Grandegger > Cc: Marc Kleine-Budde > Cc: Andrew Lunn > Cc: Vivien Didelot > Cc: Vladimir Oltean > Cc: Bjorn Helgaas > Cc: Kishon Vijay Abraham I > Cc: Linus Walleij > Cc: "Uwe Kleine-König" > Cc: Lee Jones > Cc: Ohad Ben-Cohen > Cc: Mathieu Poirier > Cc: Philipp Zabel > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Mark Brown > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Signed-off-by: Rob Herring > --- Reviewed-by: Greg Kroah-Hartman ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH] dt-bindings: Drop redundant minItems/maxItems
If a property has an 'items' list, then a 'minItems' or 'maxItems' with the same size as the list is redundant and can be dropped. Note that is DT schema specific behavior and not standard json-schema behavior. The tooling will fixup the final schema adding any unspecified minItems/maxItems. This condition is partially checked with the meta-schema already, but only if both 'minItems' and 'maxItems' are equal to the 'items' length. An improved meta-schema is pending. Cc: Jens Axboe Cc: Stephen Boyd Cc: Herbert Xu Cc: "David S. Miller" Cc: David Airlie Cc: Daniel Vetter Cc: Vinod Koul Cc: Bartosz Golaszewski Cc: Kamal Dasu Cc: Jonathan Cameron Cc: Lars-Peter Clausen Cc: Thomas Gleixner Cc: Marc Zyngier Cc: Joerg Roedel Cc: Jassi Brar Cc: Mauro Carvalho Chehab Cc: Krzysztof Kozlowski Cc: Ulf Hansson Cc: Jakub Kicinski Cc: Wolfgang Grandegger Cc: Marc Kleine-Budde Cc: Andrew Lunn Cc: Vivien Didelot Cc: Vladimir Oltean Cc: Bjorn Helgaas Cc: Kishon Vijay Abraham I Cc: Linus Walleij Cc: "Uwe Kleine-König" Cc: Lee Jones Cc: Ohad Ben-Cohen Cc: Mathieu Poirier Cc: Philipp Zabel Cc: Paul Walmsley Cc: Palmer Dabbelt Cc: Albert Ou Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Greg Kroah-Hartman Cc: Mark Brown Cc: Zhang Rui Cc: Daniel Lezcano Cc: Wim Van Sebroeck Cc: Guenter Roeck Signed-off-by: Rob Herring --- .../devicetree/bindings/ata/nvidia,tegra-ahci.yaml | 1 - .../devicetree/bindings/clock/allwinner,sun4i-a10-ccu.yaml | 2 -- .../devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 1 - Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml | 2 -- .../devicetree/bindings/clock/qcom,gcc-sm8350.yaml | 2 -- .../devicetree/bindings/clock/sprd,sc9863a-clk.yaml | 1 - .../devicetree/bindings/crypto/allwinner,sun8i-ce.yaml | 2 -- Documentation/devicetree/bindings/crypto/fsl-dcp.yaml | 1 - .../display/allwinner,sun4i-a10-display-backend.yaml| 6 -- .../bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml | 1 - .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 .../bindings/display/allwinner,sun8i-a83t-hdmi-phy.yaml | 2 -- .../bindings/display/allwinner,sun8i-r40-tcon-top.yaml | 2 -- .../devicetree/bindings/display/bridge/cdns,mhdp8546.yaml | 2 -- .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 2 -- Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- .../devicetree/bindings/display/st,stm32-ltdc.yaml | 1 - .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 .../devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 - .../devicetree/bindings/edac/amazon,al-mc-edac.yaml | 2 -- Documentation/devicetree/bindings/eeprom/at24.yaml | 1 - Documentation/devicetree/bindings/example-schema.yaml | 2 -- Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 - Documentation/devicetree/bindings/gpu/vivante,gc.yaml | 1 - Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml | 1 - .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml| 2 -- .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml | 1 - .../devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- .../bindings/interrupt-controller/fsl,irqsteer.yaml | 1 - .../bindings/interrupt-controller/loongson,liointc.yaml | 1 - Documentation/devicetree/bindings/iommu/arm,smmu-v3.yaml| 1 - .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 1 - .../devicetree/bindings/mailbox/st,stm32-ipcc.yaml | 2 -- .../devicetree/bindings/media/amlogic,gx-vdec.yaml | 1 - Documentation/devicetree/bindings/media/i2c/adv7604.yaml| 1 - .../devicetree/bindings/media/marvell,mmp2-ccic.yaml| 1 - .../devicetree/bindings/media/qcom,sc7180-venus.yaml| 1 - .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 1 - .../devicetree/bindings/media/qcom,sm8250-venus.yaml| 1 - Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 - .../bindings/memory-controllers/mediatek,smi-common.yaml| 6 ++ .../bindings/memory-controllers/mediatek,smi-larb.yaml | 1 - .../devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml| 2 -- Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml| 1 - Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 -- Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 2 -- Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 1 - Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml| 1 - .../devicetree/bindings/net/amlogic,meson-dwmac.yaml| 2 -- .../devicetree/bindings/net/brcm,bcm4908-enet.yaml | 2 -- Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 2 -- Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml | 2 --
