On Tue, Sep 25, 2018 at 03:41:34PM +, Nath, Arindam wrote:
> It does fix an issue where eMMC controller is an ACPI HID device and
> it fails to work with IOMMU enabled.
>
> Since for the ACPI HID, there is no actual pci_dev backing it, there
> is a NULL pointer de-referencing inside
Hi Joerg,
> -Original Message-
> From: Joerg Roedel
> Sent: Tuesday, September 25, 2018 7:02 PM
> To: Nath, Arindam
> Cc: iommu@lists.linux-foundation.org; Suthikulpanit, Suravee
>
> Subject: Re: [PATCH] iommu/amd: return devid as alias for ACPI HID devices
>
&
Hi Arindam,
On Tue, Sep 18, 2018 at 03:40:58PM +0530, Arindam Nath wrote:
> @@ -246,7 +246,13 @@ static u16 get_alias(struct device *dev)
>
> /* The callers make sure that get_device_id() does not fail here */
> devid = get_device_id(dev);
> +
> + /* For ACPI HID devices, we
ACPI HID devices do not actually have an alias for
them in the IVRS. But dev_data->alias is still used
for indexing into the IOMMU device table for devices
being handled by the IOMMU. So for ACPI HID devices,
we simply return the corresponding devid as an alias,
as parsed from IVRS table.
