Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-08 Thread Rob Herring
+Andreas On Wed, Jan 7, 2015 at 12:53 PM, Will Deacon wrote: > On Wed, Jan 07, 2015 at 06:35:41PM +, Mitchel Humpherys wrote: >> On Wed, Jan 07 2015 at 10:04:20 AM, Will Deacon wrote: >> > On Wed, Jan 07, 2015 at 05:52:46PM +, Mitchel Humpherys wrote: >> >> On Wed, Jan 07 2015 at 02:13:0

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-07 Thread Will Deacon
On Wed, Jan 07, 2015 at 06:35:41PM +, Mitchel Humpherys wrote: > On Wed, Jan 07 2015 at 10:04:20 AM, Will Deacon wrote: > > On Wed, Jan 07, 2015 at 05:52:46PM +, Mitchel Humpherys wrote: > >> On Wed, Jan 07 2015 at 02:13:00 AM, Will Deacon > >> wrote: > >> > If would be better to check f

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-07 Thread Mitchel Humpherys
On Wed, Jan 07 2015 at 10:04:20 AM, Will Deacon wrote: > On Wed, Jan 07, 2015 at 05:52:46PM +, Mitchel Humpherys wrote: >> On Wed, Jan 07 2015 at 02:13:00 AM, Will Deacon wrote: >> > On Tue, Jan 06, 2015 at 11:30:49PM +, Mitchel Humpherys wrote: >> >> On Tue, Jan 06 2015 at 02:35:28 PM, R

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-07 Thread Will Deacon
On Wed, Jan 07, 2015 at 05:52:46PM +, Mitchel Humpherys wrote: > On Wed, Jan 07 2015 at 02:13:00 AM, Will Deacon wrote: > > On Tue, Jan 06, 2015 at 11:30:49PM +, Mitchel Humpherys wrote: > >> On Tue, Jan 06 2015 at 02:35:28 PM, Rob Herring > >> wrote: > >> > On Tue, Jan 6, 2015 at 2:16 P

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-07 Thread Mitchel Humpherys
On Wed, Jan 07 2015 at 02:13:00 AM, Will Deacon wrote: > On Tue, Jan 06, 2015 at 11:30:49PM +, Mitchel Humpherys wrote: >> On Tue, Jan 06 2015 at 02:35:28 PM, Rob Herring >> wrote: >> > On Tue, Jan 6, 2015 at 2:16 PM, Mitchel Humpherys >> > wrote: >> >> On Tue, Jan 06 2015 at 06:15:07 AM, W

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-07 Thread Will Deacon
On Tue, Jan 06, 2015 at 11:30:49PM +, Mitchel Humpherys wrote: > On Tue, Jan 06 2015 at 02:35:28 PM, Rob Herring wrote: > > On Tue, Jan 6, 2015 at 2:16 PM, Mitchel Humpherys > > wrote: > >> On Tue, Jan 06 2015 at 06:15:07 AM, Will Deacon > >> wrote: > /* Invalidate the TLB, just i

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-06 Thread Mitchel Humpherys
On Tue, Jan 06 2015 at 02:35:28 PM, Rob Herring wrote: > On Tue, Jan 6, 2015 at 2:16 PM, Mitchel Humpherys > wrote: >> On Tue, Jan 06 2015 at 06:15:07 AM, Will Deacon wrote: /* Invalidate the TLB, just in case */ -writel_relaxed(0, gr0_base + ARM_SMMU_GR0_STLBIALL);

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-06 Thread Rob Herring
On Tue, Jan 6, 2015 at 2:16 PM, Mitchel Humpherys wrote: > On Tue, Jan 06 2015 at 06:15:07 AM, Will Deacon wrote: >>> /* Invalidate the TLB, just in case */ >>> -writel_relaxed(0, gr0_base + ARM_SMMU_GR0_STLBIALL); >>> writel_relaxed(0, gr0_base + ARM_SMMU_GR0_TLBIALLH); >>> wr

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-06 Thread Mitchel Humpherys
On Tue, Jan 06 2015 at 06:15:07 AM, Will Deacon wrote: >> /* Invalidate the TLB, just in case */ >> -writel_relaxed(0, gr0_base + ARM_SMMU_GR0_STLBIALL); >> writel_relaxed(0, gr0_base + ARM_SMMU_GR0_TLBIALLH); >> writel_relaxed(0, gr0_base + ARM_SMMU_GR0_TLBIALLNSNH); > > I was

Re: [PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2015-01-06 Thread Will Deacon
Hi Mitch, On Tue, Dec 23, 2014 at 05:39:22PM +, Mitchel Humpherys wrote: > Currently we do a STLBIALL when we initialize the SMMU. However, in > some configurations that register is not supposed to be touched and is > marked as "Secure only" in the spec. Rip it out. > > Signed-off-by: Mitch

[PATCH] iommu/arm-smmu: don't touch the secure STLBIALL register

2014-12-23 Thread Mitchel Humpherys
Currently we do a STLBIALL when we initialize the SMMU. However, in some configurations that register is not supposed to be touched and is marked as "Secure only" in the spec. Rip it out. Signed-off-by: Mitchel Humpherys --- drivers/iommu/arm-smmu.c | 2 -- 1 file changed, 2 deletions(-) diff