Re: [PATCH] iommu/arm-smmu: fix leak in arm_smmu_flush_pgtable

2015-03-05 Thread Robin Murphy
On 05/03/15 17:28, Mitchel Humpherys wrote: On Thu, Mar 05 2015 at 02:38:45 AM, Robin Murphy wrote: Hi Mitch, On 05/03/15 00:18, Mitchel Humpherys wrote: We're currently mapping a page in arm_smmu_flush_pgtable without ever unmapping it. Fix this by calling dma_unmap_page on the returned dma

Re: [PATCH] iommu/arm-smmu: fix leak in arm_smmu_flush_pgtable

2015-03-05 Thread Will Deacon
On Thu, Mar 05, 2015 at 05:28:02PM +, Mitchel Humpherys wrote: > On Thu, Mar 05 2015 at 02:38:45 AM, Robin Murphy wrote: > > On 05/03/15 00:18, Mitchel Humpherys wrote: > >> We're currently mapping a page in arm_smmu_flush_pgtable without ever > >> unmapping it. Fix this by calling dma_unmap_

Re: [PATCH] iommu/arm-smmu: fix leak in arm_smmu_flush_pgtable

2015-03-05 Thread Mitchel Humpherys
On Thu, Mar 05 2015 at 02:38:45 AM, Robin Murphy wrote: > Hi Mitch, > > On 05/03/15 00:18, Mitchel Humpherys wrote: >> We're currently mapping a page in arm_smmu_flush_pgtable without ever >> unmapping it. Fix this by calling dma_unmap_page on the returned dma >> address. Since the only reason w

Re: [PATCH] iommu/arm-smmu: fix leak in arm_smmu_flush_pgtable

2015-03-05 Thread Robin Murphy
Hi Mitch, On 05/03/15 00:18, Mitchel Humpherys wrote: We're currently mapping a page in arm_smmu_flush_pgtable without ever unmapping it. Fix this by calling dma_unmap_page on the returned dma address. Since the only reason we're calling dma_map_page is to make sure it actually gets flushed ou

[PATCH] iommu/arm-smmu: fix leak in arm_smmu_flush_pgtable

2015-03-04 Thread Mitchel Humpherys
We're currently mapping a page in arm_smmu_flush_pgtable without ever unmapping it. Fix this by calling dma_unmap_page on the returned dma address. Since the only reason we're calling dma_map_page is to make sure it actually gets flushed out to RAM, we can just call dma_unmap_page immediately fol