Re: [PATCH] iommu/dma: Fix condition check in iommu_dma_unmap_sg

2019-06-03 Thread Joerg Roedel
On Wed, May 29, 2019 at 01:15:32AM -0700, Nathan Chancellor wrote: > Fixes: 06d60728ff5c ("iommu/dma: move the arm64 wrappers to common code") > Link: https://github.com/ClangBuiltLinux/linux/issues/497 > Signed-off-by: Nathan Chancellor > --- > drivers/iommu/dma-iommu.c | 2 +- > 1 file changed,

Re: [PATCH] iommu/dma: Fix condition check in iommu_dma_unmap_sg

2019-05-29 Thread Christoph Hellwig
Ooops, thanks for catching this: Reviewed-by: Christoph Hellwig

Re: [PATCH] iommu/dma: Fix condition check in iommu_dma_unmap_sg

2019-05-29 Thread Robin Murphy
On 29/05/2019 09:15, Nathan Chancellor wrote: Clang warns: drivers/iommu/dma-iommu.c:897:6: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) == 0) ^

[PATCH] iommu/dma: Fix condition check in iommu_dma_unmap_sg

2019-05-29 Thread Nathan Chancellor
Clang warns: drivers/iommu/dma-iommu.c:897:6: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) == 0) ^ ~~ drivers/iommu/dma-iommu.c:897:6: note: add pa