Re: [PATCH] iommu/dma: Handle MSI mappings separately

2019-08-06 Thread Joerg Roedel
On Mon, Jul 29, 2019 at 04:32:38PM +0100, Robin Murphy wrote: > drivers/iommu/dma-iommu.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) Applied to iommu/fixes, thanks Robin. ___ iommu mailing list

Re: [PATCH] iommu/dma: Handle MSI mappings separately

2019-07-30 Thread Christoph Hellwig
On Tue, Jul 30, 2019 at 11:43:25AM +0100, Robin Murphy wrote: > > Hmm. I remember proposing this patch and you didn't like it because > > we could also have msis for a !IOMMU_DMA_IOVA_COOKIE cookie type. > > Or did we talk past each other? > > Do you have a pointer? That sparks the vaguest of

Re: [PATCH] iommu/dma: Handle MSI mappings separately

2019-07-30 Thread Robin Murphy
On 30/07/2019 07:28, Christoph Hellwig wrote: On Mon, Jul 29, 2019 at 04:32:38PM +0100, Robin Murphy wrote: MSI pages must always be mapped into a device's *current* domain, which *might* be the default DMA domain, but might instead be a VFIO domain with its own MSI cookie. This subtlety got

Re: [PATCH] iommu/dma: Handle MSI mappings separately

2019-07-30 Thread Christoph Hellwig
On Mon, Jul 29, 2019 at 04:32:38PM +0100, Robin Murphy wrote: > MSI pages must always be mapped into a device's *current* domain, which > *might* be the default DMA domain, but might instead be a VFIO domain > with its own MSI cookie. This subtlety got accidentally lost in the > streamlining of

Re: [PATCH] iommu/dma: Handle MSI mappings separately

2019-07-29 Thread Marc Zyngier
On 2019-07-29 16:32, Robin Murphy wrote: MSI pages must always be mapped into a device's *current* domain, which *might* be the default DMA domain, but might instead be a VFIO domain with its own MSI cookie. This subtlety got accidentally lost in the streamlining of __iommu_dma_map(), but

Re: [PATCH] iommu/dma: Handle MSI mappings separately

2019-07-29 Thread Andre Przywara
On Mon, 29 Jul 2019 16:32:38 +0100 Robin Murphy wrote: Hi, > MSI pages must always be mapped into a device's *current* domain, which > *might* be the default DMA domain, but might instead be a VFIO domain > with its own MSI cookie. This subtlety got accidentally lost in the > streamlining of

RE: [PATCH] iommu/dma: Handle MSI mappings separately

2019-07-29 Thread Shameerali Kolothum Thodi
odi ; > linux-arm-ker...@lists.infradead.org; Andre Przywara > > Subject: [PATCH] iommu/dma: Handle MSI mappings separately > > MSI pages must always be mapped into a device's *current* domain, which > *might* be the default DMA domain, but might instead be a VFIO domain >

[PATCH] iommu/dma: Handle MSI mappings separately

2019-07-29 Thread Robin Murphy
MSI pages must always be mapped into a device's *current* domain, which *might* be the default DMA domain, but might instead be a VFIO domain with its own MSI cookie. This subtlety got accidentally lost in the streamlining of __iommu_dma_map(), but rather than reintroduce more complexity and/or