Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-14 Thread Peter Xu
On Wed, Dec 13, 2017 at 11:31:02AM -0600, Hook, Gary wrote: > On 12/13/2017 11:15 AM, Alex Williamson wrote: > > On Wed, 13 Dec 2017 10:41:47 -0600 > > "Hook, Gary" wrote: > > > > > On 12/13/2017 9:58 AM, Alex Williamson wrote: > > > > On Wed, 13 Dec 2017 15:13:55 +0800 > > > >

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-14 Thread kbuild test robot
Hi Alex, I love your patch! Yet something to improve: [auto build test ERROR on v4.15-rc3] [also build test ERROR on next-20171214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-13 Thread Hook, Gary
On 12/13/2017 11:15 AM, Alex Williamson wrote: On Wed, 13 Dec 2017 10:41:47 -0600 "Hook, Gary" wrote: On 12/13/2017 9:58 AM, Alex Williamson wrote: On Wed, 13 Dec 2017 15:13:55 +0800 Peter Xu wrote: On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-13 Thread Alex Williamson
On Wed, 13 Dec 2017 10:41:47 -0600 "Hook, Gary" wrote: > On 12/13/2017 9:58 AM, Alex Williamson wrote: > > On Wed, 13 Dec 2017 15:13:55 +0800 > > Peter Xu wrote: > > > >> On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote: > >> > >> [...] > >>

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-13 Thread Hook, Gary
On 12/13/2017 9:58 AM, Alex Williamson wrote: On Wed, 13 Dec 2017 15:13:55 +0800 Peter Xu wrote: On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote: [...] diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c index 9a7ffd13c7f0..87888b102057 100644 ---

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-13 Thread Alex Williamson
On Wed, 13 Dec 2017 15:13:55 +0800 Peter Xu wrote: > On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote: > > [...] > > > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > > index 9a7ffd13c7f0..87888b102057 100644 > > --- a/drivers/iommu/dmar.c > > +++

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-12 Thread Peter Xu
On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote: [...] > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index 9a7ffd13c7f0..87888b102057 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1345,7 +1345,9 @@ void qi_flush_dev_iotlb(struct intel_iommu

[PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-12 Thread Alex Williamson
> Detected by ubsan: > > UBSAN: Undefined behaviour in drivers/iommu/dmar.c:1345:3 > shift exponent 64 is too large for 32-bit type 'int' > CPU: 2 PID: 1167 Comm: perf_pmu Not tainted 4.14.0-rc5+ #532 > Hardware name: LENOVO 80MX/Lenovo E31-80, BIOS DCCN34WW(V2.03) 12/01/2015 > Call