RE: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-24 Thread James Dong via iommu
Baolu: Yes, it is a generic issue for hotplug devices with current Intel IOMMU driver, as reported in this thread as well. The patch you provided does the job in our case. Please update this thread once your patch is merged. Thanks. Best Regards, James On 2/23/19 12:56 AM, Lu Baolu wrote > >

Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-24 Thread Lu Baolu
Hi James, On 2/22/19 3:36 PM, James Dong wrote: Baolu: Sorry that my last reply email seems not text format. Resend it now. Thanks for your comments and your patch. Please find below our responses to each of your comments: What does "I/O operation won't work" exactly mean here? Do you see

Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-22 Thread Jis Ben via iommu
An NVMe device configured in static identity mapping should also cause this error when removed and rescanned. Essentially, a device that does a DMA when its driver inits, or one that you can force a DMA from. On Fri, Feb 22, 2019 at 12:28 AM James Dong wrote: > Baolu: > > The reproduction

Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-22 Thread Jis Ben via iommu
An NVMe device configured in static identity mapping should also cause this error when removed and rescanned. Essentially, a device that does a DMA when its driver inits, or one that you can force a DMA from. -Jis On Fri, Feb 22, 2019 at 12:28 AM James Dong wrote: > > Baolu: > > The

RE: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-22 Thread James Dong via iommu
Baolu: The reproduction depends on devices. HW passthrough PCIe devices with default identity map could have the issue. Make sure that messages like following came out in dmesg and their mapping does not change after booting: [ 10.167809] DMAR: Hardware identity mapping for device

Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-21 Thread Lu Baolu
Hi James, On 2/22/19 2:38 PM, James Dong wrote: Tried this patch, and the same DMAR fault message came out. Guess it is because of the iommu code path for hotplug devices. If a hotplug device is rescanned after removal, iommu_bus_notifier will be called as part of the notifier chains to

RE: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-21 Thread James Dong via iommu
Baolu: Sorry that my last reply email seems not text format. Resend it now. Thanks for your comments and your patch. Please find below our responses to each of your comments: > What does "I/O operation won't work" exactly mean here? Do you see any > IOMMU fault message? Or, something doesn't

Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-21 Thread James Dong via iommu
Baolu: Thanks for your comments and your patch. Please find below our responses to each of your comments: > What does "I/O operation won't work" exactly mean here? Do you see any > IOMMU fault message? Or, something doesn't work as expected? Yes, DMAR fault messages as following came out: [

Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-21 Thread Lu Baolu
Hi On 2/22/19 1:06 PM, Lu Baolu wrote: Do you mind checking this? diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 6ecdcf8fc8c0..f62f30bc1339 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -2632,6 +2632,9 @@ static struct dmar_domain

Re: [PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-21 Thread Lu Baolu
Hi, On 2/22/19 10:44 AM, James Dong wrote: With specific Linux command line option such as "iommu=pt", some types of hotplug devices will be assigned to the static 1:1 iommu domain by default during kernel init. If such a hotplug device is rescanned after being removed, for example, with

[PATCH] iommu/vt-d: Handle hotplug devices' default identity mapping setting

2019-02-21 Thread James Dong via iommu
With specific Linux command line option such as "iommu=pt", some types of hotplug devices will be assigned to the static 1:1 iommu domain by default during kernel init. If such a hotplug device is rescanned after being removed, for example, with following sample commands: echo 1 >